From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wPWkGJtZtmGTGwAAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 21:20:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4MBAFJtZtmGRUgAAbx9fmQ (envelope-from ) for ; Sun, 12 Dec 2021 20:20:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E581196DF for ; Sun, 12 Dec 2021 21:20:42 +0100 (CET) Received: from localhost ([::1]:38118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwVKn-0005nq-Ee for larch@yhetil.org; Sun, 12 Dec 2021 15:20:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwVKF-0005nZ-58 for guix-patches@gnu.org; Sun, 12 Dec 2021 15:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwVKE-0002fW-SA for guix-patches@gnu.org; Sun, 12 Dec 2021 15:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwVKE-0002NI-Gj for guix-patches@gnu.org; Sun, 12 Dec 2021 15:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 04/43] gnu: node: Add an npmrc file to set nodedir. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 51838@debbugs.gnu.org X-Debbugs-Original-Cc: 51838@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16393403529061 (code B ref -1); Sun, 12 Dec 2021 20:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2021 20:19:12 +0000 Received: from localhost ([127.0.0.1]:53233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVJP-0002M4-Ub for submit@debbugs.gnu.org; Sun, 12 Dec 2021 15:19:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:39776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVJO-0002Ls-CB for submit@debbugs.gnu.org; Sun, 12 Dec 2021 15:19:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwVJN-0005lS-7P for guix-patches@gnu.org; Sun, 12 Dec 2021 15:19:09 -0500 Received: from [2607:f8b0:4864:20::92c] (port=37795 helo=mail-ua1-x92c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwVJL-0002bc-23 for guix-patches@gnu.org; Sun, 12 Dec 2021 15:19:08 -0500 Received: by mail-ua1-x92c.google.com with SMTP id o1so25916808uap.4 for ; Sun, 12 Dec 2021 12:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/w5+MkleRl86arSpXWLolmhpNEs5ZSp8uvtUchoA6Qc=; b=jT24bmOZj2juiV88UwreGhw2efWpsdr939oHBn7gPUewwI20AgHsm7BUcx/7fWSNsT 4uAeeoOxKxeavj4HZIUIyOFY74Ca06BH8xqB4M9kmVx6EpaPdvZNuoywRmEdFxpQIziL asvlNkVi5vXKfKHJDHLYikKfZ4g3kVauFbRywfgNKeVs7ZgKXUR3FVJAJf0P/2G28myS Z+Ex2Pl+NkJzkto1Da1I4mqC1T+nBtLhyhhpb6hqPpY3cTIFlGTFSYJduAcHh1HmLPLZ IR2xiDJSzyQosCbJJE2GwV4HSoQvQBcYnxNKmsAJ8jYwL+xc/jHD366PClJpixmvjzdz UimA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/w5+MkleRl86arSpXWLolmhpNEs5ZSp8uvtUchoA6Qc=; b=WuqTa1FJArmSgDPiTar3THoVqVCdm/9HXpjc6p4QJwMqbcF6Ax5lcOdQzrs50EAUgR xFYGPTkCL2BEdacBdC26TZFJDO5BG66zi1MHTh0xbL1EXEiLCIk5wOwclYxwRzJ//y1J 4AAifXY9YxfXlCoKLd7jOIQrqcck16btwOwxzaYmd4wVqKEKkNxY1VxSR4AhDY/KZaj5 SDBXZkpdHbOm6O9JvJLAF5E4AkdRWvlio4wf2SCxrMSiJS4+2I70WMoy+dNXom9skVEE aMK1EQPasmROocaYJ4GaFBM4PW57B8GOopiHGJLG3JUKr0EaJ16dQxMdDi99WG9nxT6B lqdA== X-Gm-Message-State: AOAM532qzkx3nYOLLN66aejL6+68oKkjV/RbHwZelsr//mmawD+NebTA JeC1vA1SoncLukJc9Ir5yJR2cfrsLwa9SuPT248= X-Google-Smtp-Source: ABdhPJwp6/pmn/IkPKKpr0F84h3UUunoOhhQTNF1fWSu/rbkMvrm9RE8EieMr7BK+TW/8PGd9HZUQA== X-Received: by 2002:a05:6102:d8d:: with SMTP id d13mr24710909vst.54.1639340345291; Sun, 12 Dec 2021 12:19:05 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id l11sm3626153uak.4.2021.12.12.12.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 12:19:05 -0800 (PST) Message-ID: <5c62c3ce-dd50-5dcd-00ed-ff1524be4e0b@philipmcgrath.com> Date: Sun, 12 Dec 2021 15:19:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> <20211208202838.752542-5-philip@philipmcgrath.com> <877dc924h7.fsf@gmx.com> From: Philip McGrath In-Reply-To: <877dc924h7.fsf@gmx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::92c (failed) Received-SPF: neutral client-ip=2607:f8b0:4864:20::92c; envelope-from=philip@philipmcgrath.com; helo=mail-ua1-x92c.google.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.051, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639340443; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/w5+MkleRl86arSpXWLolmhpNEs5ZSp8uvtUchoA6Qc=; b=J+IonG0pRXLW1G9sG5KdQbCNHbturBwnKIn5x5c+9OUaEd9OecI7afOxsaeF2XXAZE050W KPWA1FsPTjtMuNOMsyufXC2093vCaWq3qc+OhSgexPXSHMoVipND1P//5ZWOTlU7Pi344K 8SWuZusrEbimLSReaf2fgKSpslUU1p0PeOlR4JdcuQIrmOj+bOYe9MqgWflhq3ItSrgW1Z MXpdxuF/dKRuqqfR96t1KWfZa5fPRhpsuuSJ/u4GLpO5YBkarxndViSnjUxWSzFyfWoA3V VCt4N7Ex/UjjOBfiAeL6kYEE2QlVdSqa9UX9xzlqdC3MivkAwYqTpiWQ4llWrA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639340443; a=rsa-sha256; cv=none; b=ECFWsyrVl+WW2OEIFHaXwOL2iBzIcdueS2TOCzZ0/LDzf48sV6ALLFPc9qtG7csYYPiLfC YtMLaDwmOBGuj5HnJ6FqxMHweythDMZPe6h0UL2DHAQw5V4NlP8ztw16WFFOLKmqF5QH7G DE0KGC3Pvi97BPbPxeOxKP3veMwlGQqLrjuUOiPJ7BqhfEac+CNprpTkiaWeFZk7xsWWf0 ibT0E3sc9ggAfS7/+teh+IWwTD+wG9PHm+eikeHQB0VnWNh46PInKuA+VbpNsHFz10wF7A mIJ1AMAxXqZOZ42nt0QcvIoCM9TjCq+JqBtQ5kGHGMDCDMBf0YcFlytFXqtFgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=jT24bmOZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=jT24bmOZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E581196DF X-Spam-Score: -2.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: y4q8n/I95E/J Hi! On 12/12/21 10:19, Pierre Langlois wrote: > When I run `node-gyp configure' in my tree-sitter packages, it's not > able to find the node dir and tries to download headers. So I need to > set `npm_config_nodedir' manually, like so: > I'm wondering if the npmrc approach here is working properly? I see in > another patch you've used the `npx' command to run `node-gyp rebuild', > should I be using that? The npmrc configuration will only work of node-gyp is run through npm (or npx): https://github.com/nodejs/node-gyp#npm-configuration In general, my current understanding is that you shouldn't have to run `node-gyp configure` explicitly. First, `node-gyp rebuild` includes a `node-gyp configure` step, but, more broadly, Guix's configure and build phases should usually do any needed addon building automatically. Aside from packages that deleted the configue phase, the main exception I've found is packages that try to use some strategy for downloading pre-built binaries: in some cases I've patched them enough to make automatic compilation work, but maybe sometimes just doing things manually is less work. If you do need to run `node-gyp` explicitly, the `npx` approach is the best I've found. -Philip