[bug#57347] [PATCH] packages: Add man-pages-posix.

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1445 bytes --]

On 22-08-2022 22:42, Lilah Tascheter via Guix-patches via wrote:

> +    (home-page"https://www.kernel.org/doc/man-pages/")
> +    (synopsis "Man pages from the POSIX.1-2013 standard")
> +    (description "This package contains excerpts from the POSIX.1-2008 and TC1
> +standards (collectively, POSIX.1-2013) in manual page form.")

This package can easily be confused with 'man-pages' -- at least, I 
initially confused this as a duplicate of man-pages. Could the 
relationship be clarified in the description?

> +    (arguments
> +     '(#:tests? #f
> +       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
> +       #:license-file-regexp "POSIX-COPYRIGHT"
> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (replace 'build
> +                    (lambda _
> +                      ;; make all is useless due to guix build semantics, so just gzip.
> +                      ;; Parallel builds are useless with how the Makefile's setup.
> +                      (invoke "make" "gz"))))))
Maybe (assoc-ref %outputs "out") -> #$output and '(#:tests? ...) -> 
(list #:tests? #f #:make-flags #~(list ...) #:phases #~(...)), now we 
have G-exps.

Also, IIRC there's a #:make-target and #:parallel-build? #false

As a bonus, you could update the 'man-pages' package to the new G-exps, 
though not required.

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]