unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Bruno Victal <mirai@makinata.eu>
To: Fabio Natali <me@fabionatali.com>
Cc: arunisaac@systemreboot.net, 72398@debbugs.gnu.org
Subject: [bug#72398] [PATCH v4] services: Add readymedia-service-type.
Date: Fri, 23 Aug 2024 16:35:10 +0100	[thread overview]
Message-ID: <5c35d80d-610f-4521-875b-34dabdc7717f@makinata.eu> (raw)
In-Reply-To: <d24b715465fe88c32c2543ff7e42ff8e1339c21a.1724411076.git.me@fabionatali.com>

On 2024-08-23 12:04, Fabio Natali via Guix-patches via wrote:

> Here's a short recap of how to test this.
> 
> Save this system definition in a file, e.g. '/tmp/config.scm'. Note the insecure
> user credentials.

Think you can go the extra step and write a system test for this?
That'd greatly simplify future checks and ease the maintenance burden
as well.

> +Consider the following configuration:
> +
> +@lisp
> +(use-service-modules upnp @dots{})
> +
> +(operating-system
> +  ;; @dots{}
> +  (services
> +   (list
> +    (service readymedia-service-type
> +             (readymedia-configuration
> +              (media-directoriess
> +               (list
> +                (readymedia-media-directory (path "/media/audio")
> +                                            (type 'A))
> +                (readymedia-media-directory (path "/media/video")
> +                                            (type 'V))
> +                (readymedia-media-directory (path "/media/misc"))))

Since the types can be a combination, you're going to want to express these
as a list, e.g.

--8<---------------cut here---------------start------------->8---
 (type '(A))
 (type '(A P))
 …
--8<---------------cut here---------------end--------------->8---

an empty list being the default value standing for "no type specified"
if I got the meaning right from the documentation.


-- 
Cheers,
Bruno.





  reply	other threads:[~2024-08-23 15:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 10:27 [bug#72398] [PATCH] services: Add readymedia-service-type Fabio Natali via Guix-patches via
2024-08-12 23:19 ` Arun Isaac
2024-08-19  0:27   ` Fabio Natali via Guix-patches via
2024-08-20  2:14     ` [bug#72398] [PATCH v2] " Bruno Victal
2024-08-22 10:13       ` Fabio Natali via Guix-patches via
2024-08-22 23:28         ` Arun Isaac
2024-08-23 11:04           ` [bug#72398] [PATCH v4] " Fabio Natali via Guix-patches via
2024-08-23 15:35             ` Bruno Victal [this message]
2024-08-26 10:11               ` [bug#72398] [PATCH v5] " Fabio Natali via Guix-patches via
2024-09-06 22:17                 ` Ludovic Courtès
2024-09-08 20:04                   ` [bug#72398] [PATCH v6] " Fabio Natali via Guix-patches via
2024-08-23 15:25           ` [bug#72398] [PATCH v2] " Bruno Victal
2024-08-28 22:51             ` Arun Isaac
2024-08-29 14:37               ` Fabio Natali via Guix-patches via
2024-08-22 23:22       ` Arun Isaac
2024-08-22 10:17 ` [bug#72398] [PATCH v3] " Fabio Natali via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c35d80d-610f-4521-875b-34dabdc7717f@makinata.eu \
    --to=mirai@makinata.eu \
    --cc=72398@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=me@fabionatali.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).