From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gILuDiBR7WZZewAAqHPOHw:P1 (envelope-from ) for ; Fri, 20 Sep 2024 10:40:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id gILuDiBR7WZZewAAqHPOHw (envelope-from ) for ; Fri, 20 Sep 2024 12:40:32 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bCPBOtNL; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=aNYbi9mX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726828831; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DwAo2jQ1bi8kjcxB4jfOBU7q1povzjxlSAJ+YxbvP9g=; b=YWhSyXcHUIYzHjzQlz/jljI/dAp5AkFceKUzr00u+MMaanxEJ9NtQ4/Cw/b3YVHcwY2vG3 RjFG2Gn1AorEc9H0v/pxO15psKzbn2lMbcsevEoFMD0wH7i2oAelAJqzBTW/wVtsxy90F9 a6/WJqG15VzB4XNbNQkyozXtHN2KF6EjIRf40LxMjVcq4tF+fXAFU8Jv6bqbctAQTP+xOH ro7f1uCGgSLetCEy5b10p0Eir2Mn/JLyOn9IfjM+Nr4CBK/NPX3yisnDqFpMdOshmtwcwm ejjhLW856XLwKXh2h3YrU/eoHq2WdzOYtzxYYnCRQvizEasCKEBaiyzsFNMypA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bCPBOtNL; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=aNYbi9mX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726828831; a=rsa-sha256; cv=none; b=qLEIaK5R3AidO+2fWNroE55tGoTQaOhc3Na9b9zjwB++jnjD5ndZTjoQqC4Yq1tL2YxlR8 jTghiV/Z+h+/RLqbKyVMxRSYiKsvoSi5kJggEqkr3dmVC3MRJQLl1Ne5+o7EHLn52gXYrz +/szYdhagVs5zQypCQRLQeITWQ8ewjSoQVVcCNJqCdyM+F87rF2b38PMAL8mI57DUm+7EQ Q7RfG7xpt1HISXtMl6MGFk2M2WVexUmoUr1RfpTsbZnqrJ/4CRZWvKpDTIfZg+JSb8LTCr 7f5Sxv4GYVWhrXlzX5CSejduff3wL8eqSTSOYueKVFPc+wbLhsodNpiqPaG65w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C275768D88 for ; Fri, 20 Sep 2024 12:40:30 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srb3i-0005Fy-CB; Fri, 20 Sep 2024 06:40:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srb3H-0004yD-N4 for guix-patches@gnu.org; Fri, 20 Sep 2024 06:39:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srb3H-0006Us-Dz; Fri, 20 Sep 2024 06:39:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=Bj9ZDIvw5OCFlD6u8fVX/9sYNyNWlWS/InS4TKWgGQA=; b=bCPBOtNLjrb4Vq0u/R8kcNAZLVLX4mIkenqw59oQJjr7y0OlhKlyOdxSVBxC1Ril8KUsHvwKB1Y98PH/63BZEu+myeDil7qrh+T0n9jwbp/eQE3kR/IALXXz/ytRktn7ZTIZH5vYZj2KYdInSYadRLMoRt0LicYOo3nAkK1zfkN/tbbx2iY1zvhfucUu3SRoshGTNf2FBe1kfelkAaLodTWWUDrI5s88sO3Cw2lZWbWd8htKIEOGA2FcHzxSx3BnM8mrshVshhM08SzI4a5qbyhGqLTgZog0+6Q+XEIFGx+8kDA5JuTevpbYXRnBXMM3rvm0vaIFi6BvfJLTBWiZLw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srb3X-0001Q3-Nm; Fri, 20 Sep 2024 06:40:07 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73202] [PATCH v2 05/15] guix: scripts: Rewrite reinstall-bootloader to use provenance data. Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Fri, 20 Sep 2024 10:40:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73202 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73202@debbugs.gnu.org Cc: Lilah Tascheter , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 73202-submit@debbugs.gnu.org id=B73202.17268287825301 (code B ref 73202); Fri, 20 Sep 2024 10:40:07 +0000 Received: (at 73202) by debbugs.gnu.org; 20 Sep 2024 10:39:42 +0000 Received: from localhost ([127.0.0.1]:34169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srb37-0001NI-G8 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 06:39:42 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:43185 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srb2q-0001Kd-Ip for 73202@debbugs.gnu.org; Fri, 20 Sep 2024 06:39:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1726828735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DwAo2jQ1bi8kjcxB4jfOBU7q1povzjxlSAJ+YxbvP9g=; b=aNYbi9mXbzaI64734AdfUFR5NZMEwIZdJ23tUnigE1V85rxw7eBfnIq/6jZ1KwgOC1N2+n K2R9uJkE2rpokXA7QK9cK4XWemRuvgSI71WsCjsCyoH1pxRwNb4oiMiXZeTHZ36uCYdrXy hh5MxtQsZraCiTFJDz10m76me2LGHKni9WX1OWZKKKGi1giqme+Lp3K/928L44OURBhUc4 RRVzCVhJtFP1ZOhE+8RrgmJMZnflPI8Cwbmv7YjPHQAj83cYz1hFoBPkgu5I5dO8e20DIQ +TyH2TCQTrHu1lrzoR74RWMciCExxdRMcl8m+ERZhxGepXaCyeBDG8hdwS2nSg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 171fd720 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 20 Sep 2024 10:38:54 +0000 (UTC) Date: Fri, 20 Sep 2024 12:37:50 +0200 Message-ID: <5b95c2bdceeeefb36857f7dfb869d19140fbae9d.1726827025.git.herman@rimm.ee> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches From: Herman Rimm via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: C275768D88 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -5.51 X-Migadu-Spam-Score: -5.51 X-TUID: 6z7lKixJfsMe From: Lilah Tascheter Looking up bootloaders by name is broken because (extlinux) bootloaders share a name. Also, bootloader-configuration data is significant to bootloader installation, so it shouldn't just use the default values. Installation can rely on the provenance service instead, which should be present for the vast majority of systems. * gnu/bootloader.scm (%bootloaders): Delete variable. (lookup-bootloader-by-name, bootloader-modules): Delete procedures. * guix/scripts/system.scm (install-bootloader-from-os, install-bootloader-from-provenance): Add procedures. (reinstall-bootloader): Remove procedure. (switch-to-system-generation, process-command): Use install-bootloader-from-provenance. Change-Id: I5713a43ad4f9f32a129d980db06d70de16b03f27 --- gnu/bootloader.scm | 26 --------------- guix/scripts/system.scm | 74 ++++++++++++++++------------------------- 2 files changed, 28 insertions(+), 72 deletions(-) diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 865521e6e5..3ea50a4004 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -26,7 +26,6 @@ (define-module (gnu bootloader) #:use-module (gnu system file-systems) #:use-module (gnu system uuid) - #:use-module (guix discovery) #:use-module (guix gexp) #:use-module (guix profiles) #:use-module (guix records) @@ -79,8 +78,6 @@ (define-module (gnu bootloader) bootloader-configuration-device-tree-support? bootloader-configuration-extra-initrd - %bootloaders - lookup-bootloader-by-name efi-bootloader-chain)) @@ -287,29 +284,6 @@ (define (bootloader-configuration-targets config) ;;; Bootloaders. ;;; -(define (bootloader-modules) - "Return the list of bootloader modules." - (all-modules (map (lambda (entry) - `(,entry . "gnu/bootloader")) - %load-path) - #:warn warn-about-load-error)) - -(define %bootloaders - ;; The list of publically-known bootloaders. - (delay (fold-module-public-variables (lambda (obj result) - (if (bootloader? obj) - (cons obj result) - result)) - '() - (bootloader-modules)))) - -(define (lookup-bootloader-by-name name) - "Return the bootloader called NAME." - (or (find (lambda (bootloader) - (eq? name (bootloader-name bootloader))) - (force %bootloaders)) - (leave (G_ "~a: no such bootloader~%") name))) - (define (efi-bootloader-profile packages files hooks) "Creates a profile from the lists of PACKAGES and FILES from the store. This profile is meant to be used by the bootloader-installer. diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 83a4de39d0..d23f9153e5 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -11,6 +11,8 @@ ;;; Copyright © 2021 Brice Waegeneire ;;; Copyright © 2021 Simon Tournier ;;; Copyright © 2022 Tobias Geerinckx-Rice +;;; Copyright © 2024 Lilah Tascheter +;;; Copyright © 2024 Herman Rimm ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +90,7 @@ (define-module (guix scripts system) #:use-module (srfi srfi-37) #:use-module (ice-9 format) #:use-module (ice-9 match) + #:use-module (ice-9 receive) #:use-module (rnrs bytevectors) #:export (guix-system read-operating-system @@ -377,61 +380,39 @@ (define (switch-to-system-generation store spec) (activate (string-append generation "/activate"))) (if number (begin - (reinstall-bootloader store number) + (install-bootloader-from-provenance store number) (switch-to-generation* %system-profile number) (unless-file-not-found (primitive-load activate))) (leave (G_ "cannot switch to system generation '~a'~%") spec)))) -(define* (system-bootloader-name #:optional (system %system-profile)) - "Return the bootloader name stored in SYSTEM's \"parameters\" file." - (let ((params (unless-file-not-found - (read-boot-parameters-file system)))) - (boot-parameters-bootloader-name params))) - -(define (reinstall-bootloader store number) - "Re-install bootloader for existing system profile generation NUMBER. -STORE is an open connection to the store." - (let* ((generation (generation-file-name %system-profile number)) - ;; Detect the bootloader used in %system-profile. - (bootloader (lookup-bootloader-by-name (system-bootloader-name))) - - ;; Use the detected bootloader with default configuration. - ;; It will be enough to allow the system to boot. - (bootloader-config (bootloader-configuration - (bootloader bootloader))) - - ;; Make the specified system generation the default entry. - (chosen-alternative (generation->boot-alternative - %system-profile number)) - (params (boot-alternative-parameters chosen-alternative)) - (locale (boot-parameters-locale params)) - (store-crypto-devices (boot-parameters-store-crypto-devices params)) - (store-directory-prefix - (boot-parameters-store-directory-prefix params)) - (old-generations - (delv number (reverse (generation-numbers %system-profile)))) - (previous-boot-alternatives (profile->boot-alternatives - %system-profile old-generations)) - (entries (list (boot-parameters->menu-entry params))) - (old-entries (map boot-parameters->menu-entry - (map boot-alternative-parameters - previous-boot-alternatives)))) +(define (install-bootloader-from-os store number os) + "Re-install an old bootloader defined in record OS, +for system profile generation NUMBER, with store STORE." + (let* ((os (read-operating-system os)) + (bootloader-config (operating-system-bootloader os)) + (numbers (generation-numbers %system-profile)) + (numbers (delv number (reverse numbers))) + (old (profile->boot-alternatives %system-profile numbers)) + (bootcfg (operating-system-bootcfg os old))) (run-with-store store - (mlet* %store-monad - ((bootcfg (lower-object - ((bootloader-configuration-file-generator bootloader) - bootloader-config entries - #:locale locale - #:store-crypto-devices store-crypto-devices - #:store-directory-prefix store-directory-prefix - #:old-entries old-entries))) - (drvs -> (list bootcfg))) + (mlet* %store-monad ((bootcfg (lower-object bootcfg)) + (drvs -> (list bootcfg))) (mbegin %store-monad (built-derivations drvs) ;; Only install bootloader configuration file. (install-bootloader local-eval bootloader-config bootcfg #:run-installer? #f)))))) +(define (install-bootloader-from-provenance store number) + "Re-install an old bootloader using provenance data for system profile +generation NUMBER with store STORE." + (receive (_ os) + (system-provenance (generation-file-name %system-profile number)) + (if os + (install-bootloader-from-os store number os) + (leave (G_ "cannot rollback to generation '~a': no provenance~%") + number)))) + ;;; ;;; Graphs. @@ -1391,10 +1372,11 @@ (define (process-command command args opts) (let ((pattern (match args (() #f) ((pattern) pattern) - (x (leave (G_ "wrong number of arguments~%")))))) + (_ (leave (G_ "wrong number of arguments~%"))))) + (number (generation-number %system-profile))) (with-store* store (delete-matching-generations store %system-profile pattern) - (reinstall-bootloader store (generation-number %system-profile))))) + (install-bootloader-from-provenance store number)))) ((switch-generation) (let ((pattern (match args ((pattern) pattern) -- 2.45.2