unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: jgart <jgart@dismail.de>, 54572@debbugs.gnu.org
Subject: [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans.
Date: Sat, 26 Mar 2022 10:14:43 +0100	[thread overview]
Message-ID: <5a9ca7c6593d8259f4b9d57e4f0aab7328b3b86f.camel@gmail.com> (raw)
In-Reply-To: <20220326011538.26236-1-jgart@dismail.de>

Hi jgart

Am Freitag, dem 25.03.2022 um 21:15 -0400 schrieb jgart:
> * gnu/packages/music.scm (solfege): Remove trailing booleans.
> ---
>  gnu/packages/music.scm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6b530aac..d7f0c0d39d 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2058,16 +2058,14 @@ (define-public solfege
>                 (("/usr/bin/aplay") "aplay")
>                 (("/usr/bin/timidity") "timidity")
>                 (("/usr/bin/mpg123") "mpg123")
> -               (("/usr/bin/ogg123") "ogg123"))
> -             #t))
> +               (("/usr/bin/ogg123") "ogg123"))))
>           (add-before 'build 'patch-python-shebangs
>             (lambda _
>               ;; Two python scripts begin with a Unicode BOM, so
> patch-shebang
>               ;; has no effect.
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
> -               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))
> -             #t))
> +               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))))
Questionable uses of which.

It'd also be nice if you could update arguments to be a list of G-
expressions and do all the other modernizations.

Cheers




  reply	other threads:[~2022-03-26  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26  1:15 [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans jgart via Guix-patches via
2022-03-26  9:14 ` Liliana Marie Prikler [this message]
2022-03-29  8:57   ` bug#54572: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a9ca7c6593d8259f4b9d57e4f0aab7328b3b86f.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=54572@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).