From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UE1yE4j072J6RgEAbAwnHQ (envelope-from ) for ; Sun, 07 Aug 2022 19:21:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yNVYE4j072JPSgAAauVa8A (envelope-from ) for ; Sun, 07 Aug 2022 19:21:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 281AFAA27 for ; Sun, 7 Aug 2022 19:21:12 +0200 (CEST) Received: from localhost ([::1]:35824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKjxe-0003gP-V1 for larch@yhetil.org; Sun, 07 Aug 2022 13:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKjxW-0003gB-3T for guix-patches@gnu.org; Sun, 07 Aug 2022 13:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKjxV-0000YT-Qy for guix-patches@gnu.org; Sun, 07 Aug 2022 13:21:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKjxV-0001vn-L6 for guix-patches@gnu.org; Sun, 07 Aug 2022 13:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57034] [PATCH] gnu: packages: Add miniz. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Aug 2022 17:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57034 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" , 57034@debbugs.gnu.org Received: via spool by 57034-submit@debbugs.gnu.org id=B57034.16598928107336 (code B ref 57034); Sun, 07 Aug 2022 17:21:01 +0000 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 17:20:10 +0000 Received: from localhost ([127.0.0.1]:38245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjwf-0001uF-Oh for submit@debbugs.gnu.org; Sun, 07 Aug 2022 13:20:10 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:37474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjwb-0001tb-6b for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 13:20:08 -0400 Received: by mail-ej1-f66.google.com with SMTP id kb8so12786203ejc.4 for <57034@debbugs.gnu.org>; Sun, 07 Aug 2022 10:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=3u4yPNKsQejlHT/72xPhsvIcaZOGTVif+iWVi2rDTc4=; b=qO5uPxSf8hpT5QDTBWyw2WBLB4elxpmliaSYHC7RJ51Z9xNVGePxkBvYHUwWP6M+G0 6Wj+6SFxwAKb/1oBpZvfsAiy6FrhmGqkxe0CZNBy6PhyfbpdzZVCBhTXUWopZqbi7Mkq 26xBind6hEdOO/slcS1qgr53AJ4TLiQA0ZoiskejfCvxIb8TLRIsQnnQjJP6BHNyB4vb 4LjAiHgYYiTcFBYS1b4skPtraa98PGhjsvLWW4mvgsUZOzbPiQ7sIMeVlvlOaI7bEyTX AYjd7RkpXA7YXJbRUtZ9CgD2ELBDnoIqz6mU66ywBfQZBlsigYolffPOgdaFp6wvW8KL 8KLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3u4yPNKsQejlHT/72xPhsvIcaZOGTVif+iWVi2rDTc4=; b=yEVX0UvBaisYwnU2VhtWETwSU3+c0Ty9A+XhVmChoeXBOuQq88OMlI8p7Pglidot/P jO1AeYMM+gQFz898mtF0zMvivC9RhaX6Rwo+anSvpkZx/nUQ/EpoFt9dAYPu5/BUOkOi jiAIPTA9dWJl9F5fXIc5QyZNuF1EehW2MJwZy4eZ6XmzVmuDt1exXCnvaTwBdImkcTur l0eQAZ0pI/PgogvCf3LdKhbJUWEx27BLmlPYIiLFVxDNHJvklTJYZxQkau89tMiXKUf4 G/npBhNU0UlPSKzcawMtjPR03Yb6bniuOfA+XOAK62mrDL/BfmclrQAM8zuhyEoIWNHj D0yw== X-Gm-Message-State: ACgBeo2QzotKYCHHBlAs9emjGQ/eZg1OYICCQS/UnhRumxdxFs1wl4pp 711Jje+LLyczjKdZdwxso6c= X-Google-Smtp-Source: AA6agR49kZroAjBpqez1k7skBKnXLOH4O7mpCOHfPqn20oJk1b3MGZaPQ2oLRpPD6TF7uPO2pVxLHA== X-Received: by 2002:a17:906:5a4f:b0:730:825a:d860 with SMTP id my15-20020a1709065a4f00b00730825ad860mr11064599ejc.143.1659892799290; Sun, 07 Aug 2022 10:19:59 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k15-20020a17090632cf00b007304bdf18cfsm3993762ejk.136.2022.08.07.10.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 10:19:58 -0700 (PDT) Message-ID: <5a29460b4974deaaadd1798b9217dad0fae99151.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 07 Aug 2022 19:19:57 +0200 In-Reply-To: References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659892872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3u4yPNKsQejlHT/72xPhsvIcaZOGTVif+iWVi2rDTc4=; b=Deuc7k6LT3S9/V0mRu5O713ToLc/Xv6cbJ54hN6bFXKoRYcakgXG5nCwDGGLDHF8qHZEfe vO6+K5BSZaMlYoeWpyjNDPvtQqZdB3TeZ4bZGbGy+UhTRtNiGxB3ZMUGhbIN1Q1buSGYdK s1ySy+3Vs+wZ8C5Oa8aAJwuCMTLicTzezMyXv6M7mvIueHDv72Ch98Mqdl06+kd4CyXr9S D1L/XcEnBMGB1BaxkrY19YG6XsddDar9F0s8+8CvDiETkJnNk3YXP5zlawTu8xTDH2q46b hC2OmP7y8Ra91EQT+79naN1MGF4VFVf1guyJ6pMf2Yv+uxNyA0UTQ+5iSEe0Hg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659892872; a=rsa-sha256; cv=none; b=XQcAARlL13YmfhHYdcbF8Md6SNohEUNeHULc9B353pdXv3b3Hww5V51jlsBTU0vSWbZtof TTfUT0ycjtF2C/hL9zi+4sxBR4WrYgkRSh/cg/Er7guNYgFoPEA+BX5juPO5h9Vl0dP0do ekABge06FTyhQ19KGPw8Iv/u/9DSAi8pc2S+I8TxXYxOwjnV0ZLM6fHPwAOjesX2UKjSRH sWoXkhfmHJPq7HIW1bTEbPMPtM/IrVdqQDAIxHZ4KnbdOrl7L/lqcgZg3kbd5ocGbZcn/2 qep/JzfDRZUuObtAOMS4XV+x2t5yMQRwVKasOnFFyW+ofq5waiIR/VS9USW8+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qO5uPxSf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qO5uPxSf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 281AFAA27 X-Spam-Score: 4.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9WRZshmvSBlX Am Sonntag, dem 07.08.2022 um 17:59 +0100 schrieb (: > On Sun Aug 7, 2022 at 5:42 PM BST, Liliana Marie Prikler wrote: > > last time I checked, the template was "gnu: Add PACKAGE", not "gnu: > > packages: Add PACKAGE." > Okay, I'll remember that for next time :) > > > And there might still be many more until a release.  I don't think > > using untagged commits "just because" if the latest release is > > barely a > > year old is a good idea. > > > > +  (let ((commit "be92575500f71dfb5ac7b0c5bb47b6e736c23039") > > > +        (revision "0")) > > > +    (package > > > +     (name "miniz") > > > +     (version (git-version "2.2.0" revision commit)) > > > +     (source (origin > > > +              (method git-fetch) > > > +              (uri (git-reference > > > +                    (url "https://github.com/richgel999/miniz") > > > +                    (commit commit))) > > > +              (file-name (git-file-name name version)) > > > +              (sha256 > > > +               (base32 > > > +                > > > "0w42vagcv4b0hcf0jk7vamrcpmw62dblx9856j98msdfm3qv1xzi")))) > > > +     (build-system cmake-build-system) > > > +     (arguments > > > +      (list #:configure-flags > > > +            #~(list "-DBUILD_SHARED_LIBS=ON") > > > +            ;; No test target. > > > +            #:tests? #f)) > > There is a test script you could use. > It doesn't work; I tried it. > > > > +      "@code{miniz} is a small, simple alternative to the > > > @code{zlib} > > > +data compression library for manipulating zlib, DEFLATE, PNG, > > > and > > > ZIP > > > +files from C.") > > Avoid marketing terms :) > Do 'small' and 'simple' count as marketing terms? 'smaller than zlib' > is objective fact, and 'simpler than zlib' is subjective but pretty > obvious. Maybe I could rewrite it to say 'smaller, simpler > alternative' > instead? "subjective, but pretty obvious", how so? I think the fact that it doesn't have its own documentation and you need to instead refer to zlib kinda defeats that point. Several of its README claims seem either outdated already (the 550 lines one for example), or difficult to guarantee forever. I think the only claim we can reasonably make is that it is an alternative zlib implementation, and that it supports zlib, deflate, png and zip. Cheers