From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>, 70109@debbugs.gnu.org
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
Vivien Kraus <vivien@planete-kraus.eu>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#70109] [PATCH] gnu: dbus-for-jami: Use Gexp.
Date: Sun, 31 Mar 2024 18:04:24 +0200 [thread overview]
Message-ID: <59ead40d45509e063b5ff75b4a4e0d461fd71ada.camel@gmail.com> (raw)
In-Reply-To: <acfc5bcad4eb4ce0d14a42f4afbec88fc6aa0322.1711900722.git.zhengjunjie@iscas.ac.cn>
Am Sonntag, dem 31.03.2024 um 23:58 +0800 schrieb Zheng Junjie:
> This is a follow-up to 26485fc5750d2e067c45d49ab2aa20f481e1979a.
>
> * gnu/packages/glib.scm(dbus-for-jami): Use Gexp.
There should be a space before the parenthesis and I personally prefer
to spell out G-Expression.
>
> Change-Id: I56fd25502be65ba688519dea7462c401aeddba31
> ---
> gnu/packages/glib.scm | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index cf066a8aa6..b11046f05d 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -19,6 +19,7 @@
> ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> ;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com>
> ;;; Copyright © 2023 Saku Laesvuori <saku@laesvuori.fi>
> +;;; Copyright © 2024 Zheng Junjie <873216071@qq.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -202,12 +203,12 @@ (define-public dbus-for-jami
> (arguments
> (substitute-keyword-arguments (package-arguments dbus)
> ((#:phases phases)
> - `(modify-phases ,phases
> - (add-after 'unpack 'customize-config
> - (lambda _
> - (substitute* "bus/session.conf.in"
> - (("@SYSCONFDIR_FROM_PKGDATADIR@/dbus-1/session-
> local.conf")
> - "/var/run/jami/session-local.conf")))))))))))
> + #~(modify-phases #$phases
> + (add-after 'unpack 'customize-config
> + (lambda _
> + (substitute* "bus/session.conf.in"
> + (("@SYSCONFDIR_FROM_PKGDATADIR@/dbus-1/session-
> local.conf")
> + "/var/run/jami/session-local.conf")))))))))))
Thanks for the patch, but is it critical at the moment? As far as I
can see, jami builds without it.
Cheers
next prev parent reply other threads:[~2024-03-31 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 15:58 [bug#70109] [PATCH] gnu: dbus-for-jami: Use Gexp Zheng Junjie
2024-03-31 16:04 ` Liliana Marie Prikler [this message]
2024-03-31 16:45 ` Zheng Junjie
2024-03-31 17:56 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ead40d45509e063b5ff75b4a4e0d461fd71ada.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=70109@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
--cc=zhengjunjie@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).