unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38894] gnu: Add gssdp.
@ 2020-01-03 15:43 Raghav Gururajan
  2020-01-12 22:18 ` Danny Milosavljevic
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Raghav Gururajan @ 2020-01-03 15:43 UTC (permalink / raw)
  To: 38894


[-- Attachment #1.1: Type: text/plain, Size: 82 bytes --]

Hello Guix!

Please find the attached patch for adding gssdp.

Regards,
RG.

[-- Attachment #1.2: gssdp.patch --]
[-- Type: text/x-patch, Size: 1793 bytes --]

From edc99a3deb39e2c9e4395f59dbf69b9f5b1721ba Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Fri, 3 Jan 2020 10:38:26 -0500
Subject: [PATCH] gnu: Add gssdp.

* gnu/packages/gnome.scm (gssdp): New variable.
---
 gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1e713d4fe1..b32fc43eec 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,35 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gssdp
+  (package
+   (name "gssdp")
+   (version "1.2.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "195hi10vrsvh6i927mm6rm1ld5sxah3h5sr3bsjm90vb8lxrxfya"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("gtk-doc" ,gtk-doc)
+      ("gobject-introspection" ,gobject-introspection)
+      ("gtk+" ,gtk+)
+      ("libsoup" ,libsoup)
+      ("vala" ,vala)))
+   (synopsis "GObject-based API over SSDP for GNOME desktop")
+   (description "A GObject-based API for handling resource discovery
+and announcement over SSDP.")
+   (home-page "https://gitlab.gnome.org/GNOME/gssdp")
+   (license license:gpl2)))
+
 (define-public libmediaart
   (package
     (name "libmediaart")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
@ 2020-01-12 22:18 ` Danny Milosavljevic
  2020-01-12 22:20 ` Danny Milosavljevic
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-01-12 22:18 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 61 bytes --]

Please use 

  guix lint gssdp

to validate this patch.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
  2020-01-12 22:18 ` Danny Milosavljevic
@ 2020-01-12 22:20 ` Danny Milosavljevic
  2020-01-12 22:27 ` Raghav Gururajan
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-01-12 22:20 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]

gobject-introspection should be a native-input, and vala too.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
  2020-01-12 22:18 ` Danny Milosavljevic
  2020-01-12 22:20 ` Danny Milosavljevic
@ 2020-01-12 22:27 ` Raghav Gururajan
  2020-01-12 22:31 ` Danny Milosavljevic
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Raghav Gururajan @ 2020-01-12 22:27 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Hello Danny!

> gobject-introspection should be a native-input, and vala too.

Please find the revised patch attached.

Regards,
RG.

[-- Attachment #2: gssdp.patch --]
[-- Type: application/octet-stream, Size: 1803 bytes --]

From 629957ce445af3e6659694bc46a2d4b6011542aa Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 12 Jan 2020 17:25:45 -0500
Subject: [PATCH] gnu: Add gssdp.

* gnu/packages/gnome.scm (gssdp): New variable.
---
 gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9f0942a543..4f1c329887 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,35 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gssdp
+  (package
+   (name "gssdp")
+   (version "1.2.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "195hi10vrsvh6i927mm6rm1ld5sxah3h5sr3bsjm90vb8lxrxfya"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("pkg-config" ,pkg-config)
+      ("vala" ,vala)))
+   (inputs
+    `(("gtk-doc" ,gtk-doc)
+      ("gtk+" ,gtk+)
+      ("libsoup" ,libsoup)))
+   (synopsis "GObject-based API over SSDP for GNOME desktop")
+   (description "A GObject-based API for handling resource discovery
+and announcement over SSDP.")
+   (home-page "https://gitlab.gnome.org/GNOME/gssdp")
+   (license license:gpl2)))
+
 (define-public gnome-user-share
   (package
    (name "gnome-user-share")
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
                   ` (2 preceding siblings ...)
  2020-01-12 22:27 ` Raghav Gururajan
@ 2020-01-12 22:31 ` Danny Milosavljevic
  2020-01-12 22:34 ` Raghav Gururajan
  2020-01-13  7:38 ` bug#38894: " Danny Milosavljevic
  5 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-01-12 22:31 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

The license is gpl 2 or later, right?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
                   ` (3 preceding siblings ...)
  2020-01-12 22:31 ` Danny Milosavljevic
@ 2020-01-12 22:34 ` Raghav Gururajan
  2020-01-12 22:40   ` Danny Milosavljevic
  2020-01-12 22:53   ` Raghav Gururajan
  2020-01-13  7:38 ` bug#38894: " Danny Milosavljevic
  5 siblings, 2 replies; 9+ messages in thread
From: Raghav Gururajan @ 2020-01-12 22:34 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 38894

Hello Danny!

> The license is gpl 2 or later, right?

It says GPL v2 (https://gitlab.gnome.org/GNOME/gssdp/blob/master/COPYING).

Regards,
RG.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-12 22:34 ` Raghav Gururajan
@ 2020-01-12 22:40   ` Danny Milosavljevic
  2020-01-12 22:53   ` Raghav Gururajan
  1 sibling, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-01-12 22:40 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

That file contains LGPL 2 (not GPL2).

Moreover, the important part is whether the source files contain a comment
header which specifies "or later" or not.

Please provide a license review of the source files that are the source of
files that are installed (only).



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#38894] gnu: Add gssdp.
  2020-01-12 22:34 ` Raghav Gururajan
  2020-01-12 22:40   ` Danny Milosavljevic
@ 2020-01-12 22:53   ` Raghav Gururajan
  1 sibling, 0 replies; 9+ messages in thread
From: Raghav Gururajan @ 2020-01-12 22:53 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 38894

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hello Danny!

> That file contains LGPL 2 (not GPL2).
> 
> Moreover, the important part is whether the source files contain a comment
> header which specifies "or later" or not.
> 
> Please provide a license review of the source files that are the source of
> files that are installed (only).

Sorry, I misunderstood the Library<-->Lesser.

Please find the revised patch attached.

Regards,
RG.

[-- Attachment #2: gssdp.patch --]
[-- Type: application/octet-stream, Size: 1805 bytes --]

From 011f5a38521530532fe35afb305f48a817963868 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 12 Jan 2020 17:50:51 -0500
Subject: [PATCH] gnu: Add gssdp.

* gnu/packages/gnome.scm (gssdp): New variable.
---
 gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9f0942a543..8e1e6e5193 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,35 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gssdp
+  (package
+   (name "gssdp")
+   (version "1.2.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "195hi10vrsvh6i927mm6rm1ld5sxah3h5sr3bsjm90vb8lxrxfya"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("pkg-config" ,pkg-config)
+      ("vala" ,vala)))
+   (inputs
+    `(("gtk-doc" ,gtk-doc)
+      ("gtk+" ,gtk+)
+      ("libsoup" ,libsoup)))
+   (synopsis "GObject-based API over SSDP for GNOME desktop")
+   (description "A GObject-based API for handling resource discovery
+and announcement over SSDP.")
+   (home-page "https://gitlab.gnome.org/GNOME/gssdp")
+   (license license:lgpl2+)))
+
 (define-public gnome-user-share
   (package
    (name "gnome-user-share")
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#38894: gnu: Add gssdp.
  2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
                   ` (4 preceding siblings ...)
  2020-01-12 22:34 ` Raghav Gururajan
@ 2020-01-13  7:38 ` Danny Milosavljevic
  5 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-01-13  7:38 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 38894-done

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

Pushed to guix master as commit e2aed29c798711a765dc3cd7e76f423b2447d22c
after moving gtk-doc to native-inputs.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-01-13  7:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-03 15:43 [bug#38894] gnu: Add gssdp Raghav Gururajan
2020-01-12 22:18 ` Danny Milosavljevic
2020-01-12 22:20 ` Danny Milosavljevic
2020-01-12 22:27 ` Raghav Gururajan
2020-01-12 22:31 ` Danny Milosavljevic
2020-01-12 22:34 ` Raghav Gururajan
2020-01-12 22:40   ` Danny Milosavljevic
2020-01-12 22:53   ` Raghav Gururajan
2020-01-13  7:38 ` bug#38894: " Danny Milosavljevic

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).