From: Brice Waegeneire <brice@waegenei.re>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40274@debbugs.gnu.org,
Guix-patches
<guix-patches-bounces+brice+lists=waegenei.re@gnu.org>
Subject: [bug#40274] [PATCH v4] gnu: Add kernel-module-loader-service.
Date: Wed, 01 Apr 2020 14:38:57 +0000 [thread overview]
Message-ID: <58b435078b6055874686c2da7d411eaa@waegenei.re> (raw)
In-Reply-To: <87k12zcozy.fsf@gmail.com>
Hello Mathieu,
On 2020-04-01 13:30, Mathieu Othacehe wrote:
> You can add a separator here, C-q C-l with Emacs :)
I never used pagination in Emacs, maybe I should start using it.
>> +(define kernel-module-loader-shepherd-service
>> + (match-lambda
>> + (($ <kernel-module-loader-configuration> modprobe modules)
>> + (list
>> + (shepherd-service
>> + (documentation "Load kernel modules.")
>> + (provision '(kernel-module-loader))
>> + (respawn? #f)
>> + (one-shot? #t)
>> + (start
>> + #~(lambda _
>> + (and-map (lambda (module-with-parameters)
>> + (zero? (apply system* #$modprobe "--"
>> + module-with-parameters)))
>> + '#$modules))))))))
>
> I wonder if it would make sense to rmmod the modules on service
> stop? Probably not.
This is a one-shot service so no.
>> (value (run-loadable-kernel-modules-test
>> (list acpi-call-linux-module ddcci-driver-linux)
>> - '("acpi_call" "ddcci")))))
>> + '(("acpi_call")
>> + ("ddcci"))))))
>
> When using multiple modules without any configuration, I find the
> notation '(("module-a") ("module-b")) a bit unclear. Maybe we could add
> a special case handling '("module-a" "module-b") as two kernel modules
> taking no arguments.
>
> Or we could define a record with two fields: module-name and arguments.
> Not sure what's better.
I asked about it on IRC before starting v2 but nobody responded so I
went on
with this “list of lists of string” implementation. I'll be happy to use
a
better format, the special case look nice but maybe confusing for the
user.
I have fixed the typo you reported but I'll wait for further suggestion
about
the format before sending the new version.
- Brice
next prev parent reply other threads:[~2020-04-01 14:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 13:59 [bug#40274] [PATCH] gnu: Add kernel-module-loader-service Brice Waegeneire
2020-03-28 20:51 ` Mathieu Othacehe
2020-03-31 17:22 ` Brice Waegeneire
2020-03-31 17:19 ` [bug#40274] [PATCH v2] " Brice Waegeneire
2020-03-31 20:00 ` [bug#40274] [PATCH v3] " Brice Waegeneire
2020-03-31 20:10 ` [bug#40274] [PATCH] " Nicolò Balzarotti
2020-03-31 20:25 ` Brice Waegeneire
2020-03-31 20:23 ` [bug#40274] [PATCH v4] " Brice Waegeneire
2020-04-01 13:30 ` Mathieu Othacehe
2020-04-01 14:38 ` Brice Waegeneire [this message]
2020-04-01 19:34 ` pelzflorian (Florian Pelz)
2020-04-01 19:43 ` pelzflorian (Florian Pelz)
2020-04-01 19:48 ` pelzflorian (Florian Pelz)
2020-04-02 12:40 ` Brice Waegeneire
2020-04-03 13:03 ` pelzflorian (Florian Pelz)
2020-04-02 12:37 ` [bug#40274] [PATCH v5] " Brice Waegeneire
2020-04-02 13:56 ` Danny Milosavljevic
2020-04-02 17:13 ` Brice Waegeneire
2020-04-03 10:20 ` Danny Milosavljevic
2020-04-03 12:58 ` pelzflorian (Florian Pelz)
2020-04-04 10:51 ` Danny Milosavljevic
2020-04-04 17:58 ` Brice Waegeneire
2020-04-04 18:31 ` Danny Milosavljevic
2020-04-05 7:19 ` Brice Waegeneire
2020-04-02 14:22 ` Mathieu Othacehe
2020-04-04 15:17 ` [bug#40274] [PATCH v6 0/2] " Brice Waegeneire
2020-04-04 15:17 ` [bug#40274] [PATCH v6 1/2] services: Allow modprobe to use "/etc/modprobe.d" Brice Waegeneire
2020-04-04 15:17 ` [bug#40274] [PATCH v6 2/2] gnu: Add kernel-module-loader-service Brice Waegeneire
2020-04-04 15:53 ` Mathieu Othacehe
2020-04-04 16:09 ` pelzflorian (Florian Pelz)
2020-04-04 16:49 ` Brice Waegeneire
2020-04-04 17:46 ` pelzflorian (Florian Pelz)
2020-04-04 21:10 ` Danny Milosavljevic
2020-04-04 21:11 ` Danny Milosavljevic
2020-04-04 23:06 ` pelzflorian (Florian Pelz)
2020-04-05 7:06 ` Brice Waegeneire
2020-04-04 21:16 ` Danny Milosavljevic
2020-04-05 5:28 ` [bug#40274] [PATCH v7 0/2] " Brice Waegeneire
2020-04-05 5:28 ` [bug#40274] [PATCH v7 1/2] services: Allow modprobe to use "/etc/modprobe.d" Brice Waegeneire
2020-04-05 11:11 ` Danny Milosavljevic
2020-04-05 12:38 ` Brice Waegeneire
2020-04-05 5:28 ` [bug#40274] [PATCH v7 2/2] gnu: Add kernel-module-loader-service Brice Waegeneire
2020-04-05 10:06 ` pelzflorian (Florian Pelz)
2020-04-05 11:10 ` bug#40274: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b435078b6055874686c2da7d411eaa@waegenei.re \
--to=brice@waegenei.re \
--cc=40274@debbugs.gnu.org \
--cc=guix-patches-bounces+brice+lists=waegenei.re@gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).