From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxwAM-0002k2-Od for guix-patches@gnu.org; Tue, 11 Apr 2017 09:49:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxwAI-0000NP-Qu for guix-patches@gnu.org; Tue, 11 Apr 2017 09:49:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43865) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxwAI-0000MH-NF for guix-patches@gnu.org; Tue, 11 Apr 2017 09:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cxwAI-0008FJ-DA for guix-patches@gnu.org; Tue, 11 Apr 2017 09:49:02 -0400 Subject: bug#26352: [PATCH 1/3] gnu: Update networkmanager to version 1.6.2. Resent-Message-ID: References: <1491245640-28547-1-git-send-email-h.goebel@crazy-compilers.com> <1491245802-28648-1-git-send-email-h.goebel@crazy-compilers.com> <871st0efz7.fsf@gnu.org> From: Hartmut Goebel Message-ID: <58ECDEAD.1040306@crazy-compilers.com> Date: Tue, 11 Apr 2017 15:48:29 +0200 MIME-Version: 1.0 In-Reply-To: <871st0efz7.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26352@debbugs.gnu.org Hi Ludo, your review came just in time, I was about to push it :-) > Note that =E2=80=98pre-configure=E2=80=99, =E2=80=98fix-docbook=E2=80=99= , and =E2=80=98install=E2=80=99 are not fields > of , so we normally don=E2=80=99t represent them this way in c= ommit logs. Fine for me. How do you want it? > > A couple of new tests are being skipped, this is for the same reason as= > the others, right? Yes. Each of these tests is accompanied by a "fake" one which passes. > > Normally adding both libxml2 and libxslt as inputs would save you from > writing this phase. Could you check that this is the case? Indeed, adding libxml2 sets XML_CATALOG_FILES. But then it becomes curiou= s: - With both docbook-xsl and docbook-xml as inputs, the build fails. (This did not happen with my patch, since I missed adding docbook-xml to XML_CATALOG_FILES.) GEN man/nmcli.1 I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.x= sl warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.= xsl" cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.x= sl - With only docbook-xsl, the build passes while showing some errors, which are only treated as warnings: GEN man/nmcli.1 I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd man/nmcli.xml:7: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd" ]> ^ man/nmcli.xml:2060: parser error : Entity 'ndash' not defined Success – indicates the operation succeeded. ^ man/nmcli.xml:2422: parser error : Entity 'mdash' not defined https://bugzilla.gnome.org/ — product NetworkManager