[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz at ElenQ Technology]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi,

I made a patch for chicken-scheme according to this conversation in the help-guix mailing list:

https://lists.gnu.org/archive/html/help-guix/2020-01/msg00230.html

I pushed the version to 5.1.0 and added gcc-toolchain as a propagated-input as the conversation suggested. The reason is without the gcc-toolchain csc (the chicken compiler) is unable to deal with -lm (math library), which is not installed with the current chicken package.

The linked conversation suggests that gcc-toolchain is a fundamental part of chicken so it should be a dependency of it.

Sorry if I didn't follow the format, but I was unable to find a good contributing guide.

Best,

Ekaitz



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: chicken.diff --]
[-- Type: text/x-patch; name="chicken.diff", Size: 1777 bytes --]

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 1009896a70..f1d04bfa53 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 ;;; Copyright © 2018 Gabriel Hondet <gabrielhondet@gmail.com>
+;;; Copyright © 2018 Ekaitz Zarraga <ekaitz@elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -69,6 +70,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages libedit)
+  #:use-module (gnu packages commencement)
   #:use-module (srfi srfi-1)
   #:use-module (ice-9 match))
 
@@ -371,14 +373,14 @@ mashups, office (web agendas, mail clients, ...), etc.")
 (define-public chicken
   (package
     (name "chicken")
-    (version "5.0.0")
+    (version "5.1.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://code.call-cc.org/releases/"
                                   version "/chicken-" version ".tar.gz"))
               (sha256
                (base32
-                "15b5yrzfa8aimzba79x7v6y282f898rxqxfxrr446sjx9jwlpfd8"))))
+                "0jsbp3kp0134f318j3wpd1n85gf8qzh034fn198gvazsv2l024aw"))))
     (build-system gnu-build-system)
     (arguments
      `(#:modules ((guix build gnu-build-system)
@@ -401,6 +403,7 @@ mashups, office (web agendas, mail clients, ...), etc.")
 
        ;; Parallel builds are not supported, as noted in README.
        #:parallel-build? #f))
+    (propagated-inputs `(("gcc-toolchain", gcc-toolchain)))
     (home-page "http://www.call-cc.org/")
     (synopsis "R5RS Scheme implementation that compiles native code via C")
     (description

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Jonathan Brielmaier]

On 31.01.20 17:22, Ekaitz at ElenQ Technology wrote:
> Sorry if I didn't follow the format, but I was unable to find a good contributing guide.

There is a section (and related ones) in the manual:
http://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting-Patches

On the our blog, there is a nice tutorial (quite lengthy) how to start
packaging:
http://guix.gnu.org/blog/2018/a-packaging-tutorial-for-guix/

But nevertheless good work! I'll leave to someone more experienced to
decide if propagating gcc-toolchain is the right way here...

~Jonathan

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Julien Lepiller]

Hi,

I tried to apply and build your patch, but unfortunately it didn't
work. From a clean checkout, I cannot run make anymore after applying
the patch, and if I run make before applying your patch, then
./pre-inst-env guix build chicken also fails with:

error: gnu-make: unbound variable
hint: Did you forget a `use-modules' form?

error: googletest: unbound variable
hint: Did you forget a `use-modules' form?

error: bzip2: unbound variable
hint: Did you forget a `use-modules' form?

error: binutils: unbound variable
hint: Did you forget a `use-modules' form?

error: gcc-4.9: unbound variable
hint: Did you forget a `use-modules' form?

error: openmpi: unbound variable
hint: Did you forget a `use-modules' form?

error: perl-module-build: unbound variable
hint: Did you forget a `use-modules' form?

error: python2-numpy: unbound variable
hint: Did you forget a `use-modules' form?

guix build: warning: failed to load '(gnu packages chromium)':
Unbound variable: opus
error: unzip: unbound variable
hint: Did you forget a `use-modules' form?

error: curl: unbound variable
hint: Did you forget a `use-modules' form?

error: binutils: unbound variable
hint: Did you forget a `use-modules' form?

error: libuv: unbound variable
hint: Did you forget a `use-modules' form?

error: libdvdnav: unbound variable
hint: Did you forget a `use-modules' form?

error: perl: unbound variable
hint: Did you forget a `use-modules' form?

error: static-bash: unbound variable
hint: Did you forget a `use-modules' form?

error: java-plexus-container-default: unbound variable
hint: Did you forget a `use-modules' form?

error: openmpi: unbound variable
hint: Did you forget a `use-modules' form?

error: givaro: unbound variable
hint: Did you forget a `use-modules' form?

error: curl: unbound variable
hint: Did you forget a `use-modules' form?

error: xorg-server: unbound variable
hint: Did you forget a `use-modules' form?

guix build: error: chicken: unknown package



I suppose this is caused by a module loop or something between (gnu
packages scheme) and (gnu packages commencement). Maybe splitting (gnu
packages scheme) into two things (maybe a new (gnu packages chicken))
would solve the issue?

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz Zarraga]

> I suppose this is caused by a module loop or something between (gnu
> packages scheme) and (gnu packages commencement). Maybe splitting (gnu
> packages scheme) into two things (maybe a new (gnu packages chicken))
> would solve the issue?

I think it does. I made a new patch with that but I'm not sure if I did
everything right:



From a898269624da04cceb539e0b7ca929cfea23be4d Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sun, 9 Feb 2020 15:08:41 +0100
Subject: [PATCH] Move chicken to a separate package

---
 gnu/local.mk             |  1 +
 gnu/packages/chicken.scm | 50 ++++++++++++++++++++++++++++++++++++++++
 gnu/packages/scheme.scm  | 41 --------------------------------
 3 files changed, 51 insertions(+), 41 deletions(-)
 create mode 100644 gnu/packages/chicken.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 64ad653542..d86b39cacb 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -109,6 +109,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/check.scm			\
   %D%/packages/chemistry.scm			\
   %D%/packages/chez.scm				\
+  %D%/packages/chicken.scm				\
   %D%/packages/chromium.scm			\
   %D%/packages/ci.scm				\
   %D%/packages/cinnamon.scm			\
diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
new file mode 100644
index 0000000000..070373e049
--- /dev/null
+++ b/gnu/packages/chicken.scm
@@ -0,0 +1,50 @@
+(define-module (gnu packages chicken)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses)
+                #:select (bsd-3))
+  #:use-module (gnu packages commencement))
+
+(define-public chicken
+  (package
+    (name "chicken")
+    (version "5.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://code.call-cc.org/releases/"
+                                  version "/chicken-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0jsbp3kp0134f318j3wpd1n85gf8qzh034fn198gvazsv2l024aw"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:modules ((guix build gnu-build-system)
+                  (guix build utils)
+                  (srfi srfi-1))
+
+       ;; No `configure' script; run "make check" after "make install" as
+       ;; prescribed by README.
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (delete 'check)
+         (add-after 'install 'check
+           (assoc-ref %standard-phases 'check)))
+
+       #:make-flags (let ((out (assoc-ref %outputs "out")))
+                      (list "PLATFORM=linux"
+                            (string-append "PREFIX=" out)
+                            (string-append "VARDIR=" out "/var/lib")))
+
+       ;; Parallel builds are not supported, as noted in README.
+       #:parallel-build? #f))
+    (propagated-inputs `(("gcc-toolchain", gcc-toolchain)))
+    (home-page "http://www.call-cc.org/")
+    (synopsis "R5RS Scheme implementation that compiles native code via C")
+    (description
+     "CHICKEN is a compiler for the Scheme programming language.  CHICKEN
+produces portable and efficient C, supports almost all of the R5RS Scheme
+language standard, and includes many enhancements and extensions.")
+    (license bsd-3)))
diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 1009896a70..c891a77a18 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -368,47 +368,6 @@ applications in many fields such as multimedia (web galleries, music players,
 mashups, office (web agendas, mail clients, ...), etc.")
     (license gpl2+)))

-(define-public chicken
-  (package
-    (name "chicken")
-    (version "5.0.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://code.call-cc.org/releases/"
-                                  version "/chicken-" version ".tar.gz"))
-              (sha256
-               (base32
-                "15b5yrzfa8aimzba79x7v6y282f898rxqxfxrr446sjx9jwlpfd8"))))
-    (build-system gnu-build-system)
-    (arguments
-     `(#:modules ((guix build gnu-build-system)
-                  (guix build utils)
-                  (srfi srfi-1))
-
-       ;; No `configure' script; run "make check" after "make install" as
-       ;; prescribed by README.
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure)
-         (delete 'check)
-         (add-after 'install 'check
-           (assoc-ref %standard-phases 'check)))
-
-       #:make-flags (let ((out (assoc-ref %outputs "out")))
-                      (list "PLATFORM=linux"
-                            (string-append "PREFIX=" out)
-                            (string-append "VARDIR=" out "/var/lib")))
-
-       ;; Parallel builds are not supported, as noted in README.
-       #:parallel-build? #f))
-    (home-page "http://www.call-cc.org/")
-    (synopsis "R5RS Scheme implementation that compiles native code via C")
-    (description
-     "CHICKEN is a compiler for the Scheme programming language.  CHICKEN
-produces portable and efficient C, supports almost all of the R5RS Scheme
-language standard, and includes many enhancements and extensions.")
-    (license bsd-3)))
-
 (define-public scheme48
   (package
     (name "scheme48")
--
2.17.1

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Julien Lepiller]

Le Sun, 09 Feb 2020 14:11:09 +0000,
Ekaitz Zarraga <ekaitz@elenq.tech> a écrit :

> > I suppose this is caused by a module loop or something between (gnu
> > packages scheme) and (gnu packages commencement). Maybe splitting
> > (gnu packages scheme) into two things (maybe a new (gnu packages
> > chicken)) would solve the issue?  
> 
> I think it does. I made a new patch with that but I'm not sure if I
> did everything right:

This is almost correct. You should make it two patches: the first moves
chicken to its own module, the second updates it. Make sure to add the
licence in the new file with a copyright line for yourself. The commit
message should be:

gnu: chicken: Move to a separate module.

* gnu/packages/scheme.scm (chicken): Move to chicken.scm.
* gnu/packages/chicken.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

for the first patch and:

gnu: chicken: Update to 5.1.0.

* gnu/packages/chicken.scm (chicken): Update to 5.1.0.
[propagated-inputs]: Add gcc-toolchain.

for the second patch. This makes it clearer what happens. You can find
a lot of examples from 'git log'.

Since no other package depends on chicken, we're all good I think.

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz Zarraga]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, February 9, 2020 3:30 PM, Julien Lepiller <julien@lepiller.eu> wrote:

> This is almost correct. You should make it two patches: the first moves
> chicken to its own module, the second updates it. Make sure to add the
> licence in the new file with a copyright line for yourself. The commit
> message should be:
>
> gnu: chicken: Move to a separate module.
>
> -   gnu/packages/scheme.scm (chicken): Move to chicken.scm.
> -   gnu/packages/chicken.scm: New file.
> -   gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>
>     for the first patch and:
>
>     gnu: chicken: Update to 5.1.0.
>
> -   gnu/packages/chicken.scm (chicken): Update to 5.1.0.
>     [propagated-inputs]: Add gcc-toolchain.
>
>     for the second patch. This makes it clearer what happens. You can find
>     a lot of examples from 'git log'.
>
>     Since no other package depends on chicken, we're all good I think.
>

Oh thanks.
I'll add them to the thread right now.

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz Zarraga]

From 34d4965c61f4a1f5153aaf6d959c06745790d0d0 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sun, 9 Feb 2020 16:10:28 +0100
Subject: [PATCH 1/2] gnu: chicken: Move to a separate module.

* gnu/packages/scheme.scm (chicken): Move to chicken.scm.
* gnu/packages/chicken.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk             |  1 +
 gnu/packages/chicken.scm | 66 ++++++++++++++++++++++++++++++++++++++++
 gnu/packages/scheme.scm  | 41 -------------------------
 3 files changed, 67 insertions(+), 41 deletions(-)
 create mode 100644 gnu/packages/chicken.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 64ad653542..d86b39cacb 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -109,6 +109,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/check.scm			\
   %D%/packages/chemistry.scm			\
   %D%/packages/chez.scm				\
+  %D%/packages/chicken.scm				\
   %D%/packages/chromium.scm			\
   %D%/packages/ci.scm				\
   %D%/packages/cinnamon.scm			\
diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
new file mode 100644
index 0000000000..53631f9bd6
--- /dev/null
+++ b/gnu/packages/chicken.scm
@@ -0,0 +1,66 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages chicken)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses)
+                #:select (bsd-3)))
+
+(define-public chicken
+  (package
+    (name "chicken")
+    (version "5.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://code.call-cc.org/releases/"
+                                  version "/chicken-" version ".tar.gz"))
+              (sha256
+               (base32
+                "15b5yrzfa8aimzba79x7v6y282f898rxqxfxrr446sjx9jwlpfd8"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:modules ((guix build gnu-build-system)
+                  (guix build utils)
+                  (srfi srfi-1))
+
+       ;; No `configure' script; run "make check" after "make install" as
+       ;; prescribed by README.
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (delete 'check)
+         (add-after 'install 'check
+           (assoc-ref %standard-phases 'check)))
+
+       #:make-flags (let ((out (assoc-ref %outputs "out")))
+                      (list "PLATFORM=linux"
+                            (string-append "PREFIX=" out)
+                            (string-append "VARDIR=" out "/var/lib")))
+
+       ;; Parallel builds are not supported, as noted in README.
+       #:parallel-build? #f))
+    (home-page "http://www.call-cc.org/")
+    (synopsis "R5RS Scheme implementation that compiles native code via C")
+    (description
+     "CHICKEN is a compiler for the Scheme programming language.  CHICKEN
+produces portable and efficient C, supports almost all of the R5RS Scheme
+language standard, and includes many enhancements and extensions.")
+    (license bsd-3)))
diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 1009896a70..c891a77a18 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -368,47 +368,6 @@ applications in many fields such as multimedia (web galleries, music players,
 mashups, office (web agendas, mail clients, ...), etc.")
     (license gpl2+)))

-(define-public chicken
-  (package
-    (name "chicken")
-    (version "5.0.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://code.call-cc.org/releases/"
-                                  version "/chicken-" version ".tar.gz"))
-              (sha256
-               (base32
-                "15b5yrzfa8aimzba79x7v6y282f898rxqxfxrr446sjx9jwlpfd8"))))
-    (build-system gnu-build-system)
-    (arguments
-     `(#:modules ((guix build gnu-build-system)
-                  (guix build utils)
-                  (srfi srfi-1))
-
-       ;; No `configure' script; run "make check" after "make install" as
-       ;; prescribed by README.
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure)
-         (delete 'check)
-         (add-after 'install 'check
-           (assoc-ref %standard-phases 'check)))
-
-       #:make-flags (let ((out (assoc-ref %outputs "out")))
-                      (list "PLATFORM=linux"
-                            (string-append "PREFIX=" out)
-                            (string-append "VARDIR=" out "/var/lib")))
-
-       ;; Parallel builds are not supported, as noted in README.
-       #:parallel-build? #f))
-    (home-page "http://www.call-cc.org/")
-    (synopsis "R5RS Scheme implementation that compiles native code via C")
-    (description
-     "CHICKEN is a compiler for the Scheme programming language.  CHICKEN
-produces portable and efficient C, supports almost all of the R5RS Scheme
-language standard, and includes many enhancements and extensions.")
-    (license bsd-3)))
-
 (define-public scheme48
   (package
     (name "scheme48")
--
2.17.1

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz Zarraga]

From e0ca67f81e28d6910ce507d7f14c26a63b7c4619 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sun, 9 Feb 2020 16:51:44 +0100
Subject: [PATCH 2/2] gnu: chicken: Update to 5.1.0.

* gnu/packages/chicken.scm (chicken): Update to 5.1.0.
[propagated-inputs]: Add gcc-toolchain.
---
 gnu/packages/chicken.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
index 53631f9bd6..9b12ff7ef6 100644
--- a/gnu/packages/chicken.scm
+++ b/gnu/packages/chicken.scm
@@ -21,20 +21,21 @@
   #:use-module (guix packages)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
+  #:use-module (gnu packages commencement)
   #:use-module ((guix licenses)
                 #:select (bsd-3)))

 (define-public chicken
   (package
     (name "chicken")
-    (version "5.0.0")
+    (version "5.1.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://code.call-cc.org/releases/"
                                   version "/chicken-" version ".tar.gz"))
               (sha256
                (base32
-                "15b5yrzfa8aimzba79x7v6y282f898rxqxfxrr446sjx9jwlpfd8"))))
+                 "0jsbp3kp0134f318j3wpd1n85gf8qzh034fn198gvazsv2l024aw"))))
     (build-system gnu-build-system)
     (arguments
      `(#:modules ((guix build gnu-build-system)
@@ -57,6 +58,7 @@

        ;; Parallel builds are not supported, as noted in README.
        #:parallel-build? #f))
+    (propagated-inputs `(("gcc-toolchain", gcc-toolchain)))
     (home-page "http://www.call-cc.org/")
     (synopsis "R5RS Scheme implementation that compiles native code via C")
     (description
--
2.17.1

bug#39372: Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Julien Lepiller]

Le Sun, 09 Feb 2020 14:11:09 +0000,
Ekaitz Zarraga <ekaitz@elenq.tech> a écrit :

> > I suppose this is caused by a module loop or something between (gnu
> > packages scheme) and (gnu packages commencement). Maybe splitting
> > (gnu packages scheme) into two things (maybe a new (gnu packages
> > chicken)) would solve the issue?  
> 
> I think it does. I made a new patch with that but I'm not sure if I
> did everything right:
> 

Pushed as 2846aec2f7d53b9244ad55c1436437843287426a and
7f6cb6bbac181a11859283922037e374a82035db. Thank you!

[bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain

[Ekaitz Zarraga]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, February 9, 2020 9:01 PM, Julien Lepiller <julien@lepiller.eu> wrote:
> Pushed as 2846aec2f7d53b9244ad55c1436437843287426a and
> 7f6cb6bbac181a11859283922037e374a82035db. Thank you!


Thank you for your time