unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Martin Castillo <castilma@uni-bremen.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30817@debbugs.gnu.org
Subject: [bug#30817] [PATCH] openssh-service: export AcceptEnv option
Date: Thu, 15 Mar 2018 23:54:15 +0100	[thread overview]
Message-ID: <58584ce3-4561-5ffc-6434-b25dc0f7b62c@uni-bremen.de> (raw)
In-Reply-To: <878tattg72.fsf@gnu.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 124 bytes --]

Hello,

> Could you send an updated patch?
 Here you go

-- 
GPG: 7FDE 7190 2F73 2C50 236E  403D CC13 48F1 E644 08EC

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-services-openssh-Add-accepted-environment-field.patch --]
[-- Type: text/x-patch; name="0001-services-openssh-Add-accepted-environment-field.patch", Size: 2715 bytes --]

From 2cc779c3e0f02f7f58bed4bebfac92f94353cb3b Mon Sep 17 00:00:00 2001
From: Martin Castillo <castilma@uni-bremen.de>
Date: Thu, 15 Mar 2018 23:40:58 +0100
Subject: [PATCH] services: openssh: Add 'accepted-environment' field.

* gnu/services/ssh.scm (<openssh-configuration>)[accepted-environment]: New field.
(openssh-config-file): Honor 'acccepted-environment'.
* doc/guix.texi (Networking Services): Document it.
---
 doc/guix.texi        | 16 ++++++++++++++++
 gnu/services/ssh.scm |  7 +++++++
 2 files changed, 23 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index d3a7908f9..6e449b90c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -11158,6 +11158,22 @@ server.  Alternately, one can specify the @command{sftp-server} command:
            `(("sftp" ,(file-append openssh "/libexec/sftp-server"))))))
 @end example
 
+@item @code{accepted-environment} (default: @code{'()})
+List of strings describing which environment variables may be exported.
+
+Each string gets on its own line.  See the @code{AcceptEnv} option in
+@code{man sshd_config(5)}.
+
+This example allows ssh-clients to export the @code{COLORTERM} variable.  
+It is set by terminal emulators, which support colors.  You can use it in 
+your shell's ressource file to enable colors for the prompt and commands 
+if this variable is set.
+@example
+(service openssh-service-type
+         (openssh-configuration
+		  (accepted-environment '("COLORTERM"))))
+@end example
+
 @item @code{authorized-keys} (default: @code{'()})
 @cindex authorized keys, SSH
 @cindex SSH authorized keys
diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
index 301ba7404..f1d2be3f6 100644
--- a/gnu/services/ssh.scm
+++ b/gnu/services/ssh.scm
@@ -302,6 +302,10 @@ The other options should be self-descriptive."
   (subsystems            openssh-configuration-subsystems
                          (default '(("sftp" "internal-sftp"))))
 
+  ;; list of strings
+  (accepted-environment  openssh-configuration-accepted-environment
+                         (default '()))
+
   ;; list of user-name/file-like tuples
   (authorized-keys       openssh-authorized-keys
                          (default '()))
@@ -430,6 +434,9 @@ of user-name/file-like tuples."
            (format port "AuthorizedKeysFile \
  .ssh/authorized_keys .ssh/authorized_keys2 /etc/ssh/authorized_keys.d/%u\n")
 
+           (for-each (lambda (s) (format port "AcceptEnv ~a\n" s))
+                     '#$(openssh-configuration-accepted-environment config))
+
            (for-each
             (match-lambda
               ((name command) (format port "Subsystem\t~a\t~a\n" name command)))
-- 
2.16.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-03-15 22:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 14:55 [bug#30817] [PATCH] openssh-service: export AcceptEnv option Martin Castillo
2018-03-15 17:13 ` Ludovic Courtès
2018-03-15 22:54   ` Martin Castillo [this message]
2018-03-17 21:16     ` bug#30817: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58584ce3-4561-5ffc-6434-b25dc0f7b62c@uni-bremen.de \
    --to=castilma@uni-bremen.de \
    --cc=30817@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).