unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Dariqq <dariqq@posteo.net>, 72851@debbugs.gnu.org
Cc: me@tobias.gr
Subject: [bug#72851] [PATCH v2 4/6] gnu: pidgin: Use system ssl certs.
Date: Fri, 30 Aug 2024 22:09:56 +0200	[thread overview]
Message-ID: <581ec07463319c65928d6bf27a9131a228769d03.camel@gmail.com> (raw)
In-Reply-To: <22922127775e781edc3d75ec4461171cde609a1c.1724920170.git.dariqq@posteo.net>

Am Donnerstag, dem 29.08.2024 um 08:35 +0000 schrieb Dariqq:
> If not present pidgin bundles its own certs otherwise.
This should probably be a code comment or none at all.

> * gnu/packages/messaging.scm (pdigin) [inputs]: Add nss-certs.
Note: pdgin, not pidgin.
> [#:configure-flags]: Add  --with-system-ssl-certs
> 
> Change-Id: I14ec36002b31b4de52871f065bd18c9d30eca275
> ---
>  gnu/packages/messaging.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 6b3dff2152..4992db1bee 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -74,6 +74,7 @@ (define-module (gnu packages messaging)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages check)
> +  #:use-module (gnu packages certs)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages cpp)
> @@ -1002,6 +1003,7 @@ (define-public pidgin
>             network-manager
>             nspr
>             nss
> +           nss-certs
>             pango
>             perl
>             python-2
> @@ -1024,6 +1026,9 @@ (define-public pidgin
>          "--disable-gevolution"
>          "--enable-cap"
>          "--enable-cyrus-sasl"
> +        (string-append "--with-system-ssl-certs="
> +                       (assoc-ref %build-inputs "nss-certs")
> +                       "/etc/ssl/certs")
If pidgin bundles certificates, we should also drop them with a
snippet.  A runtime option would still be preferable – search for
SSL_CERT_DIR.


Cheers

  reply	other threads:[~2024-08-30 20:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  7:41 [bug#72851] [PATCH] gnu: pidgin: Update to 2.14.13 [security fixes] Dariqq
2024-08-28 18:35 ` Liliana Marie Prikler
2024-08-28 20:01   ` Dariqq
2024-08-28 20:22     ` Liliana Marie Prikler
2024-08-28 21:30       ` Dariqq
2024-08-29  8:35 ` [bug#72851] [PATCH v2 0/6] Pidgin updates Dariqq
2024-08-29  8:35   ` [bug#72851] [PATCH v2 1/6] gnu: pidgin: Update to 2.14.13 [security fixes] Dariqq
2024-08-29  8:35   ` [bug#72851] [PATCH v2 2/6] gnu: pidgin: Remove input labels Dariqq
2024-08-29  8:35   ` [bug#72851] [PATCH v2 3/6] gnu: pdigin: Propagate libgnt Dariqq
2024-08-29  8:35   ` [bug#72851] [PATCH v2 4/6] gnu: pidgin: Use system ssl certs Dariqq
2024-08-30 20:09     ` Liliana Marie Prikler [this message]
2024-08-31  9:07       ` Dariqq
2024-08-31 16:31         ` bug#72851: " Liliana Marie Prikler
2024-08-29  8:35   ` [bug#72851] [PATCH v2 5/6] gnu: libgnt: Build without python2 Dariqq
2024-08-29  8:35   ` [bug#72851] [PATCH v2 6/6] gnu: pidgin: Use python3 Dariqq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=581ec07463319c65928d6bf27a9131a228769d03.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=72851@debbugs.gnu.org \
    --cc=dariqq@posteo.net \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).