From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIFvc-0000KY-TY for guix-patches@gnu.org; Fri, 24 Nov 2017 10:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIFvX-0001Py-9z for guix-patches@gnu.org; Fri, 24 Nov 2017 10:30:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:47435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIFvX-0001Pp-7O for guix-patches@gnu.org; Fri, 24 Nov 2017 10:30:03 -0500 Subject: [bug#29359] [PATCH 08/31] gnu: Add java-jansi. In-Reply-To: <20171119185541.06581b0d@lepiller.eu> Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIFul-0008N7-NJ for guix-patches@gnu.org; Fri, 24 Nov 2017 10:29:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIFuk-0000wX-Ho for guix-patches@gnu.org; Fri, 24 Nov 2017 10:29:15 -0500 Received: from tobias.gr ([2001:470:cc92::1]:46504) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eIFuk-0000v2-5J for guix-patches@gnu.org; Fri, 24 Nov 2017 10:29:14 -0500 References: From: Tobias Geerinckx-Rice Message-ID: <581c24f4-635d-c954-fadf-7ca0d59f2046@tobias.gr> Date: Fri, 24 Nov 2017 16:31:20 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: julien@lepiller.eu, 29359@debbugs.gnu.org Julien, On Wed, Nov 22, 2017 at 10:33:56AM +0100, julien lepiller wrote: > There's a small issue with this package: when it runs its tests, it > will output formatted text with colors but forgets to clean the > console afterwards, which leaves the console with a bold red font.> Any idea on how to clean that? You could add a reset-terminal phase after the test phase that sends an ANSI reset sequence. Either by invoking the ‘reset’ command, which would add a dependency on ncurses and is probably overkill, or by sending (from memory, so check) \e[0m which resets only colour and weight and is probably all you need here. > Shouldn't the environment block this kind of thing? The problem is that the state modified by these escape sequences is in the terminal itself. We could filter build output through a sanitiser that strips or mangles those sequences so we only print ‘plain text’ to the terminal (while keeping them in logs — I'm sure some source-based package managers do just that). I don't know if that would break some tests, though. Kind regards, T G-R