From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDR8M-00030U-6V
	for guix-patches@gnu.org; Wed, 24 May 2017 03:55:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDR8I-0008H3-5b
	for guix-patches@gnu.org; Wed, 24 May 2017 03:55:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:32773)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dDR8H-0008Gt-S7
	for guix-patches@gnu.org; Wed, 24 May 2017 03:55:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dDR8H-0007l1-Lm
	for guix-patches@gnu.org; Wed, 24 May 2017 03:55:01 -0400
Subject: bug#27043: [PATCH] gnu: Add python-asn1crypto.
Resent-Message-ID: <handler.27043.B27043.149561249129800@debbugs.gnu.org>
Message-Id: <563924e5.AEEAK7CSRGkAAAAAAAAAAAPEZ0kAAAACwQwAAAAAAAW9WABZJTxG@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Wed, 24 May 2017 13:24:41 +0530
In-reply-to: <112e5a50205629b8d4c5de726c45f6c2f1666699.1495568547.git.leo@famulari.name>
References: <112e5a50205629b8d4c5de726c45f6c2f1666699.1495568547.git.leo@famulari.name>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27043@debbugs.gnu.org


Thanks for the patch! :-)

Leo Famulari writes:

> * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New va=
riables.

I think we should put this package in gnu/packages/python.scm. Packages
like python-cryptography are in python.scm.

> +(define-public python-asn1crypto
> +  (package
> +    (name "python-asn1crypto")
> +    (version "0.22.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "asn1crypto" version))

Release tarballs are availabe on the project's github page. Why not use
those?

> +    (arguments
> +     '(#:tests? #f)) ; Tests are not distributed via PyPi.

The github release tarballs have tests. Could you package them?

> +    (home-page "https://github.com/wbond/asn1crypto")
> +    (synopsis "ASN.1 parser and serializer in Python")
> +    (description "Fast ASN.1 parser and serializer with definitions for =
private
> +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> +PKCS#12, PKCS#5, X.509 and TSP.")

The description should be in full sentences.
=