From: Maxime Devos <maximedevos@telenet.be>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: 55845@debbugs.gnu.org
Subject: [bug#55845] [PATCH 1/1] ui: Improve pager selection logic when less is not installed.
Date: Wed, 08 Jun 2022 17:08:13 +0200 [thread overview]
Message-ID: <55fe6cdbed891707aca419ff4eedd7c37ef3eb03.camel@telenet.be> (raw)
In-Reply-To: <87leu72sbo.fsf@taiju.info>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
[Please keep debbugs in CC]
Taiju HIGASHI schreef op wo 08-06-2022 om 22:33 [+0900]:
> > Ideally there would be some regression tests as well.
>
> I think I can write tests if I can figure out how to give a minimal
> specific package to the test preconditions, do you have any test
> codes
> that are similar and can be used as a reference?
Not really, but FWIW it might be convenient to use the
with-environment-variables macro and mock the call to open-pipe* with
the 'mock' macro to make sure that open-pipe* is called with the
‘correct’ pager according to PATH (*). Searching for 'mock' with "git
grep -F" should find some examples.
(*) call-with-temporary-directory + chmod + call-with-output-file may
be useful for setting up a simulated $PATH with a dummy 'less' and/or
'more'.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-08 15:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 10:21 [bug#55845] [PATCH 0/1] Improve pager selection logic when less is not installed Taiju HIGASHI
2022-06-08 10:22 ` [bug#55845] [PATCH 1/1] ui: " Taiju HIGASHI
2022-06-08 13:18 ` Maxime Devos
[not found] ` <87leu72sbo.fsf@taiju.info>
2022-06-08 15:08 ` Maxime Devos [this message]
2022-06-08 15:17 ` Taiju HIGASHI
2022-06-08 16:46 ` Maxime Devos
2022-06-09 9:52 ` Taiju HIGASHI
2022-06-09 10:23 ` Taiju HIGASHI
2022-06-09 19:43 ` Maxime Devos
2022-06-10 0:39 ` Taiju HIGASHI
2022-06-10 7:47 ` Maxime Devos
2022-06-10 8:40 ` Taiju HIGASHI
2022-06-10 15:08 ` Maxime Devos
2022-06-11 11:26 ` Taiju HIGASHI
2022-06-14 23:58 ` Taiju HIGASHI
2022-06-15 8:02 ` Maxime Devos
2022-06-16 21:43 ` [bug#55845] [PATCH 0/1] " Ludovic Courtès
2022-06-17 0:38 ` Taiju HIGASHI
2022-06-17 12:39 ` Ludovic Courtès
2022-06-17 13:36 ` Taiju HIGASHI
2022-06-17 15:12 ` Ludovic Courtès
2022-06-18 14:11 ` Taiju HIGASHI
2022-06-10 0:55 ` [bug#55845] [PATCH 1/1] ui: " Taiju HIGASHI
2022-06-10 7:37 ` Maxime Devos
2022-06-10 8:52 ` Taiju HIGASHI
2022-06-08 12:14 ` [bug#55845] [PATCH 0/1] " Tobias Geerinckx-Rice via Guix-patches via
2022-06-08 13:12 ` Taiju HIGASHI
2022-06-08 14:22 ` Tobias Geerinckx-Rice via Guix-patches via
2022-06-08 15:09 ` Taiju HIGASHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fe6cdbed891707aca419ff4eedd7c37ef3eb03.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55845@debbugs.gnu.org \
--cc=higashi@taiju.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).