From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wE8lFoKxR2FCggAAgWs5BA (envelope-from ) for ; Sun, 19 Sep 2021 23:54:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wLTEEYKxR2HjdwAAB5/wlQ (envelope-from ) for ; Sun, 19 Sep 2021 21:54:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFFA11E298 for ; Sun, 19 Sep 2021 23:54:09 +0200 (CEST) Received: from localhost ([::1]:58802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS4lE-0005xj-Gt for larch@yhetil.org; Sun, 19 Sep 2021 17:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS4l7-0005xZ-VB for guix-patches@gnu.org; Sun, 19 Sep 2021 17:54:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS4l7-0005FM-Nh for guix-patches@gnu.org; Sun, 19 Sep 2021 17:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mS4l7-0002iC-KV for guix-patches@gnu.org; Sun, 19 Sep 2021 17:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49713] [PATCH 3/3] gnu: Add prusa-slicer. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 21:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49713 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ivan Gankevich Cc: 49713@debbugs.gnu.org Received: via spool by 49713-submit@debbugs.gnu.org id=B49713.163208840510379 (code B ref 49713); Sun, 19 Sep 2021 21:54:01 +0000 Received: (at 49713) by debbugs.gnu.org; 19 Sep 2021 21:53:25 +0000 Received: from localhost ([127.0.0.1]:40168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS4kX-0002hL-G7 for submit@debbugs.gnu.org; Sun, 19 Sep 2021 17:53:25 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS4kV-0002h7-80 for 49713@debbugs.gnu.org; Sun, 19 Sep 2021 17:53:24 -0400 Received: by mail-wm1-f44.google.com with SMTP id j134-20020a1c238c000000b0030b32367649so7765041wmj.3 for <49713@debbugs.gnu.org>; Sun, 19 Sep 2021 14:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=egU/5xa24Pl3Q3F8WdhczaSakYM0gh+jnzKsspTfCPI=; b=F/NSwwL5yDYmNp9e0+yAO2t1SjUz4Ajj7a98Ca7dVusiExL2qc/6V+nTV73zy8Fq+S DWY0YRuVjNyC2XfofhsH8eJrE3H3B3P83LsV3o5qpL7wMh2ln1oBvo3tmJsXeIZLMYcZ BsPVZiBFkYnYOgpcj5DsWfNZnWVt4HxK4PFgIjI7jfFiMIdrvmaWVoQYVrRXGwuXZsSx 75NYjDABbniRUPttVc8Rua+8rpOXHdugutnpktkVjY7rghOIkQ2CiYNaq/foY4wk+27z D6thbPjRDlP6fZW1jnbC2dnNqkRvag/FLDfXgVwn4Yg+iSgpgczpZuOwNdlN2eFoy3qD 553w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=egU/5xa24Pl3Q3F8WdhczaSakYM0gh+jnzKsspTfCPI=; b=iibEhD2DlcPH0Lzf3rIbkC0FsaRG8q4EGqj0X9Ob+O0o6pSnL1xN+MDwWSx/Nl70Uy MjOewGMLSe3AfPB02IaN8v7RfihVP3wqO6ZAY5ZxLOzQ5LMzjSyXkgBZ7xOfSLOQfiW9 cXeyRW5Ag980uS6Tyhe0qsSwKBJ3frnPewi158n/0MZdEdLnD/PnG5ySVJqlTNQnn2YO pF2x5WEgxmNDuK2hl/AM6cVNkPQqCUXWvbdjPW4sfm5FCfD9KmIWVsp5HKucWsMDVfSz sc3+TgltjBOOapFwWm4GQpZa7VME291+OpewoZz6g5uALvwxkiYKd9Mi70+c+mE+yiKN ak5w== X-Gm-Message-State: AOAM530V97KVx2U8P+r9HyaZZx67xsO/A+N0r7/SJaFZ/8TdgfOnVl+b mrkhky0ah+oCYB3KiOUSubcyfcXqOeQ= X-Google-Smtp-Source: ABdhPJynJp9bPDfeLOohFazLP7XKB+pt39en7pEHcc0TDofvEJFUMSB23Gtj5fN3dFgrnc4k1obQnQ== X-Received: by 2002:a1c:f00a:: with SMTP id a10mr20940372wmb.112.1632088397259; Sun, 19 Sep 2021 14:53:17 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u13sm14009423wrt.41.2021.09.19.14.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 14:53:16 -0700 (PDT) Message-ID: <55e4a71f3756689728238b05fd063662f79ca3d7.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 19 Sep 2021 23:53:15 +0200 In-Reply-To: References: <20210723210801.9458-1-i.gankevich@spbu.ru> <1e440c6a0f9e9e328eb83519e1df38f506a3d4b3.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632088450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=egU/5xa24Pl3Q3F8WdhczaSakYM0gh+jnzKsspTfCPI=; b=JiSyc8QN4Ce1W6ntI4QCCmHpYFa42PlvuGpNLLiQ7z5sJejt+A+n1CXf6TOvPADCh9q4u0 Ob1Iyy6obWEU+OjXzE0XWyVH2YHXPkQ7GlAFKFfr5RzNQQoXBR46CARBJcswXkspnpll7z OF0jSwgoTC/Lo9d4+vigXjEoCFjByYqxZbZTAy6cxLC2IB9M2XQMiy6Ao8LekJsh8v9fgl bjxqRRI35ZrO3DzppMBcSBVFMjoTEo9FjKMntpolbwXNMdv9gAcrnH1eRIFtdca2J9wgou DrlPlDfn+BQWXjfqqAiIXzRqAWqqL+YmVsHhz3Efe/1LrzDXceZL1TTBCaKqqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632088450; a=rsa-sha256; cv=none; b=hzwpDKJHN9pStJpsQQfNBa1dJQizjLn5rLh2PWXV/jXSGrbv4FAMqWgfFtESbqPwtmOVIm NF+f26ptiHPz5gdPVfqW/UVgcQxv30zy28nyrQ6gIehE8O9VQrGHcTgLI9q4SRxriJq+FH JuZlNM+DJx3zQrtVfI03YfnPYYMbEb2/f5e+WCOyuF/MdVQuUxJHFsqRU9eefspYHixWI/ GR/PZyVTR31s+6G0nAmmt8oZXlaaUv7T9oAoLfo2uDI3hlAPH0sWOOyr920bv45jWU+T2T OWYJYOH60AUdfFrD0mUPcg1xzFGNuPgXc78CgKMN0/Q47F7HtNRUPfI2eNlhlg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="F/NSwwL5"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="F/NSwwL5"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DFFA11E298 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5yo88SwqlGvs Am Montag, den 20.09.2021, 00:39 +0300 schrieb Ivan Gankevich: > > Unbundling should be done in the snippet rather than at build time. > > Moved deletion of directories to the snippet. I'd argue that fixing the CMakeLists also falls into snippet territory, as it's directly related to unbundling. Am Sonntag, den 19.09.2021, 23:18 +0300 schrieb Ivan Gankevich: > This library is header-only. All the dependencies from this list are > used in the tests. Headers that use these dependencies are installed > no matter which dependenies are “ON” in this list. I’ve added XML. > Adding other dependencies would require rewriting most of > “cmake/libigl.cmake” file, because the authors of the package like to > download and build all the dependencies manually. Could this be done with substitute* as for the other packages? If not, we should group those options under a sufficiently explanatory comment. Also, there's little need to explicitly enable things that would already be enabled by default, let's keep the list of flags small and understandable :) When you send v3, please do all patches in one go and also specify -- reroll-count, as that's easier on mumi. Thanks