unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: 69006@debbugs.gnu.org
Cc: "Paul A. Patience" <paul@apatience.com>
Subject: [bug#69006] [PATCH 2/2] gnu: reproc: Improve package style.
Date: Fri, 09 Feb 2024 20:02:12 +0000	[thread overview]
Message-ID: <54ce21a63b314e2bf13023b2df6f7e82e225f1bc.1707506182.git.paul@apatience.com> (raw)
In-Reply-To: <0ff996d504ed3a3ff0eb1fdb1fb061e4a018baad.1707506182.git.paul@apatience.com>

* gnu/packages/cpp.scm (reproc)[arguments]: Use G-expressions.
<#:configure-flags>: Remove unnecessary comment and enable CMake
variable with ON rather than 1.

Change-Id: Ic5e6747e7978a40d1aab66b4c3634342736c0bcf
---
 gnu/packages/cpp.scm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 785b001629..4523ce2b04 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -1055,11 +1055,9 @@ (define-public reproc
           (base32 "09xnf8hmld1fk8j33zwlz1qcxnjdx1ncbg62csic9va4m1wc2v1d"))))
    (build-system cmake-build-system)
    (arguments
-      ;; No tests.
-    `(#:tests? #f
-      ;; Build the shared library instead of a static one.
-      #:configure-flags `("-DBUILD_SHARED_LIBS=1"
-                          "-DREPROC++=ON")))
+    (list #:tests? #f     ; No tests.
+          #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON"
+                                    "-DREPROC++=ON")))
    (native-inputs
     (list pkg-config))
    (synopsis "Process IO library")
-- 
2.41.0






  reply	other threads:[~2024-02-09 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 19:17 [bug#69006] [PATCH 1/2] gnu: reproc: Enable reproc++ Paul A. Patience
2024-02-09 20:02 ` Paul A. Patience [this message]
2024-03-01  6:22 ` bug#69006: " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ce21a63b314e2bf13023b2df6f7e82e225f1bc.1707506182.git.paul@apatience.com \
    --to=paul@apatience.com \
    --cc=69006@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).