[bug#40061] Allow double-click select of URL in status

[bug#40061] Allow double-click select of URL in status

[Tom Zander via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

While I've been playing with guix today I found this rather trivial patch
to be nice. Nice enough to maybe start, even though I'm still waiting for some 
compiles I'll submit this trivial patch untested.

Lets see how the social (as opposed to technical) part works.

Is this patch Ok?
-- 
Tom Zander

[-- Attachment #2: 0001-Allow-double-click-select-of-URL-in-status.patch --]
[-- Type: text/x-patch, Size: 978 bytes --]

From ab690e91f177e0e3efa557fc9ac72ebbc89cb0ad Mon Sep 17 00:00:00 2001
From: TomZ <tomz@freedommail.ch>
Date: Sat, 14 Mar 2020 14:36:28 +0100
Subject: [PATCH] Allow double-click select of URL in status

The status during an install prints download-targets.
This adds a space between the URL and the '...' string trailing it
so on a terminal you can just double click on the URL to select it.
---
 guix/status.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/status.scm b/guix/status.scm
index cbea4151f2..a39d91e0dc 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -517,7 +517,7 @@ addition to build events."
        (newline port)))
     (('download-started item uri _ ...)
      (erase-current-line*)
-     (format port (info (G_ "downloading from ~a...")) uri)
+     (format port (info (G_ "downloading from ~a ...")) uri)
      (newline port))
     (('download-progress item uri
                          (= string->number size)
-- 
2.25.1

[bug#40061] Version two of the patch.

[Tom Zander via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

Attached is an updated version of the patch, it fixes more of the same issues.

[-- Attachment #2: 0001-Allow-double-click-select-of-URL-in-status.patch --]
[-- Type: text/x-patch, Size: 1999 bytes --]

From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001
From: TomZ <tomz@freedommail.ch>
Date: Sat, 14 Mar 2020 14:36:28 +0100
Subject: [PATCH] Allow double-click select of URL in status

Various places while downloading or compiling guix
prints the source URL. This change makes the URL be easier
to be used by placing a space between the URL and the trailing
dots.
---
 guix/status.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/guix/status.scm b/guix/status.scm
index cbea4151f2..866ba3bc39 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -472,8 +472,8 @@ addition to build events."
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a..."
-                                    "applying ~a grafts for ~a..."
+             (format port (info (N_ "applying ~a graft for ~a ..."
+                                    "applying ~a grafts for ~a ..."
                                     count))
                      count drv)))
          ('profile-hook
@@ -484,7 +484,7 @@ addition to build events."
                 (format port (info (G_ "running profile hook of type '~a'..."))
                         hook-type))))
          (_
-          (format port (info (G_ "building ~a...")) drv))))
+          (format port (info (G_ "building ~a ...")) drv))))
      (newline port))
     (('build-succeeded drv . _)
      (erase-current-line*)                      ;erase spinner or progress bar
@@ -517,7 +517,7 @@ addition to build events."
        (newline port)))
     (('download-started item uri _ ...)
      (erase-current-line*)
-     (format port (info (G_ "downloading from ~a...")) uri)
+     (format port (info (G_ "downloading from ~a ...")) uri)
      (newline port))
     (('download-progress item uri
                          (= string->number size)
-- 
2.25.1

[bug#40061] Version two of the patch.

[Leo Famulari]

On Sat, Mar 14, 2020 at 06:16:52PM +0100, Tom Zander via Guix-patches via wrote:
> Attached is an updated version of the patch, it fixes more of the same issues.

> From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001
> From: TomZ <tomz@freedommail.ch>
> Date: Sat, 14 Mar 2020 14:36:28 +0100
> Subject: [PATCH] Allow double-click select of URL in status
> 
> Various places while downloading or compiling guix
> prints the source URL. This change makes the URL be easier
> to be used by placing a space between the URL and the trailing
> dots.

Thanks, this is great. I get annoyed by this constantly.

Any other feedback?

[bug#40061] [tomz@freedommail.ch: Re: [bug#40061] Version two of the patch.]

[Leo Famulari]

----- Forwarded message from Tom Zander <tomz@freedommail.ch> -----

Date: Sat, 14 Mar 2020 19:32:40 +0100
From: Tom Zander <tomz@freedommail.ch>
To: Leo Famulari <leo@famulari.name>
Subject: Re: [bug#40061] Version two of the patch.

On zaterdag 14 maart 2020 18:48:16 CET Leo Famulari wrote:
> On Sat, Mar 14, 2020 at 06:16:52PM +0100, Tom Zander via Guix-patches via wrote:
> > Attached is an updated version of the patch, it fixes more of the same
> > issues.
> > 
> > From 0b2a17de72825b9ca0d494ea8c4d9bf121689f4e Mon Sep 17 00:00:00 2001
> > From: TomZ <tomz@freedommail.ch>
> > Date: Sat, 14 Mar 2020 14:36:28 +0100
> > Subject: [PATCH] Allow double-click select of URL in status
> > 
> > Various places while downloading or compiling guix
> > prints the source URL. This change makes the URL be easier
> > to be used by placing a space between the URL and the trailing
> > dots.
> 
> Thanks, this is great. I get annoyed by this constantly.
> 
> Any other feedback?


I wrote down some more silly things that I'm not sure I'll get to.

Imagine the following;

guix package -i guile-git
The following package will be upgraded:
guile-git    0.3.0 → 0.3.0   /gnu/store/h5y9c889q237a0sjzn68zflkmk3zz33f-guile-git-0.3.0

Instead of saying "upgraded" it should say "reinstalled".

then: the 'info guix' chapter 2.6.1 Locales
has this gem:
«Note that the ‘glibc-locales’ package contains data for all the
  locales supported by the GNU libc and weighs in at around 110 MiB.»

If you install it you'll note its well over 200MB, though. That at minimum should 
be updated in the info. Or more likely just stated that its large.


Thanks!
-- 
Tom Zander



----- End forwarded message -----

[bug#40061] Allow double-click select of URL in status

[Vincent Legoll]

LGTM, except maybe the following change to the
commit msg:

This change makes the URL be easier to be used
=>
This change makes the URL easier to use

But that may not warrant a new patch submission,
though, as the committer may do it himself...

Thanks

-- 
Vincent Legoll

bug#40061: Allow double-click select of URL in status

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Vincent Legoll <vincent.legoll@gmail.com> writes:

> LGTM, except maybe the following change to the
> commit msg:
>
> This change makes the URL be easier to be used
> =>
> This change makes the URL easier to use
>
> But that may not warrant a new patch submission,
> though, as the committer may do it himself...

Whoops, I committed this without seeing this comment, oh well!

Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40061] Allow double-click select of URL in status

[Vincent Legoll]

Hello,

On Tue, Apr 7, 2020 at 10:00 PM Marius Bakke <mbakke@fastmail.com> wrote:
> Vincent Legoll <vincent.legoll@gmail.com> writes:
> > LGTM, except maybe the following change to the
> > commit msg:
> >
> > This change makes the URL be easier to be used
> > =>
> > This change makes the URL easier to use
> >
> > But that may not warrant a new patch submission,
> > though, as the committer may do it himself...
>
> Whoops, I committed this without seeing this comment, oh well!

Not really a problem ;-)

It was just in case...

-- 
Vincent Legoll

[bug#40061] Allow double-click select of URL in status

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

I reverted this temporarily to avoid having to request updated
translations for Guix 1.1.0.

It will have to wait until after the 1.1.0 release.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#40061: Allow double-click select of URL in status

[Tom Zander via Guix-patches via]

On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote:
> Vincent Legoll <vincent.legoll@gmail.com> writes:
> > LGTM, except maybe the following change to the
> > commit msg:
> > 
> > This change makes the URL be easier to be used
> > =>
> > This change makes the URL easier to use
> > 
> > But that may not warrant a new patch submission,
> > though, as the committer may do it himself...
> 
> Whoops, I committed this without seeing this comment, oh well!
> 
> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.

No worries, I actually used Vincent's suggested words in the rebase, which is 
the patch you applied. 

-- 
Tom Zander

[bug#40061] Allow double-click select of URL in status

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

Tom Zander <tomz@freedommail.ch> writes:

> On dinsdag 7 april 2020 22:00:33 CEST Marius Bakke wrote:
>> Vincent Legoll <vincent.legoll@gmail.com> writes:
>> > LGTM, except maybe the following change to the
>> > commit msg:
>> > 
>> > This change makes the URL be easier to be used
>> > =>
>> > This change makes the URL easier to use
>> > 
>> > But that may not warrant a new patch submission,
>> > though, as the committer may do it himself...
>> 
>> Whoops, I committed this without seeing this comment, oh well!
>> 
>> Pushed in 9f1b787120b1b81abffaf0fa13fdbdf4cca39f2d.
>
> No worries, I actually used Vincent's suggested words in the rebase, which is 
> the patch you applied. 

Oh heh, patch overload I guess!

Note that the patch was temporarily reverted (I forgot to CC you in the
previous message to this issue):
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e

Feel free to ping this bug once 1.1.0 is out to get it re-applied.  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40061] Allow double-click select of URL in status

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Note that the patch was temporarily reverted (I forgot to CC you in the
> previous message to this issue):
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1c86577d624b97a03138640b4d849823b504570e
>
> Feel free to ping this bug once 1.1.0 is out to get it re-applied.  :-)

Finally applied in 8fa4ac5be4d5f8a1e62635842b16486832ff49f1 after a
friendly ping on #guix:matrix.org :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40061] [Patch] rebase and fix wording

[Tom Zander via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 14 bytes --]

-- 
Tom Zander

[-- Attachment #2: 0001-Allow-double-click-select-of-URL-in-status.patch --]
[-- Type: text/x-patch, Size: 2112 bytes --]

From a9a7f4c8bf513aeac95f7d1bc87c6edddefec0d0 Mon Sep 17 00:00:00 2001
From: TomZ <tomz@freedommail.ch>
Date: Tue, 7 Apr 2020 21:39:04 +0200
Subject: [PATCH] Allow double-click select of URL in status

Various places while downloading or compiling guix prints
the source URL. This change makes the URL easier to use by
placing a space between the URL and the trailing dots.
---
 guix/status.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/status.scm b/guix/status.scm
index 4b2edc2f3c..45e441eac5 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -472,16 +472,16 @@ addition to build events."
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a..."
-                                    "applying ~a grafts for ~a..."
+             (format port (info (N_ "applying ~a graft for ~a ..."
+                                    "applying ~a grafts for ~a ..."
                                     count))
                      count drv)))
          ('profile
           (let ((count (match (assq-ref properties 'profile)
                          (#f  0)
                          (lst (or (assq-ref lst 'count) 0)))))
-            (format port (info (N_ "building profile with ~a package..."
-                                   "building profile with ~a packages..."
+            (format port (info (N_ "building profile with ~a package ..."
+                                   "building profile with ~a packages ..."
                                    count))
                     count)))
          ('profile-hook
@@ -525,7 +525,7 @@ addition to build events."
        (newline port)))
     (('download-started item uri _ ...)
      (erase-current-line*)
-     (format port (info (G_ "downloading from ~a...")) uri)
+     (format port (info (G_ "downloading from ~a ...")) uri)
      (newline port))
     (('download-progress item uri
                          (= string->number size)
-- 
2.25.1