From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uEFcBDFQpGLh6QAAbAwnHQ (envelope-from ) for ; Sat, 11 Jun 2022 10:20:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AGVvAzFQpGKdJwEAG6o9tA (envelope-from ) for ; Sat, 11 Jun 2022 10:20:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 917A2101AD for ; Sat, 11 Jun 2022 10:20:00 +0200 (CEST) Received: from localhost ([::1]:50722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzwLd-0000QB-Qt for larch@yhetil.org; Sat, 11 Jun 2022 04:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwKl-0008M3-5L for guix-patches@gnu.org; Sat, 11 Jun 2022 04:19:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzwKk-0004Od-TS for guix-patches@gnu.org; Sat, 11 Jun 2022 04:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzwKk-0003rb-H8 for guix-patches@gnu.org; Sat, 11 Jun 2022 04:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55893] [PATCH] gnu: python-xyz: Add python-pysdl2. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Jun 2022 08:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55893 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jean Pierre De Jesus DIAZ , 55893@debbugs.gnu.org Received: via spool by 55893-submit@debbugs.gnu.org id=B55893.165493553114831 (code B ref 55893); Sat, 11 Jun 2022 08:19:02 +0000 Received: (at 55893) by debbugs.gnu.org; 11 Jun 2022 08:18:51 +0000 Received: from localhost ([127.0.0.1]:51809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwKY-0003r9-Rk for submit@debbugs.gnu.org; Sat, 11 Jun 2022 04:18:51 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:55170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwKU-0003qy-0Q for 55893@debbugs.gnu.org; Sat, 11 Jun 2022 04:18:49 -0400 Received: from [172.20.10.9] ([188.189.218.39]) by albert.telenet-ops.be with bizsmtp id hkJj2700R0rbbE406kJjiD; Sat, 11 Jun 2022 10:18:44 +0200 Message-ID: <53cab9bbd3f482ad08fef4159bcefbf8e9ac0af5.camel@telenet.be> From: Maxime Devos In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-z2W6puwtbg9VqtNYzJ1L" Date: Sat, 11 Jun 2022 00:13:59 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.38.3-1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654935524; bh=AuuXn2qIez/Arz1GRAwHv4EhvYDBb7AKoeNCrim16BY=; h=Subject:From:To:In-Reply-To:References:Date; b=J8hpa9/uGgU7N3/CJ8mrSvcLALXAN47DRgsnZg5uRi4kWr6SmiW5mq0zfUZ7RoQdU nCM4rLXHC+Og2x4jalMC6u7H+UddbOLQmCLt7j9YEWxMT65oC7D7DS0VRQ9UKRFtk0 ZUhXDeq4se7uyni195UnNJ5joAEeCXcPAl7RdJwb5O3S7SAnyZc4Cp4xUZDHz2joBY pZZhVpDF0A1L3KFiKDEY9LN8l/gyZQ5MtiZf4tKWDbdZxTh5nwX+Cn2s4D7n1FYjyz eZiIVQ65i6UXpc6y3WFJfZQZ3hmo4kA0j3e6Q9poFp+V1Tp6HyWk+y1Gg/1AN2wGqJ 0HuxxaeoImFUA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654935600; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AuuXn2qIez/Arz1GRAwHv4EhvYDBb7AKoeNCrim16BY=; b=b8b0ti+pMfeVFX3LUH2KcuKqfhS3DUsY5UNREaogfyybP1TeTAwF60l2EV9PiSxSZc95ZK Qh6/XiHA01CO4ewoDUbaWkj2oB56RWV8XxB19dGtbeHw4Q4hI8RWSifJnqrOLed/PdylOb 42AshjWNYIEIPTVRQdM0EDTa7j1TxJmQ9UClRHS8U1/H0f+X/SCVKhl0qaQAyjvUzsH3h5 8iouTi+Ew5OqZQI4U5Zh6n4x/FIQuVnmMYNqXA5DJlxT3v6QeWHJYcKmY5JjHoUky15WE1 MV6XWCjbY5v+LrUKCV4VcdcEAYRjniBbARxiVNrQ3vPR2UkqYjJx7rwlC0v9xA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654935600; a=rsa-sha256; cv=none; b=iiIpQXVMeYzkK9DLthMjI9n/PXVoGP7ybrK1e2pqnI8RyNREXjUHgXcIRcevr05GecamJY tqzQjOAI3yyVU3sUdQ/ewq4gVEwPBLNuZEYGTeeOiAoMXTv6uuBI8mgV74UPaJiCz35Zyd jDfbbxPGhBvgzahPYtL6s3ldR6dLTLg+M7P9nhyvctdS/8hzH18J0Karpzdltj7O8x9YzZ p9ypGL1k7QbCS/bA+mZp8J/Fv7y0c18pYdd6wIqGhG3V/dEq3mXTpV4UE0B9sqa9RaJ0fz zMFov3Xv24TlcEL2p3nCYnfEaTO4wDA78jPMK+QqWErk0UNpLFNo/7Rr7wKJsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="J8hpa9/u"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="J8hpa9/u"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 917A2101AD X-Spam-Score: 3.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7CIWvC3nLQp1 --=-z2W6puwtbg9VqtNYzJ1L Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jean Pierre De Jesus DIAZ via Guix-patches via schreef op vr 10-06-2022 om 18:09 [+0000]: > +=C2=A0=C2=A0=C2=A0 (native-inputs > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list sdl2 sdl2-image sdl2-gfx sdl2-mixer= sdl2-ttf)) These need to be in 'inputs', not native-inputs -- their shared libraries will actually be executed when python-pysdl2 executed, which can only work if they are compiled for the same architecture as python- pysdl2 is compiled for (that's what 'inputs' means; for 'native- inputs', it would be compiled for the architecture on which python- pysdl2 is compiled, not the architecture it is compiled for).=20 > + (synopsis "Python ctypes wrapper around SDL2") ctypes sounds like an implementation detail not relevant to users of python-pysdl2, maybe: =E2=80=98Python bindings around SDL2=E2=80=99? > + ; Disable pysdl2-dll. Not needed. Nitpick: the convention is two ;;, not a single ;. > + (string-append "DLL(\"SDL2\", [\"SDL2\", \"SDL2 2.0\"," > + "\"SDL2-2.0.0\"], " > + "\"" Thee strings above can be combined. > + (dirname > + (search-input-file inputs > + "/lib/libSDL2.so")) Indentations seems a bit wonky -- if this is to not make the line too long, maybe try putting a line break between the 'string-append' and the "DLL(...= "? > + "\"" > + ")"))) These strings too. > + (arguments > + `(#:tests? #f ; Requires /dev/dri, OpenGL module, etc. > + #:phases > + (modify-phases %standard-phases Recommended style (considered more readable): (list #:tests? #f ; etcetera #:phases #~(modify-phases [etcetera])) (Many other packages don't do it like that yet, it has only be discovered recently -- I would point you at IRC logs but I'm currently offline.) Also, don't put the package definition simply at the end, that leads to merge conflicts. Instead, try keep packages alphabetical ... which is difficult here, because it has historically neglected alphebetical ordening, but maybe right after python-py would be a good fit? Otherwise, the package definition LGTM from a distance, though I only looked at the definition, I didn't check the source code (for simplifying the substitute*-ions or checking for malware) or build it. Greetings, Maxime. --=-z2W6puwtbg9VqtNYzJ1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqPCIRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7g4wAQCgNCJrLVLjUiJLSLgVxMrmbDGZ J2SLT2oPvV0Tn7yK9wD+ILQe3TN4p93i6oglUtZX/QUD3dHjk1xroX43ZQLZ1gc= =GSxk -----END PGP SIGNATURE----- --=-z2W6puwtbg9VqtNYzJ1L--