From: Ivan Kozlov <kanichos@yandex.ru>
To: 40430@debbugs.gnu.org
Subject: [bug#40430] Don’t attempt to create a module database when none are available
Date: Sat, 04 Apr 2020 19:16:15 +0300 [thread overview]
Message-ID: <5354211586005255@vla1-74bb1214b343.qloud-c.yandex.net> (raw)
The present code breaks with a non-modular kernel. This can be easily avoided.
--- a/gnu/system.scm
+++ #<buffer system.scm>
@@ -477,13 +477,19 @@
value of the SYSTEM-SERVICE-TYPE service."
(let ((locale (operating-system-locale-directory os)))
(mlet* %store-monad ((kernel -> (operating-system-kernel os))
+ (kernel-modules (package-file kernel "lib/modules"))
(modules ->
(operating-system-kernel-loadable-modules os))
+ (has-modules ->
+ (or (not (null? modules))
+ (file-exists? kernel-modules)))
(kernel
(profile-derivation
(packages->manifest
(cons kernel modules))
- #:hooks (list linux-module-database)))
+ #:hooks (if has-modules
+ (list linux-module-database)
+ '())))
(initrd -> (operating-system-initrd-file os))
(params (operating-system-boot-parameters-file os)))
(return `(("kernel" ,kernel)
next reply other threads:[~2020-04-04 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 16:16 Ivan Kozlov [this message]
2020-04-04 20:05 ` bug#40430: Don’t attempt to create a module database when none are available Danny Milosavljevic
2020-04-20 22:12 ` [bug#40430] " Ludovic Courtès
2020-06-12 18:04 ` Ivan Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5354211586005255@vla1-74bb1214b343.qloud-c.yandex.net \
--to=kanichos@yandex.ru \
--cc=40430@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).