unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei <kkebreau@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 41555-done@debbugs.gnu.org
Subject: bug#41555: [PATCH] gnu: xaos: Update to 4.0.
Date: Fri, 29 May 2020 20:11:43 -0400	[thread overview]
Message-ID: <5347e92a53aab3d3b788348795cd0efdadfb92b4.camel@posteo.net> (raw)
In-Reply-To: <20200528175505.GB23745@jasmine.lan>

On Thu, 2020-05-28 at 13:55 -0400, Leo Famulari wrote:
> On Tue, May 26, 2020 at 10:10:08PM -0400, Kei Kebreau wrote:
> > * gnu/packages/maths.scm (xaos): Update to 4.0.
> > [source]: Use git-fetch.
> > [native-inputs]: Add qtbase and qttools.
> > [arguments]: Remove #:make-flags options; replace 'configure' phase
> > and add
> > 'install-data' phase.
> > [home-page]: Update URL.
> 
> LGTM, thanks Kei!

Thanks for the review! 

FYI, I added a 'make-qt-deterministic' phase which sets the environment
variable QT_RCC_SOURCE_DATE_OVERRIDE to 1 to remove a non-determinism
issue.

Anyway, this has been pushed to master as 49de32748d.





  reply	other threads:[~2020-05-30  0:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  2:10 [bug#41555] [PATCH] gnu: xaos: Update to 4.0 Kei Kebreau
2020-05-28 17:55 ` Leo Famulari
2020-05-30  0:11   ` Kei [this message]
2020-05-30 17:11     ` Leo Famulari
2020-05-30 17:26       ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5347e92a53aab3d3b788348795cd0efdadfb92b4.camel@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=41555-done@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).