From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 6KLiCoM2PmZVaAAAqHPOHw:P1 (envelope-from ) for ; Fri, 10 May 2024 17:00:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6KLiCoM2PmZVaAAAqHPOHw (envelope-from ) for ; Fri, 10 May 2024 17:00:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=cQZ5BKmO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715353219; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wJBrVLO+xTRFlZaSCvGJF6BzOiyW4aagJRoXUW0YAHs=; b=CBG4/kwMasx5WCM2CWz72YqrDhkcWPrcr3vjL2JAtdlXpEmAUvYDqO9l2Tj3XEO4VDbaAR Asr96EGQ3q2lxokLp5ALNMYr/UtKGYvct06ZRQuKe0j8z0uuGVMCI1hNHqr7/utWb9mELG ogyuIh3Pcrx73Bb2GUkL/89pW/OAhxCrEsFgpDJ9gFoDUoqYQ5z6XOPj7FvaEgIuZ6FV1j asm33Xw5NT28tcisF68BKQk+IrBga0qOB1GznGS//T5TW3gMqoQKEFRacdcgeJSOG8oGiG 0jf1vP2APxbDci8Yzu7kG303GdGQ2Utg3OlbatUSffzE5f9c8FyX4ASKTj8lLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=cQZ5BKmO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715353219; a=rsa-sha256; cv=none; b=IO+0nnGNCA3DbfOmPGQZJoCuhiNV6mXlSv2PXAS+VG/jrulslwijPbn8Xc4uXELd0s3c8d YvpMIPfQy0FzFfezPTNGNCLznvIKJ2BwEb9Tp/TBvXAzHdwoV+fLaTG1pXXFI0mIYzt4Zw 9xD4AUm/CObcqk3OLBg1vNCQu1SGsv5+N5ZnY0igsEaOErR8nXU04zCTXmIOxgUtEF9A7n xV/IHVhwbDRMlDZA3DtCl2Qrn1MtgYmbYnk051odHq4jaLkSLtjx8mQLiZmOzsPysFX5mZ THIN9fS5f+/KhpdP+x2+YCRe2mHAUceTm2hPrwO0vtAvuCEIPWA6AhTRsPJN8Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1FDD6C342 for ; Fri, 10 May 2024 17:00:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5RjD-00012t-BN; Fri, 10 May 2024 11:00:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5RjA-00012b-AX for guix-patches@gnu.org; Fri, 10 May 2024 11:00:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5RjA-00033Y-22 for guix-patches@gnu.org; Fri, 10 May 2024 11:00:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5Rj8-0002vb-EA for guix-patches@gnu.org; Fri, 10 May 2024 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 May 2024 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Maxim Cournoyer Cc: 70282@debbugs.gnu.org, Vivien Kraus Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171535318911218 (code B ref 70282); Fri, 10 May 2024 15:00:02 +0000 Received: (at 70282) by debbugs.gnu.org; 10 May 2024 14:59:49 +0000 Received: from localhost ([127.0.0.1]:42473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Riv-0002us-4G for submit@debbugs.gnu.org; Fri, 10 May 2024 10:59:49 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Rit-0002um-Cw for 70282@debbugs.gnu.org; Fri, 10 May 2024 10:59:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8C370240027 for <70282@debbugs.gnu.org>; Fri, 10 May 2024 16:59:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715353182; bh=ZQvDzWCStT32Gt2JAYCWwIIp7CyQOa9xrELxJoqfNlc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=cQZ5BKmO5V3g1klgHLWv2XKQkB1XHp4xM4H/Pwu+HznNYl3wDk4vp18M3YFK8aJ1+ SeeP89o/WBuCvxah9rREPRIazP4NdJCCgl13+Qk7y/33MTEatJHBN82kJFtmQW65WG lYRKyfLjUCxp/zTRMgaLK4dYVcH5+bfTgbuJcI2v6Kg9Mg8ICOKv70MwGpH0P5BlBW nJKmNQDQolfxJdmvCGeWH23K2d3HpBikCMCWuj02bigsLDfriKgYBnE8B0TI4oLOMO /+KMTVAWTVNzPbWITo95oRFw2cMDHdeHf8q5eprmoPrepCCHVYPYHrIp0W7yPw2Iif 2ssJ/xkVbeQ9A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VbX993LP1z9rxF; Fri, 10 May 2024 16:59:41 +0200 (CEST) Message-ID: <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> Date: Fri, 10 May 2024 14:59:40 +0000 MIME-Version: 1.0 References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.06 X-Spam-Score: 4.06 X-Migadu-Queue-Id: E1FDD6C342 X-Migadu-Scanner: mx13.migadu.com X-TUID: lnJOuYR3BtV0 Hi Liliana and Maxim, On 09.05.24 00:11, Liliana Marie Prikler wrote: > Hi Dariqq, > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >> [...] >> >> On 08.05.24 21:51, Maxim Cournoyer wrote: >> >>> [...] >>> Perhaps a simple patch would convey the change better and be easier >>> to >>> maintain in the future / be readily available for other >>> distributions to >>> use. >> >> The simple patch that would do this is basically the patch from nixos >> in v1 of this which adds a shebang line for gjs to the service >> invocation files (rather than the dbus service invoking $gjs >> $service). The problem then is that wrap-program changes the filename >> to * .real which makes gjs unhappy. >> >> [...] >> Maybe another comment, similiar to the one Liliana suggested earlier >> in this thread, could be added at the beginning to inform about >> changing to wrap script + patch instead once that is a viable option? > The pattern we typically use is to add an autotools-style "variable", > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > substitute* to fill it in. I don't think it's a requirement, but since > Maxim suggested, it'd definitely be nice to have. > Tried this today and as the js service files are created from a common template using mesons 'configure_file' method this sets all autotools-style variables unknown to meson to the empty string. Afterwardes the susbtitute* at the wrapping phase is unable to replace anything ofc. So I think I would need to either change the naming-scheme of the placeholders or substitute them into the template file before the files get configured by meson. Do you have a preference for any option (or maybe another idea)? > Cheers > Have a nice day