From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wOW9N+sxGWQHnwAASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 05:26:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GGmDN+sxGWSScAAAauVa8A (envelope-from ) for ; Tue, 21 Mar 2023 05:26:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A1833F875 for ; Tue, 21 Mar 2023 05:26:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peTZU-0007Qa-EW; Tue, 21 Mar 2023 00:26:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peTZT-0007PJ-2B for guix-patches@gnu.org; Tue, 21 Mar 2023 00:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peTZS-0002yA-6d for guix-patches@gnu.org; Tue, 21 Mar 2023 00:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peTZS-0002h9-27 for guix-patches@gnu.org; Tue, 21 Mar 2023 00:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 04:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62156@debbugs.gnu.org Cc: Sergey Trofimov , Felix Lechner Received: via spool by 62156-submit@debbugs.gnu.org id=B62156.167937275210331 (code B ref 62156); Tue, 21 Mar 2023 04:26:02 +0000 Received: (at 62156) by debbugs.gnu.org; 21 Mar 2023 04:25:52 +0000 Received: from localhost ([127.0.0.1]:57340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peTZH-0002gY-Mh for submit@debbugs.gnu.org; Tue, 21 Mar 2023 00:25:52 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:34210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peTZD-0002g8-RU for 62156@debbugs.gnu.org; Tue, 21 Mar 2023 00:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=VQJQEkPuzdSaAgB F2GmOW1HrW3vpaozuAKDyFKVgydU=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=GzfnNUdFbM0FKGCwwzywW8ZvbSEZVz5Y3otFdSDF FRxag0rRkvd9/ObE9u/FEJvwU84Foq5mw48Byu8m1jN7HpPZ1Nb7Iq+yFGCO//Ri0ogMx5 oD6dUPWzzxDbJ3tQCS/IrrHYSuKKVTd+kBVBt4baqQpjzWN2yhDtjJnY0jJ+Y= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 1425a7e1 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Tue, 21 Mar 2023 04:25:46 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 843d9d2f; Tue, 21 Mar 2023 04:25:45 +0000 (UTC) Date: Mon, 20 Mar 2023 21:25:41 -0700 Message-Id: <52c5a50ef62af8c4331415aac52759362c89766d.1679372740.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679372779; a=rsa-sha256; cv=none; b=EQU2NELW+1bdIyptS+Eet0kPYlAJys2FcNHGjTNeSrxAaEG3cF4Nz6BgCpBd4glKSabIT+ 2133supdJO9jmPUJAJTxnLz+HRmDVh4SWV4FXbmR8UExxvOztBUjRpJlHGU3RID+WOtwfm 4CdEY63ctOOwuoeUwk8fK/f0LJbk4kIPdVExumlFgR1nk9LsrNpe5yzUPqOgXsns7daktY 46N0alxqO+qYrbiEwy6h/BkJLB7FHBB+d5X5UpqoepY43Ymazbld+gBICsAmVWwAV180mz +5VfE26SebGuODJ3L6uuJbFNjx+1A6+cMg0m8kHiyIWfZqWQq+LmWCE2TnuxcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=GzfnNUdF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679372779; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LzoZT1ambjm+iVF57HHl8Z6PIjxWxQZ/yxtsBXjMDns=; b=H9L8yF4ChOfCXCblVi7fFoljM47wEXFrRmBqk9WWfOVSdAJIyFs/darOS+p+m0rpbPq+uL Ewubhry7eH0m8PZTlIhVnhoJnQoOqfdU9PQHNz5ca/Orw+R9pSN57SQxednmkqmKI+cA71 SRy3n0yw1yL7TqZ3ZKFhlT3lD2F40+T7M5DFVMBjI3EQKGhlELjheNLx/HyTmYmdl6QJTP No0lcm9JvPNkEPnjurVLuBcV07FBM1GthXChqYVQpAfh2a1f4qB3wJhCUwjQUteVXDaBNe X4ScZh9fs4Rkjri4GJP2fHz1nChJd+rgLED/cuBGKbW0rzth0EyDI3Ae6JcEpA== X-Migadu-Spam-Score: -1.75 X-Spam-Score: -1.75 X-Migadu-Queue-Id: 6A1833F875 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=GzfnNUdF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: K8f3RZiZUVid For the atftp package added in the preceeding commit, lint produced this warning: gnu/packages/networking.scm:2924:5: atftp@0.8.0: URI https://git.code.sf.net/p/atftp/code not reachable: 404 ("Not Found") Thanks to Sergey Trofimov for suggesting a fix! [1] [1] https://issues.guix.gnu.org/62156#3 It was implemented here, and the warning disappeared. * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url. Co-authored-by: Sergey Trofimov --- guix/lint.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/guix/lint.scm b/guix/lint.scm index a1a27873d9..8d0887739d 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1224,7 +1224,14 @@ (define (warnings-for-uris uris) '()))) ((git-reference? (origin-uri origin)) (warnings-for-uris - (list (string->uri (git-reference-url (origin-uri origin)))))) + ;; for atftp, lint produced a warning: + ;; gnu/packages/networking.scm:2924:5: atftp@0.8.0: + ;; URI https://git.code.sf.net/p/atftp/code not reachable: + ;; 404 ("Not Found") + ;; fix from here: https://issues.guix.gnu.org/62156#3 + (list (string->uri (string-append + (git-reference-url (origin-uri origin)) + "/info/refs"))))) ((or (svn-reference? (origin-uri origin)) (svn-multi-reference? (origin-uri origin))) (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin)))) -- 2.39.1