From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6AJONW0jXWRYmwAASxT56A (envelope-from ) for ; Thu, 11 May 2023 19:18:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iNBeNG0jXWRfkAAAG6o9tA (envelope-from ) for ; Thu, 11 May 2023 19:18:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E8782FB2B for ; Thu, 11 May 2023 19:18:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px9vi-00016d-Kp; Thu, 11 May 2023 13:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px9vX-00016T-MO for guix-patches@gnu.org; Thu, 11 May 2023 13:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1px9vW-00065Z-Vx for guix-patches@gnu.org; Thu, 11 May 2023 13:18:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1px9vW-0007XO-Hu for guix-patches@gnu.org; Thu, 11 May 2023 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63435] Add vcmi 1.2.1 to games.scm Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 May 2023 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Vagrant Cascadian , 63435@debbugs.gnu.org Cc: iyzsong@envs.net Received: via spool by 63435-submit@debbugs.gnu.org id=B63435.168382544928934 (code B ref 63435); Thu, 11 May 2023 17:18:02 +0000 Received: (at 63435) by debbugs.gnu.org; 11 May 2023 17:17:29 +0000 Received: from localhost ([127.0.0.1]:53290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px9uz-0007Wb-0R for submit@debbugs.gnu.org; Thu, 11 May 2023 13:17:29 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:58600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px9uw-0007WL-JA for 63435@debbugs.gnu.org; Thu, 11 May 2023 13:17:27 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-966400ee79aso1155702766b.0 for <63435@debbugs.gnu.org>; Thu, 11 May 2023 10:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683825440; x=1686417440; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RB/GAJZDw/dkpXwdkVfhJPTGbR7MdBKJ7MeT2A9NB14=; b=o/S0bqiHwMi2FKWl/6OWq53T06XNr5fVl7c1IxhjjaK3pxEkX0tqRHTqU5ezX0jCaC gIo3z0MQtGwNSm2wfoBzh5CX2rWIIfi06oCCkDUjiE82ilk83rTiJTVQVmyc+kZpvw5a k3J39+oMJUW5ltlS+I8vee46Hc9AJNfGGvJuTL7uY+DDfTFY8zT5xuckVjLtehmnvrO7 LyB9KxsmaC5bYtLkAlaR1WnArGsmUevOhodFxxvXy7jN6jHw2sLrGFa2l8MU4dZzMFkS 7vkEmcSFcqYd5Mz2b+wrhyFTn1B61K2ZQWKiAs/hiDcsKQa0g8W5WXqfyxLPO1fGOWcL Z6Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683825440; x=1686417440; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RB/GAJZDw/dkpXwdkVfhJPTGbR7MdBKJ7MeT2A9NB14=; b=ArXrKrfa1cRYOeC8JWt8CRQCBDXEkuIcLhDYAsOiwV3EPJaGJLb8tz6z9LUzolXRz/ 9HQgfdf6XDcrKg5po2r9GknVNFDIZlNq8Md7YpKZ36inJTqwSQtoU4vaFf43zV9ZQjfy dqblcdFk2OLii4k7+mMGpJ3xLjnOes1cAIquQ72INdkxFqQB0EtQkPaIuEcGEt58xmL8 T76diard5fvR170Et09KzM7YpqPuDcsXdRCijRAJmQ6HbIs6Z7zC/NX+rTRTgW9boWAT kZX/Eq39+oqarA0gu3dLGT2NQi/2HAFi/NMmeeqMpgbbgksiwLULdmrL6myI+qYrsQCN Zw2w== X-Gm-Message-State: AC+VfDziU6FlTgtWIairrpPhYkik763xx9I7qadjwfV31bKzwApBlM+S WKeuXNROrFfEfFpCt+ARiHw= X-Google-Smtp-Source: ACHHUZ4wvHXJWR6eeP1Ux3nOP4TAppMpJpRIOjUlPIyBxPluMvHwdOeZ+oN8oxjAw5yB6pWBr1hK+Q== X-Received: by 2002:a17:907:36c8:b0:95e:d74b:d171 with SMTP id bj8-20020a17090736c800b0095ed74bd171mr17230242ejc.28.1683825440339; Thu, 11 May 2023 10:17:20 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id w21-20020a170907271500b00969dfd160aesm3934181ejk.109.2023.05.11.10.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 10:17:19 -0700 (PDT) Message-ID: <51be2fdd711bf490e3a925334e571ff7871d6cbb.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 11 May 2023 19:17:18 +0200 In-Reply-To: <87a5yb4e41.fsf@wireframe> References: <87a5yb4e41.fsf@wireframe> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683825517; a=rsa-sha256; cv=none; b=Z/UA7m8Rp48fnDB0eTSKau/NU1Pme4U6Wgk25wuz+fGxhaGwoFBvXbB7cGNXclE/6xNRd3 JjXHGQ/Wt32utO2Ur/VubslWcj5/rzXTogZYY4J2fOvHLqwvNOxD2ci9oZv10yBwuGTgkB bJ/0PRBufYnSwDCwYLmVgqWIkg14Rfktgo5CEGD5UsI6q1eF/YreZ4R5Pj7vgBX/EWqBRO p2lFf3IZb2WxqMeeP05k1FlOYJwr4fwV70B27nj4gepXDqBku/O3KC/G2YLJHumNDI+dLF RaG1skVkdwlfcRrLdPl0J99KZhWkGf0H9q+9svllfiC5Uc8VJiL4rmRrbVy67A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="o/S0bqiH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683825517; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RB/GAJZDw/dkpXwdkVfhJPTGbR7MdBKJ7MeT2A9NB14=; b=gBKk/i4LtOpA8E2rYlxePTjD8wKj19vwJ1Tp1+1ww91B/aXfByxxxwV5AoVG3TkYXoBY4H 5zoVcDVJzC7q7Ymka7Buki0B3GhiUZ6zxy859qiHhC4zwckkTTm57bCMF8J5ekVzRnMT3Z THB3Qd+T1SpgNJHercoVRllLld1AHbzGn0yQCODZmnX48fvREuGLiA/Aag8d+6cj7JMoMR kzQm3tTFeLdL6/R2wcCJEAAUDn90J+zZ/0sbjgLPq4GKEGoHsY99gm4sQ38AYJRmLSR8D6 yQ7dh5O7ubjeHPWoo6HZUkKJmI9OzfhuuBlkmmQNKBrvxKR9bEiMgsqoTSOG+Q== X-Migadu-Spam-Score: -1.18 X-Spam-Score: -1.18 X-Migadu-Queue-Id: 8E8782FB2B X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="o/S0bqiH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: BKJJ2QHVv3Kc Am Mittwoch, dem 10.05.2023 um 22:43 -0700 schrieb Vagrant Cascadian: > X-Debbugs-Cc: liliana.prikler@gmail.com, iyzsong@envs.net >=20 > The attached patch adds "vcmi", which is in many ways very similar to > the "fheroes2" package, in that it (currently) requires external > non-free assets, but the game engine itself is GPL2. They also both > use assets from the same game lineage (heroes of might and magic). Not my favourite kind of game, I must say, but under crapitalism you get what you pay for. > I struggled to get the tests to work, and they do not seem to be > terribly well maintained upstream. They are even disabled by default > by upstream. I did some very brief manual "testing" that it actually > works, at least! The comment you put in the source is fine for me. > I had successfully built with various qt*@6 packages, but they are > not currently building; it seems to support qt*@5 too. >=20 > Some things failed to build with gcc-11, so I tried gcc-12 and it > worked! Can you elaborate what things? I doubt it makes elaborate use of C++20/23 features, does it? > We probably want to try to apply Debian's "privacy-breach" patch to > disable phoning home, as well as the reproducible builds patch and > some additional reproducibility patches I am working on, but figured > I would submit the package to guix for review now, in case anyone > else wants to join me down this rabbit hole... Well, it won't be added to Guix without such patches, so someone needs to go down this rabbit hole. > + (native-inputs (list boost The following lines get very long, consider breaking before (list > + ffmpeg > + ;; Build errors with gcc-11 > + gcc-12 > + ;; googletest ; needed for tests, but tests > are disabled > + libxkbcommon > + luajit > + minizip > + pkg-config > + python > + ;; qtbase and qttools @6 not currently > buildable but may work ok > + qtbase-5 > + qttools-5 > + sdl2 > + sdl2-mixer > + sdl2-image > + sdl2-ttf > + tbb > + vulkan-headers > + zlib)) > + "@code{vcmi} is an implementation of Heroes of Might and > +Magic III (aka HOMM3) game engine. It requires assets and game > resources to > +play; it will look for them at @file{~/.local/share/vcmi} folder.") Use an @acronym or just spell it out. Cheers