unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ekaitz Zarraga <ekaitz@elenq.tech>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 68423@debbugs.gnu.org, Picnoir <picnoir@alternativebit.fr>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>
Subject: [bug#68423] [PATCH] guix: go-build-system: use trimpath go flag
Date: Sat, 13 Jan 2024 14:31:39 +0100	[thread overview]
Message-ID: <5171475c-288e-24c2-a91c-94ee9b7627af@elenq.tech> (raw)
In-Reply-To: <CAO+9K5om43zrhjjwK0cVs5wsNY9g0rXe3HsJGhE-aGL0xto0ug@mail.gmail.com>

Hi,

On 2024-01-13 13:58, Sharlatan Hellseher wrote:
> Hi Ekaitz,
> 
> Thanks for the patch.
> 
> I think this is more suitable for core updates brunch as triggers 
> rebuild the world for all golang packages as far as I see.

Yeah, probably.

We also thought after the patch that would be interesting to provide a 
way to disable this behavior. Or maybe it's ok?

With the previous alternative the packager would just remove the phase, 
but hardcoding the option as we did doesn't provide any way to do 
that...  Some kind of flag should be enough.

Are you ok with the patch, thought?

If this is ok we'll make those small changes and send a v2.

Thanks




  reply	other threads:[~2024-01-13 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13 11:46 [bug#68423] [PATCH] guix: go-build-system: use trimpath go flag Ekaitz Zarraga
2024-01-13 12:58 ` Sharlatan Hellseher
2024-01-13 13:31   ` Ekaitz Zarraga [this message]
2024-01-23 20:34     ` Sharlatan Hellseher
2024-03-07 12:21 ` bug#68423: " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5171475c-288e-24c2-a91c-94ee9b7627af@elenq.tech \
    --to=ekaitz@elenq.tech \
    --cc=68423@debbugs.gnu.org \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=picnoir@alternativebit.fr \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).