From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KO2bJm4mFl+CKgAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 23:19:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YGRuIm4mFl9CLQAAbx9fmQ (envelope-from ) for ; Mon, 20 Jul 2020 23:19:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D19579401CF for ; Mon, 20 Jul 2020 23:19:09 +0000 (UTC) Received: from localhost ([::1]:36182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxf3s-0001Zi-9s for larch@yhetil.org; Mon, 20 Jul 2020 19:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxf3m-0001Za-QO for guix-patches@gnu.org; Mon, 20 Jul 2020 19:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxf3m-0001bI-Hi for guix-patches@gnu.org; Mon, 20 Jul 2020 19:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxf3m-0001MH-CZ for guix-patches@gnu.org; Mon, 20 Jul 2020 19:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42283] [PATCH] gnu: Add adlplug. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Jul 2020 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42283 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 42283@debbugs.gnu.org Received: via spool by 42283-submit@debbugs.gnu.org id=B42283.15952871045176 (code B ref 42283); Mon, 20 Jul 2020 23:19:02 +0000 Received: (at 42283) by debbugs.gnu.org; 20 Jul 2020 23:18:24 +0000 Received: from localhost ([127.0.0.1]:36680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxf3A-0001LQ-Hg for submit@debbugs.gnu.org; Mon, 20 Jul 2020 19:18:24 -0400 Received: from mout01.posteo.de ([185.67.36.141]:51655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxf38-0001LD-UG for 42283@debbugs.gnu.org; Mon, 20 Jul 2020 19:18:23 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A32DE16005F for <42283@debbugs.gnu.org>; Tue, 21 Jul 2020 01:18:16 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B9d1z01pTz9rxD; Tue, 21 Jul 2020 01:18:14 +0200 (CEST) Message-ID: <5153a083968f85ddc3efd61d912733e32ee4a329.camel@zrythm.org> From: Alexandros Theodotou Date: Tue, 21 Jul 2020 00:18:09 +0100 In-Reply-To: <87365lhk49.fsf@gnu.org> References: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> <87365lhk49.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-CgKW1Sky4Hn+5gMqki9n" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=zrythm.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.01 X-TUID: /ZjxHfEUKNUq --=-CgKW1Sky4Hn+5gMqki9n Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the review. On Tue, 2020-07-21 at 00:55 +0200, Marius Bakke wrote: > > + (uri (git-reference > > + (url "https://github.com/jpcima/ADLplug.git") > > + (commit (string-append "v" version)) > > + (recursive? #t))) ; uses 3rd party submodules >=20 > Is it possible to package these modules separately? >=20 > One of the submodules, uses a seemingly non-free license: >=20 > https://juce.com/juce-5-license >=20 > Interestingly, it becomes a free license (GPL3) once you exceed a > certain revenue!? >=20 > IANAL and only had a cursory look, but am not comfortable adding this > without a larger discussion. A good first step would be to package > JUCE > separately and take it from there. The thing is that this is a fork of JUCE with some extra commits. The original JUCE doesn't include an LV2 exporter for example (after ignoring requests and patches to add it for years, it's still not there. fun thread: https://github.com/juce-framework/JUCE/issues/123 ) so I think this fork adds the LV2 exporter among other things (I also see various other commits that are not in other JUCE forks I know of). Re the license: JUCE is dual-licened under a proprietary license and GPL3+, and some modules are under the ISC license. adlplug has its source code licensed under boost, but since it includes JUCE it's essentially covered by the GPL3+ >=20 > The other bundled packages seem fine, but it would be comforting to > have > them in Guix even if this package needs the bundled versions. I also > think we should mention their licenses -- especially since vst3sdk is > available as either a proprietary license or GPL3, and taking the > latter > implies that this package _also_ becomes GPL3. Yes same as JUCE. I'll send an updated patch that mentions all the licenses. It would be nice to have the libraries in Guix anyway but I don't have much time/interest in them at the moment to do that. >=20 > (btw, the bundled fmt library is already available) >=20 > So, this will be a tricky one. Do you think you can look into > packaging > the bundled components separately? I checked them, and they seem to be fixed to specific commits and not releases. I am not sure if there's something specific in those commits that's not included in the releases that the plugin needs. I'd play it safe and use the submodules here. Thanks, Alex --=-CgKW1Sky4Hn+5gMqki9n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl8WJjEACgkQAi6uQjE9 cPOsYAf/YLfbWT8o0vibOZBMp7pnNj7eDV6OZ1UXQDz6by/6fWJs98Txpdn+9Xyy PqcM7qKVqGx4BWpYqkBdR9vT5b91MfoDAn8vYly/S9f2aAWjdqTRLku26UcVRbXQ a2EXwgIH816Og7x6BewjQkkS3cM2yhv9Zw+pifjrnOuYCeePi+6ii5Lne6vUWHxs T5TLf0vIRU/39wYIH5WdsjyF6IXrqPE9B+j7joQ9qOpN84Z2P+erEJeI7dlzzXT8 ia4W1Yp2EhERYej6vIq67rfIHlPcvXWh404XHHeG83sPZ96EmoMS20pUwdErys6q XO7hUJApFcpGt2io49vJL06X7bj+bw== =MqoS -----END PGP SIGNATURE----- --=-CgKW1Sky4Hn+5gMqki9n--