From: Kei <kkebreau@posteo.net>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 41179-done@debbugs.gnu.org
Subject: bug#41179: [PATCH] gnu: Add ecm.
Date: Wed, 13 May 2020 09:40:02 -0400 [thread overview]
Message-ID: <5034689eda7d9757057b8d64915040f33b6630fb.camel@posteo.net> (raw)
In-Reply-To: <87lflw42co.fsf@gnu.org>
On Wed, 2020-05-13 at 11:21 +0200, Mathieu Othacehe wrote:
> Hello,
>
> > + (url "https://github.com/alucryd/ecm-tools")
> > + (commit (string-append "v" version))))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > + "1rvyx5gcy8lfklgj80szlz3312x45wzx0d9jsgwyvy8f6m4nn
> > b0c"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + '(#:tests? #f ; no check target
> > + #:make-flags (list "CC=gcc"
>
> Hard-coding CC breaks cross-compilation. See 'powerstat' package for
> how
> to fix it.
>
Thanks for the pointer! It's been fixed.
> > + (string-append "DESTDIR=" (assoc-ref
> > %outputs "out")))
> > + #:phases
> > + (modify-phases %standard-phases
> > + (replace 'configure
> > + (lambda _
> > + (substitute* "Makefile"
> > + (("\\$\\(DESTDIR\\)/usr") "$(DESTDIR)"))
> > + #t)))))
> > + (home-page "https://github.com/alucryd/ecm-tools")
> > + (synopsis "Error code modeler")
> > + (description "ECM is a utility that converts ECM files to BIN
> > CD format.")
> > + (license license:gpl3+)))
>
> Maybe you could elaborate a bit on what are ECM files.
>
Done!
> Otherwise, seems fine :)
>
> Thanks,
>
> Mathieu
Thanks for reviewing. This patch has been pushed to master as commit
3480ceb10a.
Kei
prev parent reply other threads:[~2020-05-13 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 17:44 [bug#41179] [PATCH] gnu: Add ecm Kei Kebreau
2020-05-13 9:21 ` Mathieu Othacehe
2020-05-13 13:40 ` Kei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034689eda7d9757057b8d64915040f33b6630fb.camel@posteo.net \
--to=kkebreau@posteo.net \
--cc=41179-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).