From: Brian Kubisiak <brian@kubisiak.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 74633@debbugs.gnu.org, Carlo Zancanaro <carlo@zancanaro.id.au>
Subject: [bug#74633] [PATCH v2] ui: Search channels for guix extensions
Date: Tue, 7 Jan 2025 17:29:07 -0800 [thread overview]
Message-ID: <4ke6rxdjqgco4quclch6erzjtkz33pz6ofzbh6xzgshpc3us63@ohfmoaq2dnzg> (raw)
In-Reply-To: <87plle17a3.fsf@gnu.org>
> Could you send a v3 along these lines, if you think that makes sense?
Sent. Note that during testing I noticed that guile-git (and
guile-json-4) needed to be added as dependencies to a g-expression
that imported guix/build/utils.scm due to the additional dependencies
introduced in this patch. I'm probably missing more places where this
is required and Carlo's lazy import may be a better option to avoid
issues like this. Let me know what you think, I can send another
version if you think that's better.
> > +++ b/gnu/packages.scm
> > @@ -148,15 +148,16 @@ (define %package-module-path
> > (let* ((not-colon (char-set-complement (char-set #\:)))
> > (environment (string-tokenize (or (getenv "GUIX_PACKAGE_PATH") "")
> > not-colon))
> > - (channels-scm channels-go (package-path-entries)))
> > + (channels-scm (package-path-entries)))
>
> This variable is now unused; I think it can be removed.
This is still used in the below make-parameter call (not shown in the
patch), so I've left it in.
Thanks,
Brian
next prev parent reply other threads:[~2025-01-08 1:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 14:53 [bug#74633] [PATCH] ui: Search channels for guix extensions Brian Kubisiak
2024-12-02 17:25 ` Ludovic Courtès
2024-12-03 11:29 ` Carlo Zancanaro
2024-12-04 0:59 ` Brian Kubisiak
2024-12-05 0:27 ` Carlo Zancanaro via Guix-patches via
2024-12-08 22:03 ` [bug#74633] [PATCH v2] " Brian Kubisiak
2024-12-26 21:08 ` Ludovic Courtès
2025-01-08 1:29 ` Brian Kubisiak [this message]
2025-01-08 1:22 ` [bug#74633] [PATCH v3] " Brian Kubisiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ke6rxdjqgco4quclch6erzjtkz33pz6ofzbh6xzgshpc3us63@ohfmoaq2dnzg \
--to=brian@kubisiak.com \
--cc=74633@debbugs.gnu.org \
--cc=carlo@zancanaro.id.au \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).