From: Arun Isaac <arunisaac@systemreboot.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27657@debbugs.gnu.org
Subject: [bug#27657] [PATCH 3/3] gnu: wayland: Add workaround for graphviz 2.40.1.
Date: Sat, 15 Jul 2017 00:46:12 +0530 [thread overview]
Message-ID: <4f721a8c.ADkAACRbFWkAAAAAAAAAAAPUoLsAAAACwQwAAAAAAAW9WABZaRiI@mailjet.com> (raw)
In-Reply-To: <8760evj6zm.fsf@fastmail.com>
Marius Bakke writes:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/freedesktop.scm (wayland)[arguments]: Add fix-graphviz phase.
>
> Thanks!
Oops! I just got this mail, and have already pushed this patch to
staging. I'll have to make these changes a separate commit. Sorry about
the communication gap.
> [...]
>
>> + (modify-phases %standard-phases
>> + ;; Remove record shapes to workaround graphviz 2.40.1 problems
>> + ;; http://www.graphviz.org/content/i-havent-been-able-render-these-files-graphviz-226
>> + ;; This will likely be fixed upstream in the next release
>
> Please add punctuations here. Why is it likely fixed next release, is
> there a patch or bug report upstream? If so, please add them here.
I thought it will likely be fixed next release because of the following
thread:
https://lists.freedesktop.org/archives/wayland-devel/2017-June/034218.html
I'll replace this sentence with another one saying that this is a known
upstream bug.
>
>> + (add-before 'build 'fix-graphviz
>> + (lambda _
>> + (substitute* "doc/doxygen/dot/x-architecture.gv"
>> + (("Mrecord") "none")))))))
>
> And make sure this phase ends on #t.
Will do. I keep forgetting to return #t from phases. Can't Guix error
out if #t is not returned from the phase?
next prev parent reply other threads:[~2017-07-14 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170712142556.3350-1-arunisaac@systemreboot.net>
2017-07-12 14:25 ` [bug#27657] [PATCH 2/3] gnu: graphviz: Update to 2.40.1 Arun Isaac
2017-07-12 14:25 ` [bug#27657] [PATCH 3/3] gnu: wayland: Add workaround for graphviz 2.40.1 Arun Isaac
2017-07-14 16:52 ` Marius Bakke
2017-07-14 19:16 ` Arun Isaac [this message]
2017-07-14 19:28 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f721a8c.ADkAACRbFWkAAAAAAAAAAAPUoLsAAAACwQwAAAAAAAW9WABZaRiI@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=27657@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).