unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 71997@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#71997] [PATCH core-updates] gnu: gd: Skip failing test on i686-linux.
Date: Mon,  8 Jul 2024 15:21:49 +0200	[thread overview]
Message-ID: <4f2316fd90495dff085061ff05cb001d8de63a87.1720444887.git.ludo@gnu.org> (raw)

* gnu/packages/gd.scm (gd)[arguments]: Add “XFAIL_TESTS” to #:make-flags
on i686-linux.

Change-Id: I52a9cfeb352b0ec3fce4ff1f82f43c5f7bef6ef0
---
 gnu/packages/gd.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm
index 2c5ba599154..98d34cfa71e 100644
--- a/gnu/packages/gd.scm
+++ b/gnu/packages/gd.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2013, 2016, 2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2013, 2016, 2023-2024 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015, 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016, 2017 Leo Famulari <leo@famulari.name>
@@ -61,7 +61,15 @@ (define-public gd
     (arguments
      ;; As recommended by github.com/libgd/libgd/issues/278 to fix rounding
      ;; issues on aarch64 and other architectures.
-     (list #:make-flags #~(list "CFLAGS=-ffp-contract=off")
+     (list #:make-flags #~(list "CFLAGS=-ffp-contract=off"
+
+                                ;; XXX: This test fails on i686-linux.
+                                ;; See <https://issues.guix.gnu.org/71996>.
+                                #$@(if (and (not (%current-target-system))
+                                            (string-prefix? "i686"
+                                                            (%current-system)))
+                                       #~("XFAIL_TESTS=gdimagegrayscale/basic")
+                                       #~()))
            #:configure-flags #~(list "--disable-static")
            #:phases
            #~(modify-phases %standard-phases

base-commit: e4da066f0029ef38f6a791f6f9d4cfdb8b39b6a3
-- 
2.45.2





                 reply	other threads:[~2024-07-08 14:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2316fd90495dff085061ff05cb001d8de63a87.1720444887.git.ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=71997@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).