From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2NMTMc1f82LiWAAAbAwnHQ (envelope-from ) for ; Wed, 10 Aug 2022 09:35:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iCA6Mc1f82L8MAEA9RJhRA (envelope-from ) for ; Wed, 10 Aug 2022 09:35:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1C51AE42 for ; Wed, 10 Aug 2022 09:35:41 +0200 (CEST) Received: from localhost ([::1]:52222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLgFg-0003jI-GE for larch@yhetil.org; Wed, 10 Aug 2022 03:35:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLgF4-0003hM-Ss for guix-patches@gnu.org; Wed, 10 Aug 2022 03:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLgF4-0002K7-JS for guix-patches@gnu.org; Wed, 10 Aug 2022 03:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLgF4-00068J-Cs for guix-patches@gnu.org; Wed, 10 Aug 2022 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57050] [PATCH 4/6] gnu: Update Racket to 8.6. Add Zuo. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Aug 2022 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57050 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 57050@debbugs.gnu.org Received: via spool by 57050-submit@debbugs.gnu.org id=B57050.166011686523529 (code B ref 57050); Wed, 10 Aug 2022 07:35:02 +0000 Received: (at 57050) by debbugs.gnu.org; 10 Aug 2022 07:34:25 +0000 Received: from localhost ([127.0.0.1]:45879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgES-00067R-L7 for submit@debbugs.gnu.org; Wed, 10 Aug 2022 03:34:25 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:35658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgEP-00067G-Sj for 57050@debbugs.gnu.org; Wed, 10 Aug 2022 03:34:23 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4M2hX96LXnz1LZXK; Wed, 10 Aug 2022 09:34:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4M2hX96LXnz1LZXK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1660116858; bh=owapFN/JKSH4RWsuDRYj+4J5EbqKUV7LWyPQsKuc0Tc=; h=Subject:From:To:Date:In-Reply-To:References:From; b=vECP0zM+XeaM0bhBEZYKvp3Hf2hxXXtQCMue3epKE81D3EIWkeJoDLTcESFr6XlSb H8ZevjvVhTdDVPUmHnGzcAz81wkcws8SPBuvnWyj3T0uCFOWIkHcTy8AVaxYjOeiSY MHxL3okp8Xh6OT9Rcn+nk6Bp8ZG6QdMPWRJQGcLc= Message-ID: <4cc4eedb34c8fea583b2f41ed1ed52095786fe44.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Wed, 10 Aug 2022 09:34:18 +0200 In-Reply-To: <8096362.Sb9uPGUboI@avalon> References: <0d47e0372925c83fb72ff37c0f00c8196327c636.1659936550.git.philip@philipmcgrath.com> <96f3cec04fae1abefe2e4273b1aed941e3159752.camel@ist.tugraz.at> <8096362.Sb9uPGUboI@avalon> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660116941; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=owapFN/JKSH4RWsuDRYj+4J5EbqKUV7LWyPQsKuc0Tc=; b=hyS5wupTa/qy/8B5gJClFMQ6qemxnSYnleG/ZAFUj3bTu/dgsQSiG8HE1nCiXeiwHM1ViT ajW5JWNKQqwBaPs+jryBZTiLWu13YWY0I8sBpAl6DOtt+fspO9pe3OiUOD7+paUYT08Nkw 1Fo1X17pU5SN5vpo+8Q56EOEIZbDbX5QViP2LvrPzJw13BDNEKZa/EO5pf1Nrh06St+u/5 KTpjlxSCv3Ec8Yj3xg5ttWnOlad+3UODxiJRkECvQXVc1YuJ5ibb5op2mVkCBA1RkgLiDO NjFtrIeEB1DMWpQ5noeH4TMoTvAzkxOMP939OlXGVSdGKn9+sQ0asRYbJloPGw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660116941; a=rsa-sha256; cv=none; b=NCesWRCIiEDBNalxLHxOMcAiVnzS1pqx/LmcLx2jrxvPW5tcTeSsJkjejB85akdwMi5OZt 1PEsF3dR+T/ee5INK2w23En+e5IL80YjDrzabAtbbfo2/1DN4np/x4lzNAQog4BmvECOnx 5QW1LXK/aMIoO6wVkiYJxdNqjIhFUeMMkzoV2tIV1w/Q23jERGoBijolDxXeHlFf8IM4uB nA/3Dn3x2W52J5ZJnBsjB69PawjRSyzTwrRTjI/D84JcpRphArj7frDuUsgZT8xEEpQUcO ThdPMs9Y8p4yjNmKRuYi+VDrG+CPYQ0roHdpf1DaLtEiNcKl0TcUVQZj4YJtLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=vECP0zM+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=vECP0zM+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A1C51AE42 X-Spam-Score: 5.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: s7dP6Ym2t3ko Am Dienstag, dem 09.08.2022 um 16:56 -0400 schrieb Philip McGrath: > Hi, > > On Monday, August 8, 2022 5:01:31 AM EDT Liliana Marie Prikler wrote: > > You should really split this into two patches.  One to add Zuo, one > > to > > upgrade the Racket stuff.  Maybe you need even more steps if Zuo > > depends on parts of the racket bootstrap. > > > > You will probably have to parameterize the Racket origin in a bunch > > of > > packages to get things going.  As an upside, this added flexibility > > hopefully comes in handy with the next Racket upgrade. > > > > I am especially reluctant to split this patch apart. > > If I had to, I could make one patch adding the Zuo package with an > origin inheriting from the previous %racket-origin, but adjusting > the patches, commit, file name, and checksum to make the %racket- > origin in this patch. (As I wrote in the patch, Zuo has no > dependencies, it's just `cc -o zuo zuo.c`.) > Then, a second patch would make %racket-origin as it is in this > package, change Zuo to use it, and update the other packages. > > But I do not see the benefit in doing so. I would still need a commit > changing the same set of packages, short of leaving some of them > broken. And adding, then immediately removing, a temporary origin > for Zuo would seem to me to make reviewing this harder, not easier, > both now and when reviewing these changes in the future. I don't think you'd need to add an extra variable for the zuo origin, though. You can simply write (source (origin )) and once you're done switch to (source %racket-origin). That ought to be easy enough to review. As for future series, I sadly can't predict what Racket is up to next. It seems every minor release brings with it a chain of bootstrap changes and that's very exhausting (at least for me it is, but I can imagine it's not that easy for you either). We could place our hopes in the belief that the next Racket upgrade won't be that – then you simply need to bump Racket origin and that's it. But I personally fear it won't be that easy and we should prepare. > The packages developed in the main Racket Git repository are very > tightly linked.  You mean coupled. > They are developed there precisely to make sure they are all always > at consistent versions. Fighting against that is just going to cause > difficulty with every Racket update. For example, there is no > commitment that the version of Zuo released with Racket 8.5 will be > able to build Racket 8.6. > > I think this patch is better as a single commit, and at lease as > justified as commits like b97f549b14402421fcfb360ddd4cff7de93b9af0. Such commits are an exception rather than a norm, and personally, I wouldn't sign them off. Since you claim that zuo has no dependencies, this could easily be avoided, no? Cheers