From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qNX2NcI82WZP/wAA62LTzQ:P1 (envelope-from ) for ; Thu, 05 Sep 2024 05:08:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id qNX2NcI82WZP/wAA62LTzQ (envelope-from ) for ; Thu, 05 Sep 2024 07:08:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=M20PiMdV; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=GZz4ssPf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725512898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ce34yJ/GeyOWPsjIj8gvBRKBx47W33LU3d0Vj2VOa3A=; b=o7v0PX5RKlAFykd41FP/gm/UkqIC7wD/7aEiBA63oPbmWG6wK1golkeODUUu5aVe3R+r+B 4+CuFE1fwmaHGPNYnd49dkGZcxCZu/pOstXUcwP3XOCLM2AML7MNSmf2YG4W12xvxTjNrL mssYJBIBgwOtrKTpqYoCShnupZxGzlhjpqyDkqp98yBvhdhLQGV844SVFKbidTIyr2NpX4 b/yWdEqLi4eS77phvjR2UCD8ymDoXq7eIQiatggZ7FGN78TRAaTTOLL3wMpoJAvU+w2q46 RFA0Jf/WhMrpBIVjRGmaPcNgxQMwDODiPyk1tBhLj4oDzViAiuVt+bD7pkPwfw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725512898; a=rsa-sha256; cv=none; b=f17v/T2kM9qumCygrs4TgGseq0OQMx18fGVmMfSr/gZ4Am8AOlVSM8YdQTSaOmLbH2TqNy lF47fVXIpoiXfUqJvwtKjf+jIfr3YBLAkyatxV3gaHDRLI8eLsKBJg7mGM/BiAmh5qgtTl 18fxsylswUeJhcfXBL8gwSpzfxQf6qGMvFU8Ui016ODKInM9gEkHntH8YjiL4bX78tJMX+ WIdBY04/YfKTHdedVdBmV/TJmSnBLT5KoEtWjdFr6YBkdEJ+yyTjWKReNE8hQDsFWlkm83 wavYMDIx264/T2P23GvgQmr/j/ZkUy2w13uypLQwlhfEO2iv+sYjSSWD8bhBjw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=M20PiMdV; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=GZz4ssPf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B28637FAEC for ; Thu, 05 Sep 2024 07:08:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sm4iv-0006q0-5Y; Thu, 05 Sep 2024 01:08:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sm4it-0006pW-23 for guix-patches@gnu.org; Thu, 05 Sep 2024 01:07:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sm4ir-0002gV-Ib for guix-patches@gnu.org; Thu, 05 Sep 2024 01:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=ce34yJ/GeyOWPsjIj8gvBRKBx47W33LU3d0Vj2VOa3A=; b=M20PiMdV+0Lp6PlzHTPCESiB++ziUXglP4VPbAPvOf1f0oFWYo6Gq4VMJTrEkjTY30BySHKW1+Gd5bXO30GARCGxjHYgB3qNnwe9krvHLBjoG0TbGR6oySnus3VpthQzkwX+ZPz647be3ewXDCDqJiUzRkBBTFWYyGvcnY28vECCYpkl/ZAkh03D7vC1e6N49XFh/W0ws5DjlOocp9Y09sSBxZxb864gj2ScsGW0tF3EqaY1F4x0E4DOE0qHECcUBk0K5LJ/j0CjWuzKtUO+hcEDUROQQBxMtfNTIsWEqCEJD7KImWmQSVxeVkcMxK51xE2f4wjZucHRHgRb/J+cgQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sm4jt-0004TD-Qt for guix-patches@gnu.org; Thu, 05 Sep 2024 01:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72867] [PATCH v3] gexp: Make 'local-file' follow symlinks. Resent-From: Nigko Yerden Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Sep 2024 05:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: 72867@debbugs.gnu.org Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.172551291617090 (code B ref 72867); Thu, 05 Sep 2024 05:09:01 +0000 Received: (at 72867) by debbugs.gnu.org; 5 Sep 2024 05:08:36 +0000 Received: from localhost ([127.0.0.1]:35866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm4jU-0004RZ-IP for submit@debbugs.gnu.org; Thu, 05 Sep 2024 01:08:36 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:44153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm4jS-0004RI-4u for 72867@debbugs.gnu.org; Thu, 05 Sep 2024 01:08:34 -0400 Received: by mail-lf1-f66.google.com with SMTP id 2adb3069b0e04-5353cd18c20so313542e87.0 for <72867@debbugs.gnu.org>; Wed, 04 Sep 2024 22:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725512783; x=1726117583; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ce34yJ/GeyOWPsjIj8gvBRKBx47W33LU3d0Vj2VOa3A=; b=GZz4ssPfBVVFT+h/cv4Q9142iAqjIxkvAgBqsu2YZhT+cRhKhi2uIAGLYZD3M/5Rx5 xKra4o/rM7IPPR8xlcEs1J5RAOA1uIIfFNp/rl17hFqYQ7sHeBvd+nuQkfIFTkxMMVf0 blTxgKikE05+iDPiEhZqt1BAOu+NXoR11oKjr+5dAhyvfW/xixEgijJJi50OB3/ePYfE WkHKbMfpOAZGQ3eTrnXunVUK3oIUq+l2FE4nGiTCyc0uB9DQhUBTh3jdwCGX3dwf2sOm uTDouvUHMtLLROQ/O1SVfnL/TmV2Oqu4/K2Xp0tpsZ0zLGK46uCoRhabBpfYYpuRBHZV 0hSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725512783; x=1726117583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ce34yJ/GeyOWPsjIj8gvBRKBx47W33LU3d0Vj2VOa3A=; b=rH59c52x2EucIktt5hPl2hTlh+KAPVoecXncFJJnCLi7i97br5TiIfpYufDZLReHRh l/x8cg1DAQIPnMOIFHsed/cEQ+RYG7TITeLLhF0TYArXO1SU2FsQHmMT+D9MWEb0VLMt tnoY+am0AB5s8TKxj7kL2D5PG9YDXyxDhzuBjdVVrh2Wlue411awnlFU3q2xDACe7mIj cgXKZBfwRTg0WhMGTr/dmmEwUfJRW0+EpXbb8iBmejiHrhGUHY/O54Pk6Ofcw+NS/iUV vcLVkwJDAyGeESO9UKRwf97tKVcqZwIH5XZEZHnOXkFm7yM1Hl47ikQsVhUEkGhSjmf4 6k5w== X-Gm-Message-State: AOJu0Yw0Cw9OUCMgihfpT6V4XQfYbbXxHDNXheh0gGE8nQc3N68SkiH+ YU6pYNhOQKCmdU13NYae0045At2ofORQt3LkGqfz7x+D8o3zVKnZYIhVc2w9 X-Google-Smtp-Source: AGHT+IGzoHW95/+SiHY/zcSoXhofFx8d8o8a7VInHEMRBbU0w5V4bR2iOXRT5ienmM8JKGuCAiXlsg== X-Received: by 2002:a05:6512:2820:b0:52c:7fe3:d3e5 with SMTP id 2adb3069b0e04-53565f55009mr3491552e87.50.1725512783031; Wed, 04 Sep 2024 22:06:23 -0700 (PDT) Received: from [127.0.0.1] ([188.168.141.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53653ad139fsm34147e87.155.2024.09.04.22.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 22:06:22 -0700 (PDT) Message-ID: <4be8c4ec-4cc5-4b2e-8485-940b8d0f17f2@gmail.com> Date: Thu, 5 Sep 2024 10:06:22 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <2d4b593eaea4fed1fb08031a599aaab032442041.1725263612.git.nigko.yerden@gmail.com> <87zfoord4n.fsf@pelzflorian.de> Content-Language: en-US From: Nigko Yerden In-Reply-To: <87zfoord4n.fsf@pelzflorian.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.41 X-Spam-Score: -7.41 X-Migadu-Queue-Id: B28637FAEC X-Migadu-Scanner: mx11.migadu.com X-TUID: 5AxBbAYnM3JT Hello Florian, pelzflorian (Florian Pelz) wrote: > I also would favor to simplify `current-source-directory' and not add an > optional follow-symlinks? argument. I believe processing profiles is > the only reasonable case that unconditionally following symlinks would > break, and people do not do profile processing in outside code. Why do you think that making 'current-source-directory' to always follow symlinks would not break Guix's own code as well? What are these people whose code would be broken supposed to do? I think they would need to write their own 'current-source-directory' from scratch. Why not help them by providing 'follow-symlinks?' argument? Instead of 'current-source-directory' simplification we can also consider changing the default for 'follow-symlinks?' to #t. Regards, Nigko