unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nigko Yerden <nigko.yerden@gmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 72867@debbugs.gnu.org
Subject: [bug#72867] [PATCH v3] gexp: Make 'local-file' follow symlinks.
Date: Thu, 5 Sep 2024 10:06:22 +0500	[thread overview]
Message-ID: <4be8c4ec-4cc5-4b2e-8485-940b8d0f17f2@gmail.com> (raw)
In-Reply-To: <87zfoord4n.fsf@pelzflorian.de>

Hello Florian,

pelzflorian (Florian Pelz) wrote:
> I also would favor to simplify `current-source-directory' and not add an
> optional follow-symlinks? argument.  I believe processing profiles is
> the only reasonable case that unconditionally following symlinks would
> break, and people do not do profile processing in outside code.
Why do you think that making 'current-source-directory' to always follow
symlinks would not break Guix's own code as well?

What are these people whose code would be broken supposed to do? I think
they would need to write their own 'current-source-directory' from scratch.
Why not help them by providing 'follow-symlinks?' argument?

Instead of 'current-source-directory' simplification we can also consider
changing the default for 'follow-symlinks?' to #t.

Regards,
Nigko




  reply	other threads:[~2024-09-05  5:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  6:06 [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-08-29  7:01 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Attila Lendvai
2024-08-29  9:00 ` [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Ludovic Courtès
2024-08-29 10:10   ` pelzflorian (Florian Pelz)
2024-08-30 12:07     ` Nigko Yerden
2024-08-30 14:00 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Nigko Yerden
2024-08-31 17:10   ` pelzflorian (Florian Pelz)
2024-09-01 14:13     ` Tobias Geerinckx-Rice via Guix-patches via
2024-09-02  4:41 ` [bug#72867] [PATCH v2] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-09-02  7:53 ` [bug#72867] [PATCH v3] " Nigko Yerden
2024-09-03 15:05   ` pelzflorian (Florian Pelz)
2024-09-05  5:06     ` Nigko Yerden [this message]
2024-09-05  4:16 ` [bug#72867] [PATCH v4] " Nigko Yerden
2024-09-06  4:17 ` [bug#72867] [PATCH v5] " Nigko Yerden
2024-09-07  7:35   ` pelzflorian (Florian Pelz)
2024-09-25  5:16     ` pelzflorian (Florian Pelz)
2024-09-26  7:07 ` [bug#72867] [PATCH v6] " Nigko Yerden via Guix-patches
2024-10-02 16:15   ` Ludovic Courtès
2024-10-03 13:22     ` pelzflorian (Florian Pelz)
2024-10-06  7:09       ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4be8c4ec-4cc5-4b2e-8485-940b8d0f17f2@gmail.com \
    --to=nigko.yerden@gmail.com \
    --cc=72867@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).