From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8HLGNVNHqWHaZAEAgWs5BA (envelope-from ) for ; Thu, 02 Dec 2021 23:23:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aIeEMVNHqWFVDAAA1q6Kng (envelope-from ) for ; Thu, 02 Dec 2021 22:23:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84F5EC6F5 for ; Thu, 2 Dec 2021 23:23:15 +0100 (CET) Received: from localhost ([::1]:59080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msuTy-0007sg-MS for larch@yhetil.org; Thu, 02 Dec 2021 17:23:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msuTm-0007sI-8y for guix-patches@gnu.org; Thu, 02 Dec 2021 17:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msuTl-0001BS-T6 for guix-patches@gnu.org; Thu, 02 Dec 2021 17:23:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msuTl-0007yw-PF for guix-patches@gnu.org; Thu, 02 Dec 2021 17:23:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Dec 2021 22:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample , Pierre Langlois Cc: 51838@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163848375430623 (code B ref 51838); Thu, 02 Dec 2021 22:23:01 +0000 Received: (at 51838) by debbugs.gnu.org; 2 Dec 2021 22:22:34 +0000 Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msuTK-0007xr-Es for submit@debbugs.gnu.org; Thu, 02 Dec 2021 17:22:34 -0500 Received: from mail-ua1-f47.google.com ([209.85.222.47]:36516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msuTI-0007xd-Hf for 51838@debbugs.gnu.org; Thu, 02 Dec 2021 17:22:33 -0500 Received: by mail-ua1-f47.google.com with SMTP id r15so1930775uao.3 for <51838@debbugs.gnu.org>; Thu, 02 Dec 2021 14:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PVvQKjqDS+MQ2V93BSQpcZFJn9S9LckyMoMVUmt8PSI=; b=M/eJI1HSABi8bp/VvkgNIqEAvUNEtO5n9cYL4zyJ0XeSbfOb8W/7UF1ssS7aHDRKaG iIHiyCej9fochxD5AeTFZNXc1m66kjMr9AAObr8wg/3sTJeCXjm3ywfh/NFC2fgsqw90 +3bosB0XtMCsuvbmY1Un00HwI3BQ1PuHR697ahVqy/X2e0Xy4OLH4qX3vC0k1c4qisoZ 8hpQisD6dR1tr/faUkGzYRlYxIKGU7KqG91aMxQcfl0Pl3Mv/+liIv7i2fovBGG4zPog XPeJku24wUVSGg5tqWgwxecMDIYIZWZln6xrRFYDCIk589MW0s+lD0ntNc6BHoI2v+HC f+Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PVvQKjqDS+MQ2V93BSQpcZFJn9S9LckyMoMVUmt8PSI=; b=WEL5UAf6AIdfikoRoicIA+1/v4YkjQreT6D4MM4t2b226z7nu4do6d528VgAltXjKY /BSSf2ITQouGZ1eex89Q4w/CP2nya57K/O+Y0JsKPssoF3WRU4bCoLunHHIyAPT1gu7V QOqZcpNTEF0AVxC/Np1SwNI5IMANmT5AYAao7SU1t5CumgzniYFaMINShJpx/DKRXV0b 0y0b/ENkCcMlLu4+yfq08ctmChrGipDBDlGmlwbepB4b7nDKdnqwp7vls8DlEyxqjwXY 68ygB95aBOG4GlgA/hzoMaS2X9GviDp9H4X1xQlrcoVUypvaDXv0pOvGvIs/isNT0pe3 hUKA== X-Gm-Message-State: AOAM53162hsHs0eIOC+aJS+cYhbqsinJy0rUu3M4IfrYM+kAFKGRboAE 94rgwxFJGjzkGgkNwr1kpesKkQ== X-Google-Smtp-Source: ABdhPJwjZ0dI+W1WcZZImgwAOzqjqSZ4DWflXuWdwEqQYM1uQCxUZJ0TqtVKDnQh2m+yKjtc1fLqRg== X-Received: by 2002:a67:d31c:: with SMTP id a28mr18372089vsj.20.1638483747047; Thu, 02 Dec 2021 14:22:27 -0800 (PST) Received: from [192.168.45.36] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id q26sm221824vsp.23.2021.12.02.14.22.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 14:22:26 -0800 (PST) Message-ID: <4b99d8f5-73af-b1bd-bcc8-be77d87f229b@philipmcgrath.com> Date: Thu, 2 Dec 2021 17:22:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <20211114125830.45427-1-philip@philipmcgrath.com> <20211114130409.49241-1-philip@philipmcgrath.com> <20211114130409.49241-2-philip@philipmcgrath.com> <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@gmail.com> <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <87tug6bnen.fsf@ngyro.com> <87czmqk29d.fsf@gmx.com> <87ilwcm4pm.fsf_-_@ngyro.com> From: Philip McGrath In-Reply-To: <87ilwcm4pm.fsf_-_@ngyro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638483795; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PVvQKjqDS+MQ2V93BSQpcZFJn9S9LckyMoMVUmt8PSI=; b=cewdi6Cq3K8eRgweofOlqVqOsGugmgOt3aaH3eQ9eydCZqSRRSBm7t586V25DQh96U1pnf dVYC8Lnr9A8chp4RFUz2yURBfRKLDclt5y9hCe72oEH5+OrQYQegPfBvY+U0qFhBtK/le7 rGQB0oaSXqvjbP3ic7whUvMu/zoaioYGkGwLud//f9ir1eknrZy08MU2G8AEyCOPhubY4B t0UIKkxz+6k5Rdyulk2sopnaOV3G1tutRrLeZhC/hv4JBErHrP0jg50YRRVEWGyL+hojZU F2JoE7atTDDSltReSOahxOYK3TTwd2xO5FTYM8OTTl0p+1ICKrZoEjYHAJLMSQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638483795; a=rsa-sha256; cv=none; b=UXamhDYqWqaCOh5NzfMp8VuFOQ+e4uteLxxhSBbY5j8xoEfagN+rK5vv6HTSKoPUWPSx5x tuC2qoYRvrhZyd1V28lb07ZZZxrQ9ndilh/l/Oj+zvj9LGLNDdm828Pu+vyr8SpFgOPblA CA833V/mcu5TC3urWhWHqtTkHsVEtvViUvdFzRbxTsJt1a9KOcBoHkp70GPtOAwIfz9dCH CXm1BdVOAwW7ss9ubecNN/aTVssw3BtDMek8H/grueHP5lmwsvUqMNic6Gw2GlJrWOkscn Rspg96Uksb72BS0n0Wvs7/jrKH1b0kZLQW79wmLBVfLqrDpSOfEaJJPftHB4Jg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b="M/eJI1HS"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b="M/eJI1HS"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 84F5EC6F5 X-Spam-Score: -0.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: tIcKKymvMfbR Hi, On 11/28/21 14:59, Timothy Sample wrote: > Pierre Langlois writes: >> The overall approach looks good to me, it's better than what I >> originally proposed for sure :-). That being said, I'm not very >> familiar with the Node.js ecosystem so I don't know if it's necessarily >> the right way, but I suspect the correct way for node isn't very Guix-y >> so I'm not too worried about that. > > The whole Node.js bundles NPM, which bundles node-gyp, which bundles a > fork of GYP [1] is not very Guix-y at all, no. :/ This is one of those > problems (like bootstrapping GCC) that will take years of incremental > improvements and side projects and all that. It's something of a tangent, but, as I discussed briefly with Pierre in e.g. , I think it would make a lot of sense, even if we can't unbundle/bootstrap everything, to make the 355 dependencies of npm we are already distributing available as Guix packages. For example, I think I found a bootstrapping cycle with the Unicode data packages: even if the version we're currently using is messy, letting other packages use it, too, might unlock much more of the JavaScript universe. I've experimented a bit (partially looking at what Debian does), and I may look at that some time after this. > I have an idea to simplify the patch series a bit: if we can answer my > question here and come to a > conclusion about deleting lock files > , I could merge the > ‘#:absent-dependencies’ part of the patch series. I think this might > make future re-rolls easier and help rein in the scope a bit. That sounds like a great approach! I had not expected this patch series to end up touching every JavaScript package in Guix :) I was offline a bit for holidays here, and just before that I'd noticed a problem with npm generating implicit build commands that tried to rebuild node-gyp packages when they are installed. I'll page this stuff back in and send a v3 soon that hopefully has at least the '#:absent-dependencies' part ready to merge. -Philip