From: Vinicius Monego <monego@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 53750@debbugs.gnu.org
Subject: [bug#53750] [PATCH] gnu: openbox: Build with Python 3.
Date: Sun, 06 Feb 2022 17:53:57 +0000 [thread overview]
Message-ID: <4b640be44edce7b55d800976ff18f641a729f3b7.camel@posteo.net> (raw)
In-Reply-To: <Yf1xMUapEvSazdyZ@jasmine.lan>
Em sex, 2022-02-04 às 13:32 -0500, Leo Famulari escreveu:
> On Thu, Feb 03, 2022 at 03:17:12PM +0000, Vinicius Monego wrote:
> > * gnu/packages/openbox.scm (openbox): Build with Python 3.
> > [source]: Make some cosmetic changes. Add patch.
> > [inputs]: Replace python with python-wrapper.
> > [propagated-inputs]: Replace python2-xdg with python-xdg.
> > * gnu/packages/patches/openbox-build-with-python3.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
>
> Thanks! You might have noticed that I merged this patch ticket with
> my
> own similar contribution at <https://issues.guix.gnu.org/53394>.
>
Oh I didn't see that one!
> I missed the python2-xdg change in my patch, and I also did not
> replace
> python with python-wrapper. Is the latter change necessary?
>
I use the wrapper because it is more failproof with calling the correct
interpreter. The autostart header begins with:
#!@PYTHON@
Not a direct call the path in the store, don't know if it would work
with only python.
> > +From acfbbc4ea40932f183617bb7006700140fe5f61e Mon Sep 17 00:00:00
> > 2001
> > +From: Troy Curtis Jr <troycurtisjr@gmail.com>
> > +Date: Wed, 13 Sep 2017 21:59:48 -0500
> > +Subject: [PATCH] Add python3 support to openbox-xdg-autostart.
> > +
> > +Updated syntax in openbox-xdg-autostart to support both python2
> > and
> > +python3.
> > +
> > +Added a configure substitution to set the chosen python at build
> > time.
> > +
> > +https://bugzilla.icculus.org/show_bug.cgi?id=6444
> > +---
> > +Patch imported from Debian:
> > https://sources.debian.org/src/openbox/3.6.1-10/debian/patches/python3.patch/
> > with the following change: don't rename data/autostart/openbox-
> > xdg-autostart to data/autostart/openbox-xdg-autostart.in.
>
> Is this note about "Patch imported from Debian" written by you?
>
Yes, that is my own comment.
> We always try to give links to the source of patches, as well as a
> note
> that explains the context of the patch and a link to any discussions
> within Guix.
>
> So, the patch file should start with something like this:
>
> ------
> Make Openbox compatible with Python 2:
>
> https://issues.guix.gnu.org/53750
>
> Openbox seems to be abandoned upstream, with no activity in their Git
> repo since
> 2015:
>
> http://openbox.org/develop-git.php
>
> Patch copied from XXX:
>
> https://example.com/
> ------
Thanks for the suggestion. I'll check the other issue.
next prev parent reply other threads:[~2022-02-06 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 15:17 [bug#53750] [PATCH] gnu: openbox: Build with Python 3 Vinicius Monego
2022-02-04 18:32 ` Leo Famulari
2022-02-06 17:53 ` Vinicius Monego [this message]
2022-08-21 22:11 ` bug#53750: " Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b640be44edce7b55d800976ff18f641a729f3b7.camel@posteo.net \
--to=monego@posteo.net \
--cc=53750@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).