unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73064] [PATCH 0/1] gnu: oksh: Update to 7.5.
@ 2024-09-05 21:56 Luis Henriques
  2024-09-05 21:58 ` [bug#73064] [PATCH 1/1] " Luis Henriques
  0 siblings, 1 reply; 3+ messages in thread
From: Luis Henriques @ 2024-09-05 21:56 UTC (permalink / raw)
  To: 73064; +Cc: Luís Henriques

From: Luís Henriques <henrix@camandro.org>

Hi!

I'm sending an update (my first patch!) to the oksh shell.  To be honest,
this package confuses me because it's not what I would expect it to be.  I
_think_ this should be the OpenBSD portable oksh, but the information in the
package definition isn't correct (not even the license).  So, I may be
missing something.

Luís Henriques (1):
  gnu: oksh: Update to 7.5.

 gnu/packages/shells.scm | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)


base-commit: 993d6d2e7be4dac738629c76a51058f4dc5bc449
-- 
2.45.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#73064] [PATCH 1/1] gnu: oksh: Update to 7.5.
  2024-09-05 21:56 [bug#73064] [PATCH 0/1] gnu: oksh: Update to 7.5 Luis Henriques
@ 2024-09-05 21:58 ` Luis Henriques
  2024-09-16  8:19   ` bug#73064: " Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Luis Henriques @ 2024-09-05 21:58 UTC (permalink / raw)
  To: 73064; +Cc: Luís Henriques

From: Luís Henriques <henrix@camandro.org>

* gnu/packages/shells.scm (oksh): Update to 7.5.
[source]: Download from github official portable oksh project.
[home-page]: Updated to maintaners url.
[synopsis, description]: Improved with text from oksh README.
[license]: Fixed license.

Change-Id: I06f7b6210b6d725678452c5130b09c3fb382ebca
---
 gnu/packages/shells.scm | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index ec15f9d21f..b44756ffa4 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2023 Jaeme Sifat <jaeme@runbox.com>
 ;;; Copyright © 2024 Tanguy Le Carrour <tanguy@bioneland.org>
 ;;; Copyright © 2024 Vinicius Monego <monego@posteo.net>
+;;; Copyright © 2024 Luís Henriques <henrix@camandro.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -820,25 +821,32 @@ (define-public s-shell
 (define-public oksh
   (package
     (name "oksh")
-    (version "0.5.9")
+    (version "7.5")
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://connochaetos.org/oksh/oksh-"
-                           version ".tar.gz"))
+       (uri (string-append
+             "https://github.com/ibara/oksh/releases/download/oksh-"
+             version "/oksh-" version ".tar.gz"))
        (sha256
         (base32
-         "0ln9yf6pxngsviqszv8klnnvn8vcpplvj1njdn8xr2y8frkbw8r3"))))
+         "0pgdxvy8jgydsyzk7vcc93pm09bihqvrn3i35gz1ncg9z31rbf20"))))
     (build-system gnu-build-system)
     (arguments
-     `(; The test files are not part of the distributed tarball.
-       #:tests? #f))
-    (home-page "https://connochaetos.org/oksh")
-    (synopsis "Port of OpenBSD Korn Shell")
+     `(#:tests? #f)) ; there are no tests available
+    (home-page "https://github.com/ibara/oksh")
+    (synopsis "Portable OpenBSD Korn Shell")
     (description
-     "Oksh is a port of the OpenBSD Korn Shell.
-The OpenBSD Korn Shell is a cleaned up and enhanced ksh.")
-    (license license:gpl3+)))
+     "Oksh is a portable OpenBSD ksh.  Not an official OpenBSD project.
+Unlike other ports of OpenBSD ksh, this port is entirely self-contained
+and aims to be maximally portable across operating systems and C compilers.")
+    (license (list license:public-domain
+                   ;; asprintf.c, issetugid.c, reallocarray.c, sh.1,
+                   ;; strlcat.c, strlcpy.c, strtonum.c
+                   license:isc
+                   ;; confstr.c, siglist.c, signame.c, sys-queue.h, unvis.c,
+                   ;; vis.c, vis.h
+                   license:bsd-3))))
 
 (define-public loksh
   (package
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#73064: [PATCH 1/1] gnu: oksh: Update to 7.5.
  2024-09-05 21:58 ` [bug#73064] [PATCH 1/1] " Luis Henriques
@ 2024-09-16  8:19   ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2024-09-16  8:19 UTC (permalink / raw)
  To: Luis Henriques; +Cc: 73064-done

Hi Luis,

Luis Henriques <henrix@camandro.org> skribis:

> From: Luís Henriques <henrix@camandro.org>
>
> * gnu/packages/shells.scm (oksh): Update to 7.5.
> [source]: Download from github official portable oksh project.
> [home-page]: Updated to maintaners url.
> [synopsis, description]: Improved with text from oksh README.
> [license]: Fixed license.
>
> Change-Id: I06f7b6210b6d725678452c5130b09c3fb382ebca

Applied, thank you, and welcome! :-)

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-16  8:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 21:56 [bug#73064] [PATCH 0/1] gnu: oksh: Update to 7.5 Luis Henriques
2024-09-05 21:58 ` [bug#73064] [PATCH 1/1] " Luis Henriques
2024-09-16  8:19   ` bug#73064: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).