unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Ekaitz Zarraga <ekaitz@elenq.tech>, 47778@debbugs.gnu.org
Subject: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 23:39:14 +0200	[thread overview]
Message-ID: <4a8ff1b83b4d4580294833e421e34a52aa88a86e.camel@telenet.be> (raw)
In-Reply-To: <m_h_ks9CqvOZi3cTATp3NMe7nn7GQ4D_lNmHTyjumMdbRLLo0kDr2azjpMuPl_WvNRmRlYxCSteMDK_BypDhvlyVVHyzDRcVGIiHblvb_c0=@elenq.tech>

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Wed, 2021-04-14 at 15:59 +0000, Ekaitz Zarraga wrote:
> Hi,
> 
> This set of patches update freecad from unstable to the 0.19.1 release.
> 
> More information in this help-guix thread:
> 
> https://lists.gnu.org/archive/html/help-guix/2021-04/msg00118.html
> 
> Thanks!

+       `(#:tests? #f
Why's that?  ‘We’ prefer to have tests enabled when possible.
Please document why tests are disabled here (with a comment
#:tests? #f ; no tests / tests require dependency X, which is not packaged ...).

+         (add-before 'configure 'restore-pythonpath
+           (lambda _
+             (substitute* "src/Main/MainGui.cpp"
+               (("_?putenv\\(\"PYTHONPATH=\"\\);") ""))
+             #t))

The #t can be removed.  The warning that results when #t is absent
has been removed on the core-updates branch; we might as well stop
introducing these silly #t now such that we don't have to remove them
later.

Greetings,
Maxme.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2021-04-14 21:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 15:59 [bug#47778] [PATCH]: Update FreeCAD to 0.19.1 Ekaitz Zarraga
2021-04-14 21:39 ` Maxime Devos [this message]
2021-04-14 21:44   ` Ekaitz Zarraga
2021-04-14 22:58     ` Ekaitz Zarraga
2021-04-16  2:26       ` bug#47778: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a8ff1b83b4d4580294833e421e34a52aa88a86e.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=47778@debbugs.gnu.org \
    --cc=ekaitz@elenq.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).