From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2Dh9NbYfc2O82gAAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 06:12:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qIygNLYfc2MyjwAAG6o9tA (envelope-from ) for ; Tue, 15 Nov 2022 06:12:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7816E19C27 for ; Tue, 15 Nov 2022 06:12:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouoEu-0006wt-S2; Tue, 15 Nov 2022 00:12:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouoEt-0006uu-1r for guix-patches@gnu.org; Tue, 15 Nov 2022 00:12:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouoEs-0004Zj-Et for guix-patches@gnu.org; Tue, 15 Nov 2022 00:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouoEs-0003W0-2R for guix-patches@gnu.org; Tue, 15 Nov 2022 00:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59127] [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export. Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Nov 2022 05:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59127 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 59127-done@debbugs.gnu.org Received: via spool by 59127-done@debbugs.gnu.org id=D59127.166848910613490 (code D ref 59127); Tue, 15 Nov 2022 05:12:01 +0000 Received: (at 59127-done) by debbugs.gnu.org; 15 Nov 2022 05:11:46 +0000 Received: from localhost ([127.0.0.1]:52523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouoEb-0003VW-WB for submit@debbugs.gnu.org; Tue, 15 Nov 2022 00:11:46 -0500 Received: from mail-40132.protonmail.ch ([185.70.40.132]:26443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouoEZ-0003VG-5l for 59127-done@debbugs.gnu.org; Tue, 15 Nov 2022 00:11:44 -0500 Date: Tue, 15 Nov 2022 05:11:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1668489096; x=1668748296; bh=1FKYDQaOaN6dhYjBxxRxHO0+lnWx/a0r8nj3L3EoEqU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=QOp/EMr0BFljZyjnLILWRNM/kkSCM7njRZ2FdSMUN8yPSN25ftMI5t9U0+roBwDxU 2ig3hb1DhsPuuJ42omn0LkjkGJtnjV7WhR4zwdTUljEtmQF9criXxxr9JyCp5UqMp2 FXmD/7j2iFZrxk6pGW9WvUT1uATSf15yFyOo5rpC2cI9cmMH2c+S1/GL+TKrmkAgNB jM9dX8iDWItgzjTanX27GyxoO3VLFEX6bA/XzY8mMuai8/Mn27UDv3VXRtzpm8M+rC 9+EEPFv93QJlCmunkg0aOt4F2zj+bVI+p/M0tHgZDPV3oX92jRHv7tKxE0NnHUo5/j +ZglszijW02Ng== Message-ID: <4CJ5bG2LsBV82KuzfGMTCBPtWMmtYXxxGGn4P39H7z3vt5pwqDhAJA6EE_0JlnHdxxtF18sPba9xh4M7UZI-fJzYJv2l7CQVhYmP6ug-T7A=@protonmail.com> In-Reply-To: <877czyb793.fsf@envs.net> References: <877czyb793.fsf@envs.net> Feedback-ID: 33818994:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Prafulla Giri X-ACL-Warn: , Prafulla Giri via Guix-patches From: Prafulla Giri via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668489142; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1FKYDQaOaN6dhYjBxxRxHO0+lnWx/a0r8nj3L3EoEqU=; b=UfZlMOVqpq4bs74AsoM83/NiA1G8wKMdL7Wjc9mXlzrm+rbP6RZHAgFZLKxhINkiX/I3RC g1uZ7mOKrw4DoFaxoH+C/C6sUB/UudxDDFSPMVbleqqLgqZPbehzvc91rqhmZVPflSCn/l /Rtf4yvFCsrLf016/GTxK4G06rOvzHXxWvuEef5AnmRDov3JPKAmc08D7zMykXhe/Q+slW gLlqit6jVGmM3UOe6pBl/cNtevHjGm2rpSiuDfHAzqhl6AHl3wCA7aKFPuCJAfTSfNz+gS iQaYve0C1rrIG4gXLc9FEqh85xnM9KMm4vD+JDl7vvjRvQhBJMjZ1knAqS0vHQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668489142; a=rsa-sha256; cv=none; b=SVRW/+RSUlWEKYuVq0RtXbLILLxGV0SXh6yl5349Vhiqj7Qviq0IJw1HebAtLHqbgVP5SX g7UPp4BGRzQBKzQVn+1cicB99yrXdhD+IIVilyIm4JtdXBChpjeV4p8znBpd9i0YjH/HBU If0Qjo7WM5h4ES3T88ykiPwOvOH4bU5X93aFji8EtoBXryaTpWLDR8HIX8AYvB7/xrqh/D al2JY5Jasub4TqexPRR9STizRtFW/ymEXxXdZrQFgy0gy9cJN+/4/zoL09y21GUrKzfFMW N6j6p2euXEyEmi1R1SMAGaK7FWJHaFtayc+QYzgopoWO2OmB8HQFQ03zLskYpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="QOp/EMr0"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="QOp/EMr0"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7816E19C27 X-Spam-Score: -4.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: /QN0lQZ38Zl9 Thank you. The copyright year was because I introduced the guix.sh init profile back i= n 2019 but had not put the copyright year in (https://git.savannah.gnu.org/= cgit/guix.git/log/?qt=3Dauthor&q=3DPrafulla+Giri). But that's all right. (T= urns out the first patch was committed in 2020 - authored in 2019 - so it w= as wrong anyways) Cheers! ------- Original Message ------- On Monday, November 14th, 2022 at 8:12 AM, =E5=AE=8B=E6=96=87=E6=AD=A6 wrote: > Prafulla Giri prafulla.giri@protonmail.com writes: >=20 > > Hello there, > >=20 > > Here's a small patch. > >=20 > > Regards. > >=20 > > From 22a94cf122a8f01ba8078255031cc520f4f1b70d Mon Sep 17 00:00:00 2001 > > From: Prafulla Giri prafulla.giri@protonmail.com > > Date: Tue, 8 Nov 2022 13:39:21 +0545 > > Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS expo= rt. > >=20 > > This started out as a bug-fix for a GUI login loop that was resulting f= rom XDG_DATA_DIRS > > not including any of the host distro's directories. The solution was to= export the vari- > > able (with fail-safe defaults) before source-ing GUIX_PROFILE/etc/profi= le. It turns out > > changes have already been made to ensure that XDG_DATA_DIRS, etc. are a= lways exported > > before anything guix-specific. So, this export is no longer necessary. > >=20 > > For reference, the aforementioned bug was found on a Debian 11 machine = and it's guix.sh > > init profile for guix version 1.2. > > --- > > etc/guix-install.sh | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > >=20 > > diff --git a/etc/guix-install.sh b/etc/guix-install.sh > > index c8ef59d4a4..21253f538b 100755 > > --- a/etc/guix-install.sh > > +++ b/etc/guix-install.sh > > @@ -10,6 +10,7 @@ > > # Copyright =C2=A9 2021 Jakub K=C4=85dzio=C5=82ka kuba@kadziolka.net > > # Copyright =C2=A9 2021 Chris Marusich cmmarusich@gmail.com > > # Copyright =C2=A9 2021, 2022 Maxim Cournoyer maxim.cournoyer@gmail.com > > +# Copyright =C2=A9 2019, 2020, 2022 Prafulla Giri prafulla.giri@proton= mail.com >=20 >=20 > I changed copyright years to only '2022'. >=20 > Pushed, thank you!