unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#47818] [PATCH] gnu: music: Add abjad-ext-ipython
@ 2021-04-16  5:02 jgart via Guix-patches via
  2021-04-16 18:07 ` [bug#47818] abjad-ext-ipython: Added lilypond to native-inputs [updated patch] jgart via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: jgart via Guix-patches via @ 2021-04-16  5:02 UTC (permalink / raw)
  To: 47818; +Cc: Efraim Flashner

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: 0006-gnu-Add-abjad-ext-ipython.patch --]
[-- Type: application/octet-stream, Size: 2546 bytes --]

From 2288f3fab634a70c00514221e16ab2e248c65ea4 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Fri, 16 Apr 2021 00:38:23 -0400
Subject: [PATCH 6/6] gnu: Add abjad-ext-ipython.

    * gnu/packages/music.scm (abjad-ext-ipython): New variable.
---
 gnu/packages/music.scm | 45 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index e318c50beb..b709da1d03 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1639,6 +1639,51 @@ and manipulating rhythms such as accelerandi, taleas, and more.")
      "@code{abjad-ext-nauert} provides classes for dealing with composer and
 music theorist Paul Nauert's quantization grids or Q-Grids, for short.")
     (license license:expat)))
+
+(define-public abjad-ext-ipython
+  (package
+    (name "abjad-ext-ipython")
+    (version "3.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+         (url "https://github.com/Abjad/abjad-ext-ipython")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1vv0alpiz0gf5lgjfvlh4km72dvrxfqkwzxl3k4amzci3i0jzbs2"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f ; FIXME: tests are currently failing 
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (invoke "jupyter" "nbconvert" "--to=html"
+               "--ExecutePreprocessor.enabled=True" "tests/test.ipynb")
+               #t))))))
+    (native-inputs
+     `(("python-black" ,python-black)
+       ("python-flake8" ,python-flake8)
+       ("python-iniconfig" ,python-iniconfig)
+       ("python-isort" ,python-isort)
+       ("python-mypy" ,python-mypy)
+       ("python-pytest" ,python-pytest-6)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-helpers-namespace" ,python-pytest-helpers-namespace)))
+    (propagated-inputs
+     `(("abjad" ,abjad)
+       ("jupyter" ,jupyter)))
+    (home-page "https://abjad.github.io")
+    (synopsis "Abjad IPython Extension")
+    (description
+     "@code{abjad-ext-ipython} makes it possible to embed music notation in @code{jupyter}
+notebooks.")
+    (license license:expat)))
+
 (define-public non-sequencer
   ;; The latest tagged release is three years old and uses a custom build
   ;; system, so we take the last commit.
-- 
2.29.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#47818] abjad-ext-ipython: Added lilypond to native-inputs [updated patch]
  2021-04-16  5:02 [bug#47818] [PATCH] gnu: music: Add abjad-ext-ipython jgart via Guix-patches via
@ 2021-04-16 18:07 ` jgart via Guix-patches via
  2021-07-22  8:54   ` bug#47818: " Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: jgart via Guix-patches via @ 2021-04-16 18:07 UTC (permalink / raw)
  To: 47818

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Hi Guix,

Here is an updated patch that adds lilypond as a native-input. This is required for the tests to pass. See 47815.

best regards,

jgart

[-- Attachment #2: 0006-gnu-Add-abjad-ext-ipython.patch --]
[-- Type: application/octet-stream, Size: 2580 bytes --]

From 344f57d6a098239b405a0e4e31823a880614afe4 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Fri, 16 Apr 2021 00:38:23 -0400
Subject: [PATCH 6/6] gnu: Add abjad-ext-ipython.

    * gnu/packages/music.scm (abjad-ext-ipython): New variable.

*
---
 gnu/packages/music.scm | 46 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 959a0b4f6f..54d5aa1df8 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1641,6 +1641,52 @@ and manipulating rhythms such as accelerandi, taleas, and more.")
      "@code{abjad-ext-nauert} provides classes for dealing with composer and
 music theorist Paul Nauert's quantization grids or Q-Grids, for short.")
     (license license:expat)))
+
+(define-public abjad-ext-ipython
+  (package
+    (name "abjad-ext-ipython")
+    (version "3.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+         (url "https://github.com/Abjad/abjad-ext-ipython")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1vv0alpiz0gf5lgjfvlh4km72dvrxfqkwzxl3k4amzci3i0jzbs2"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f ; FIXME: tests are currently failing 
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (invoke "jupyter" "nbconvert" "--to=html"
+               "--ExecutePreprocessor.enabled=True" "tests/test.ipynb")
+               #t))))))
+    (native-inputs
+     `(("lilypond" ,lilypond)
+       ("python-black" ,python-black)
+       ("python-flake8" ,python-flake8)
+       ("python-iniconfig" ,python-iniconfig)
+       ("python-isort" ,python-isort)
+       ("python-mypy" ,python-mypy)
+       ("python-pytest" ,python-pytest-6)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-helpers-namespace" ,python-pytest-helpers-namespace)))
+    (propagated-inputs
+     `(("abjad" ,abjad)
+       ("jupyter" ,jupyter)))
+    (home-page "https://abjad.github.io")
+    (synopsis "Abjad IPython Extension")
+    (description
+     "@code{abjad-ext-ipython} makes it possible to embed music notation in @code{jupyter}
+notebooks.")
+    (license license:expat)))
+
 (define-public non-sequencer
   ;; The latest tagged release is three years old and uses a custom build
   ;; system, so we take the last commit.
-- 
2.29.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#47818: abjad-ext-ipython: Added lilypond to native-inputs [updated patch]
  2021-04-16 18:07 ` [bug#47818] abjad-ext-ipython: Added lilypond to native-inputs [updated patch] jgart via Guix-patches via
@ 2021-07-22  8:54   ` Efraim Flashner
  0 siblings, 0 replies; 3+ messages in thread
From: Efraim Flashner @ 2021-07-22  8:54 UTC (permalink / raw)
  To: jgart; +Cc: 47818-done

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

I made some progress on the test suite but I think there's still
something missing that's making it not quite work.

Patch pushed!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-22  8:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16  5:02 [bug#47818] [PATCH] gnu: music: Add abjad-ext-ipython jgart via Guix-patches via
2021-04-16 18:07 ` [bug#47818] abjad-ext-ipython: Added lilypond to native-inputs [updated patch] jgart via Guix-patches via
2021-07-22  8:54   ` bug#47818: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).