unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#70202] [PATCH] doc: Add message for common error about make check-system
@ 2024-04-04 21:17 Richard Sent
  2024-06-17 11:50 ` pelzflorian (Florian Pelz)
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Sent @ 2024-04-04 21:17 UTC (permalink / raw)
  To: 70202; +Cc: Richard Sent

* doc/guix.texi: Mention that make clean may need to be run before running
make check-system when previous builds were run with different work trees. See
https://issues.guix.gnu.org/47573.

Change-Id: I39d465961637d9fc6b11f59e1500770220780b4c
---
Hi Guix!

Ran into this issue myself. It seems common enough to be worth
mentioning in the docs, similar to the message in (guix) Building from
Git.

I found my solution from https://issues.guix.gnu.org/47573.

>    If you get an error like this one:
> 
>      configure.ac:46: error: possibly undefined macro: PKG_CHECK_MODULES


 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index ef9e4216b4..72cac183a5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1177,6 +1177,23 @@ Running the Test Suite
 substitutes are available for their dependencies (@pxref{Substitutes}).
 Some of them require a lot of storage space to hold VM images.
 
+If you encounter an error like this one:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistency in the work tree from previous builds.  Try
+running:
+
+@example
+make clean && make
+@end example
+
 Again in case of test failures, please send @email{bug-guix@@gnu.org}
 all the details.
 

base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#70202] [PATCH] doc: Add message for common error about make check-system
  2024-04-04 21:17 [bug#70202] [PATCH] doc: Add message for common error about make check-system Richard Sent
@ 2024-06-17 11:50 ` pelzflorian (Florian Pelz)
  2024-06-17 12:13   ` Richard Sent
  0 siblings, 1 reply; 3+ messages in thread
From: pelzflorian (Florian Pelz) @ 2024-06-17 11:50 UTC (permalink / raw)
  To: Richard Sent; +Cc: 70202

Hello Richard, I am hesitant because I cannot reproduce the error and it
might be better to fix it rather than document it.  Looking at,

Richard Sent <richard@freakingpenguin.com> writes:
> * doc/guix.texi: Mention that make clean may need to be run before running
> make check-system when previous builds were run with different work trees. See
> https://issues.guix.gnu.org/47573.

I assume by work tree you do not mean a work tree produced by `git
worktree`, but the state of the source directory.  So:

Léo Le Bouter <lle-bout@zaclys.net> writes
<https://issues.guix.gnu.org/47573>:
> $ make check-system
> Compiling Scheme modules...
> ice-9/eval.scm:142:16: In procedure compile-top-call:
> error: channel-source->package: unbound variable
> hint: Did you forget `(use-modules (gnu ci))'?
>
> make: *** [Makefile:6305: check-system] Error 1

and:

Richard Sent <richard@freakingpenguin.com> writes:
> +Compiling Scheme modules...
> +ice-9/eval.scm:142:16: In procedure compile-top-call:
> +error: all-system-tests: unbound variable
> +hint: Did you forget `(use-modules (gnu tests))'?

I do not understand Guix well enough why this could happen.  Since `make
clean-go` helps, the cause must be in Guix’ .go files and not some
cache.  In Makefile.am, the check-system target depends on $(GOBJECTS).

I presume gnu/tests.go and gnu/ci.go should be added to GOBJECTS?
Or gnu/tests.scm and gnu/ci.scm should be added to MODULES?

But I do not really understand.

Regards,
Florian




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#70202] [PATCH] doc: Add message for common error about make check-system
  2024-06-17 11:50 ` pelzflorian (Florian Pelz)
@ 2024-06-17 12:13   ` Richard Sent
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Sent @ 2024-06-17 12:13 UTC (permalink / raw)
  To: pelzflorian (Florian Pelz); +Cc: 70202

Hi Florian,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes:

> Hello Richard, I am hesitant because I cannot reproduce the error and it
> might be better to fix it rather than document it.  Looking at,

I can't reliably reproduce the error myself. It simply "comes up" every
now and then if I switch between branches with an existing build and try
rebuilding Guix and rerunning the tests. Agreed, a fix would be
preferred. I have absolutely no idea how.

> I do not understand Guix well enough why this could happen.  Since `make
> clean-go` helps, the cause must be in Guix’ .go files and not some
> cache.  In Makefile.am, the check-system target depends on $(GOBJECTS).
>
> I presume gnu/tests.go and gnu/ci.go should be added to GOBJECTS?
> Or gnu/tests.scm and gnu/ci.scm should be added to MODULES?

I don't believe the issue is limited to those two files in particular
(although it could be). That just happened to be the file causing the
problem when I caught the error and pasted it in the doc.

> But I do not really understand.

That makes two of us. :)

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-17 12:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04 21:17 [bug#70202] [PATCH] doc: Add message for common error about make check-system Richard Sent
2024-06-17 11:50 ` pelzflorian (Florian Pelz)
2024-06-17 12:13   ` Richard Sent

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).