From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ALdrMmg4N2Hj8wAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 12:01:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oEMHLmg4N2FMDgAAbx9fmQ (envelope-from ) for ; Tue, 07 Sep 2021 10:01:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94EAB65E3 for ; Tue, 7 Sep 2021 12:01:12 +0200 (CEST) Received: from localhost ([::1]:56628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNXuh-0003DI-Lf for larch@yhetil.org; Tue, 07 Sep 2021 06:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNXuZ-0003Bx-1M for guix-patches@gnu.org; Tue, 07 Sep 2021 06:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNXuY-0001Va-PY for guix-patches@gnu.org; Tue, 07 Sep 2021 06:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNXuY-00048D-HX for guix-patches@gnu.org; Tue, 07 Sep 2021 06:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 4/4] upstream: Support updating git-fetch origins. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163100884715849 (code B ref 50072); Tue, 07 Sep 2021 10:01:02 +0000 Received: (at 50072) by debbugs.gnu.org; 7 Sep 2021 10:00:47 +0000 Received: from localhost ([127.0.0.1]:55449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNXuI-00047Z-Vi for submit@debbugs.gnu.org; Tue, 07 Sep 2021 06:00:47 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:37340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNXuH-00047O-2y for 50072@debbugs.gnu.org; Tue, 07 Sep 2021 06:00:45 -0400 Received: from butterfly.local ([188.188.3.227]) by laurent.telenet-ops.be with bizsmtp id qy0i2500W4tskic01y0jej; Tue, 07 Sep 2021 12:00:43 +0200 Message-ID: <470a95f159120d14384c3096cff91e3ce8d3c6c8.camel@telenet.be> From: Maxime Devos Date: Tue, 07 Sep 2021 12:00:42 +0200 In-Reply-To: <86mtopi3s7.fsf@mgsn.dev> References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <86mtopi3s7.fsf@mgsn.dev> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-3W3wFcBMFBedcZevcPSQ" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1631008843; bh=IYUU/W/pUIzsQ3BLfyq7oDgDZA3jUENYJlyUusxNxq8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Tuh9TXNkMnT+iHVtAphzuU+tkt7JbeFBsgWHRydn34gDQ4V37ya1DgJ7+lcvLvTGJ WY+DUYYjWmTFWOmHAScZkyE1iazUnLPDT3pJGlEMEkFSqBfr7UFyBvx/WDxtXj/6ZP iuAWWbBc8PxVG60vzPfHDbwBm8semKtkQy3tLRl8P28KH/nIinFBFCzrSa5dWLyALa M7fOAr/uUI1BOsncJQGFJwCafeDtUBrAlUbKme74RUCYmDvBe1242izOEnGmHtEhIz k5e3SpG4VN0eMNThwratSDWXVp/Z9odyKjp6FlaFcgfex8lwmvCPlxWf2FkggauD2/ bTGxQJPmmQYzQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 94EAB65E3 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: akB3rbJbLzmA --=-3W3wFcBMFBedcZevcPSQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sarah Morgensen schreef op ma 06-09-2021 om 18:16 [-0700]: > Hi Maxime, >=20 > Maxime Devos writes: >=20 > > Sarah Morgensen schreef op zo 15-08-2021 om 16:25 [-0700]: > > > * guix/git-download.scm (checkout-to-store): New procedure. > > > * guix/upstream.scm (guess-version-transform) > > > (package-update/git-fetch): New procedures. > > > (%method-updates): Add GIT-FETCH mapping. > >=20 > > Does it support packages defined like (a) > >=20 > > (define-public gnash > > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") > > (revision "0")) > > (package > > (name "gnash") > > (version (git-version "0.8.11" revision commit)) > > (source (git-reference > > (url "https://example.org") > > (commit commit))) > > [...]))) >=20 > Thinking about this again, since updaters typically returns actual > versions (tags) instead of commits, how much would such a > feature be used? The minetest updater returns version numbers. It also returns a git-reference object, which includes the commit. Just returning a version number often isn't sufficient, because many repositories of minetest mods do not keep version tags. See . Greetings, Maxime. --=-3W3wFcBMFBedcZevcPSQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYTc4ShccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oCxAP9Ij02MwmdqzRHO0untiA8XMwvQ 5mIZFI/F4rGBs+bFVAEA/HGbTDWV65zhq7GRhx3iSkL8dQ7TNZLaOhn1KKNnpAc= =OfIQ -----END PGP SIGNATURE----- --=-3W3wFcBMFBedcZevcPSQ--