From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEK0t-0001zu-EA for guix-patches@gnu.org; Wed, 10 Apr 2019 16:40:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEK0r-00062U-Eu for guix-patches@gnu.org; Wed, 10 Apr 2019 16:40:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40022) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEK0o-00060g-Od for guix-patches@gnu.org; Wed, 10 Apr 2019 16:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEK0o-0002Oj-J7 for guix-patches@gnu.org; Wed, 10 Apr 2019 16:40:02 -0400 Subject: [bug#35086] [PATCH] New package file for BOINC client & server Resent-Message-ID: Mime-Version: 1.0 Message-Id: <47063553-553c-461d-abce-0f6732bc84ac@www.fastmail.com> In-Reply-To: <87zhoxc335.fsf@gnu.org> References: <17ee4c77-7bf9-4a4c-b856-f9ca4ff3c7db@www.fastmail.com> <87zhoxc335.fsf@gnu.org> Date: Wed, 10 Apr 2019 16:39:22 -0400 From: "Brant Gardner" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35086@debbugs.gnu.org Good afternoon; On Wed, Apr 10, 2019, at 10:06, Ludovic Court=C3=A8s wrote: > Hello Brant, >=20 > "Brant Gardner" skribis: >=20 > > This is my first submission for contributing to Guix, so any feedbac= k or advice is welcomed! >=20 > Thanks for joining! >=20 > I have some suggestions below, but overall it=19s a great start! >=20 > > From 2946bd1c83a2ea224841d22463992be599dfc385 Mon Sep 17 00:00:00 20= 01 > > From: Brant Gardner > > Date: Tue, 2 Apr 2019 11:09:45 -0500 > > Subject: [PATCH] Added distributed.scm > > > > New package file for BOINC and other distributed-computing projects.= This > > initial file just includes boinc-client and boinc-server, both at ve= rsion > > 7.14.2. >=20 > The convention is to write commit logs in =1CChangeLog format=1D, as > described at: >=20 > https://www.gnu.org/prep/standards/html_node/Change-Logs.html >=20 > But you can simply look at =18git log=19 and mimic what you see. (You= might > also want to take a look at > > if you haven=19t already.) >=20 Yeah, I was following the guide but I had accidentally already committed= before I read the part on commit log format. I'll make a new one that = follows the pattern this time. > As for the module name, what about boinc.scm instead? =1CDistributed=1D= > sounds a bit too generic to me. > Done :) =20 > > +++ b/gnu/packages/distributed.scm > > @@ -0,0 +1,119 @@ > > +;;; GNU Guix --- Functional package management for GNU > > +;;; Copyright .=C2=A9 2014, 2015 Ludovic Court.=C2=A8s > > +;;; Copyright .=C2=A9 2016, 2017, 2018, 2019 Efraim Flashner > > +;;; Copyright .=C2=A9 2018 Tobias Geerinckx-Rice > > +;;; Copyright .=C2=A9 2018 Mathieu Othacehe >=20 > It should be just you here. :-) >=20 Got it, done. > > + #:use-module (gnu packages autotools) > > + #:use-module (gnu packages base) > > + #:use-module (gnu packages compression) > > + #:use-module (gnu packages databases) > > + #:use-module (gnu packages pkg-config) > > + #:use-module (gnu packages tls) > > + #:use-module (gnu packages curl) > > + #:use-module (gnu packages wxwidgets) > > + #:use-module (gnu packages gnome) > > + #:use-module (gnu packages gtk) > > + #:use-module (gnu packages perl) > > + #:use-module (gnu packages sqlite) > > + #:use-module (gnu packages python) > > + #:use-module (gnu packages python-xyz)) >=20 > I think you can trim this list. >=20 I don't believe so, I arrived at that list via 'build, fail on missing d= ependency, find it, add it, repeat'. This was the result - I know it's = long and varied but it appears to be correct unless I misunderstand how = to properly do dependencies. > > + (synopsis "BOINC lets you help cutting-edge science research us= ing your computer") >=20 > What about something like =1CContribute computing power to research pr= ojects=1D? >=20 Sure thing - but to be clear, these aren't my words. I copied/pasted fr= om the project homepage 'About' section. I figured they wrote it, they = knew how to describe it. > > + (description "BOINC is a platform for high-throughput computing= on a large > > +scale (thousands or millions of computers). It can be used for vol= unteer > > +computing (using consumer devices) or grid computing (using organiz= ational > > +resources). It supports virtualized, parallel, and GPU-based appli= cations. > > + > > +BOINC is distributed under the LGPL open source license. It can be= used for > > +commercial purposes, and applications need not be open source.") >=20 > This last paragraph is unnecessary: everything in Guix is free softwar= e, > so we never mention it in descriptions. Got it, done. >=20 > > + (synopsis "BOINC lets you help cutting-edge science research us= ing your computer") > > + (description "BOINC is a platform for high-throughput computing= on a large > > +scale (thousands or millions of computers). It can be used for vol= unteer > > +computing (using consumer devices) or grid computing (using organiz= ational > > +resources). It supports virtualized, parallel, and GPU-based appli= cations. >=20 > It would be nice to have a slightly different synopsis and description= > for the server and for the client. > Understood, I'll go over it and try to differentiate them a bit. > Apart from that it LGTM! Could you double check that =18guix lint=19 = is > happy and send an updated patch? >=20 Hmm. I already ran 'guix lint' and did everything it advised except for= these: gnu/packages/boinc.scm:45:12: boinc-client@7.14.2: the source URI should= not be an autogenerated tarball gnu/packages/boinc.scm:80:12: boinc-server@7.14.2: the source URI should= not be an autogenerated tarball I understand what it doesn't like, but not what it wanted me to do inste= ad. Could you advise? > Thank you! >=20 > Ludo=19. > -- Brant Gardner