unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: 46833@debbugs.gnu.org
Subject: [bug#46833] [PATCH v2] import: hackage: Accept optional version parameter.
Date: Sun, 28 Feb 2021 17:18:34 +0100	[thread overview]
Message-ID: <46c8c5cd27542ec7304eb5209edd8db4e00e16de.1614529058.git.public@yoctocell.xyz> (raw)
In-Reply-To: <223714e238a28dad4dbbd66a2fa506582a44992a.1614528863.git.public@yoctocell.xyz>

* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
  Make REPO a key.
---
Ugh, made a typo in the commit summary.

 guix/import/hackage.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
   (memoize hackage->guix-package))
 
 (define* (hackage-recursive-import package-name . args)
-  (recursive-import package-name #f
-                    #:repo->guix-package (lambda (name repo)
+  (recursive-import package-name
+                    #:repo->guix-package (lambda* (name #:key repo version)
                                            (apply hackage->guix-package/m
                                                   (cons name args)))
                     #:guix-name hackage-name->package-name))
-- 
2.30.0






  reply	other threads:[~2021-02-28 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 16:16 [bug#46832] [PATCH] import: hackage: Accept optional version paramter Xinglu Chen
2021-02-28 16:18 ` Xinglu Chen [this message]
2021-03-01 16:02   ` bug#46833: [PATCH v2] import: hackage: Accept optional version parameter Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46c8c5cd27542ec7304eb5209edd8db4e00e16de.1614529058.git.public@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=46833@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).