From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cObkMtqoqWGMrQAAgWs5BA (envelope-from ) for ; Fri, 03 Dec 2021 06:19:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0ByeLtqoqWFAOgAAB5/wlQ (envelope-from ) for ; Fri, 03 Dec 2021 05:19:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7441131F10 for ; Fri, 3 Dec 2021 06:19:22 +0100 (CET) Received: from localhost ([::1]:55922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt0yf-0000Te-Gd for larch@yhetil.org; Fri, 03 Dec 2021 00:19:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt0yN-0000TU-BD for guix-patches@gnu.org; Fri, 03 Dec 2021 00:19:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mt0yM-0007Vn-5z for guix-patches@gnu.org; Fri, 03 Dec 2021 00:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mt0yL-00085V-Pq for guix-patches@gnu.org; Fri, 03 Dec 2021 00:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Dec 2021 05:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , Timothy Sample , Jelle Licht Cc: 51838@debbugs.gnu.org Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163850869031026 (code B ref 51838); Fri, 03 Dec 2021 05:19:01 +0000 Received: (at 51838) by debbugs.gnu.org; 3 Dec 2021 05:18:10 +0000 Received: from localhost ([127.0.0.1]:49873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0xW-00084M-Kf for submit@debbugs.gnu.org; Fri, 03 Dec 2021 00:18:10 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0xS-00083u-Lv for 51838@debbugs.gnu.org; Fri, 03 Dec 2021 00:18:09 -0500 Received: by mail-wr1-f66.google.com with SMTP id a18so3238281wrn.6 for <51838@debbugs.gnu.org>; Thu, 02 Dec 2021 21:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Y/vafsL0PP1pyk5iYm63COizwR86OHsipL8JvhhL0DM=; b=V6uPlkNGNn5BxIKPdYzssyzXWj7TaQiHF90YuTYIVgVzC0fQnskDBmryhWq3wwdSy3 Rtb2/QCS+0ZtfY1igNV/FinMN3DSXJRmZRYCyHLhO10818pfGg0bKSMxOrTpA56phSZ1 FccuPRvmxjLuDvQjjvhLCBja4OLR34SoXbIiWCLWPK2atcR3mN1jJftw5AiQB8HoNqEo iDetreP4YSeQWL60AnE10PTM3U2eN6ktjw/oOBnK6GnADPcwK1C0hE9Px+6Gr7DNFlDl uFXXOuu/IoDLLscG4mCvA0LstmvmJlP83CZP7qrj/whN0OyTpAQ0VnYNuY7mUtuEgdsB SmNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Y/vafsL0PP1pyk5iYm63COizwR86OHsipL8JvhhL0DM=; b=Q/8B0EhGspGDu9nwmAVvhGVJiUTYwCCOldbEQYEgWMhysAyKknSlXRESG2Q6wBmX29 KvHyMY4Se44sp8lAKIZ3sJoiTwUxbI6JRze0L+RNhlG87M5U5RNJDw5n2vR2txHqbhCa SIbOZrGZHlnTozQY7iw96cZiHsSXBhMYjXOu3Lf3CKo7AdteiVWZtzh4A+2Me8tnAY6j i9eFr2FivgPOYM8TFfjI6o50ueLxAVut2dggreqxrMPnBvLlnKpP8MepZH30K0Dk/+KO JJGr22DoZSJN94qqyXjr7osre1gXB3GdQVtVdQ4OrmDq+9Pvr+11zhLz6QhpyeW0821p EVng== X-Gm-Message-State: AOAM531f2VHKDeUMqZxbA3jZMoQcGIb1thgMpIauymhtABEVc62co4/R imzs1VC0sx9qKrNjQPpRcE8= X-Google-Smtp-Source: ABdhPJxE/6n4BZm2DSKDzlTZ7T4Pa/DY1U+IW0lkwylMyTKou0YP+4SQgNAkxTFZ1u60JfUlzZg3UA== X-Received: by 2002:a5d:4704:: with SMTP id y4mr19074798wrq.85.1638508680617; Thu, 02 Dec 2021 21:18:00 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id v6sm4030270wmh.8.2021.12.02.21.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 21:18:00 -0800 (PST) Message-ID: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 03 Dec 2021 06:17:58 +0100 In-Reply-To: References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-10-philip@philipmcgrath.com> <86tug39lps.fsf@fsfe.org> <87pmqkm5u1.fsf_-_@ngyro.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638508762; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Y/vafsL0PP1pyk5iYm63COizwR86OHsipL8JvhhL0DM=; b=gp0xSzo0JZLpMhe00UUttIOCuCoYSc3ybnJYtNl0UF4aZmkxzEfgGPax0n32hO3k/OZPot KRGqagUf96jV5M2WoQOJS9IaIhVz8A5J4BU4519xJYikZtpg0VDXMp29kSSYa6Je+VJgnX VpAp5NaL5KMMFVUaert/A4bkmra8V6Nl/2je/N+8u0Wv3n796IatA995ATc9k10/OMBc64 w/T4ZozNG42ZQM+U+WIgi1GCsCZvg0GKrkomUFHsqi70gweK6RFDc68A4fNMnxwiwY3s4w e6hWKY5nGfdmQh03dFdUFy6Go7DLGDnZc9wrJ4peshKPYL4ZtObyhznEWOxnHA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638508762; a=rsa-sha256; cv=none; b=Kog2LED2O/yZ3e/y66ejgigl2rv6hSrIsIWeStCt227eWfXwBTvDpS1/fCblLO+y9bFZ6R jUdd6/daPDGAcTQvrSSycX8KywSlD81O+wtXOrH/K6nOZDb2D1ecVoM2msBpUhAd+kQZGM MPL3gJ2so4emGlyNWwGK9dYkzac7lm1IId9REym3shOV0vqDsgqIgRmPI/dEsZJuASD9bL gSDhi8PckUegz28vBXv140aLGQR0p5NURVfXD/SPr6D5dG0HXrrhw9C1aNmATrfzcsAbtm chWffkxnlgdHFHRnIxwkXvp7SSRHdAcbp8iYuSi/vn31VvNN9xU2G1eEVMghAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=V6uPlkNG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=V6uPlkNG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7441131F10 X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6s5lbsfMv2qJ Hi, Am Donnerstag, den 02.12.2021, 16:18 -0500 schrieb Philip McGrath: > On 11/28/21 14:35, Timothy Sample wrote: > > Jelle Licht writes: > > > From what I have seen package-lock.json offers us no benefits > > > (because we track exact dependency information via the guix > > > store) and can (as you have seen) prevent builds from working. My > > > 2c: always remove it in a phase in the build system. > > > > I’m inclined to agree with Jelle and Liliana. I can’t imagine a > > situation in which we would want the lock files. We could be > > wrong, but we can always adjust the build system later if something > > surprising happens (e.g., ‘#:keep-lock-file?’ or whatever). > > This makes sense to me. Should we also delete "yarn.lock" (respected > as of npm v7)[1] and "npm-shrinkwrap.json"[2]? It seems like the > same reasons probably apply. If it breaks builds, then yes. > We might want to handle "node_modules/.package-lock.json"[3], too, > but that seems less likely to exist. What are node_modules in this context? To me that sounds like "vendored packages" and if so, they ought to (ideally) be deleted in a snippet way before unpack. Meaning you wouldn't have to handle that case in configure. Cheers