From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id uKb6FAAlPWZbXAEAqHPOHw:P1 (envelope-from ) for ; Thu, 09 May 2024 21:33:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uKb6FAAlPWZbXAEAqHPOHw (envelope-from ) for ; Thu, 09 May 2024 21:33:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Cn9PJq0h; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715283200; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=4GWXK46DKkPpfKxVF5e3d8+Anf5i+1a6vW9DraMfkX4=; b=mfYnbF7KF7lFTIMJzsWhC5VxNZSblg/h9a5QTyguoPaG54LHixZVFqp+PP1cFe9sAU6idI lpMJEXxoKWHAJBhNocdfe9lhS/4OBwNjhmPZlzcyH70RrrynU1rKgNe8I1n997rzPALgdt w7kaymLA/SVSsd9anVHK+wv3cSzQvbyC9H4FtjCYBOH77zkJMuels17MOSLsGDbBqT2p2L wX76vIqNtGmxH9L7tc1/z44roUTI6R37ppCNwcwsFK8thPsMWspu8543qXgCB360kXcKgU rNFnYD2C1cZbkLBml9WOyei8cTgYUqNVFzl+VfQKfGPlKqPsNlWtmrI8XXpc4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Cn9PJq0h; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715283200; a=rsa-sha256; cv=none; b=ffmdV7McU1tU1b2CD4NJLfj2HX/BifHXXUUe6Yb6YnKG/agoJDe21zZ3/VZJpjkGFeWE0a J12wcL1F8bIQKUzwqi47mkuK/I2MXX4nXbqYOIowrKA1nhuoDq2W/OOa4ISyL6s1rtVuAc wSc0OdnKESLhPyApg1ev8bGceIkuxNirflqSM/IW3tW5gy7cmT5n0xQ5LECg1Ph8PWR1b1 hc0XrDm4B2hAIkQBNdEY0GPqT2C0HD+FH9SQooUDDRLN0GoSNsJPJII0zpxdtLU8PTqBGw kkVuPlEZVMLju0kzz0jeZiIUVa9wSF0heeOU8s9P1/5XAjUQ0EN0wgrJdnGitA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D0CA2590A for ; Thu, 9 May 2024 21:33:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s59Vy-00010i-7Y; Thu, 09 May 2024 15:33:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59Vu-00010M-RW for guix-patches@gnu.org; Thu, 09 May 2024 15:33:12 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s59Vo-00024J-Bv for guix-patches@gnu.org; Thu, 09 May 2024 15:33:09 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s59Vm-0000ij-J8 for guix-patches@gnu.org; Thu, 09 May 2024 15:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70845] [PATCH] services: Add fancontrol-service-type Resent-From: Adrien 'neox' Bourmault Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2024 19:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70845@debbugs.gnu.org Cc: Denis 'GNUtoo' Carikli Received: via spool by 70845-submit@debbugs.gnu.org id=B70845.17152831732762 (code B ref 70845); Thu, 09 May 2024 19:33:02 +0000 Received: (at 70845) by debbugs.gnu.org; 9 May 2024 19:32:53 +0000 Received: from localhost ([127.0.0.1]:40821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59Vc-0000iU-RU for submit@debbugs.gnu.org; Thu, 09 May 2024 15:32:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59VY-0000iM-Bs for 70845@debbugs.gnu.org; Thu, 09 May 2024 15:32:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59TO-0000tR-4H; Thu, 09 May 2024 15:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:To:From: Subject; bh=4GWXK46DKkPpfKxVF5e3d8+Anf5i+1a6vW9DraMfkX4=; b=Cn9PJq0hSBAvxML6n XpFkqH2TjgTfNa6RMUurae9cIcJn/RNJRp4uSDz7GEA78BxgcI2DOfHeUgeFvJZxa0Zc9ps3pZZwY tK4V9XHqOrUcuZ8/liOLir3Rdd4Vm6yMTb0Vxn7T103XbpKjEqQzIwwLmSRW0Kytuv47DbU+/PBi7 61XJ1ttaiYntOpLKWtlMPt/7tDqA0pnRcqGg880i9hW9BiLHrrGBt2ebl56WItilWsIv84mq83MwH 7MDuapt3/hdAx7aVqP9vKxM4nmP9GzBttUKJFVZ5HXuoAQ2HC9px33QZezStVVJElurJYm/RN5yRY 6t/5iL80wdhNRsr1w==; Message-ID: <452c2d78e57c54b313decb40dbfeb59315e63131.camel@gnu.org> From: Adrien 'neox' Bourmault In-Reply-To: <20240509193942.20e6ec8e@primary_laptop> References: <20240509193942.20e6ec8e@primary_laptop> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-BOpegENNGiY7Hto99fsU" Date: Thu, 09 May 2024 21:30:10 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.68 X-Migadu-Queue-Id: 1D0CA2590A X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.68 X-TUID: G+IxJaNqqBBX --=-BOpegENNGiY7Hto99fsU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 09 mai 2024 =C3=A0 19:39 +0200, Denis 'GNUtoo' Carikli a =C3=A9cri= t=C2=A0: > Hi, >=20 > Thanks a lot for the patch. >=20 > For the record I'm not a Guix maintainer / committer, and that I > didn't look at everything but I spotted something that could be > improved: the user has no way to override the lm-sensors package being > used. >=20 > Most services provide a way to do that kind of override, so it would > make sense to add that at some point. >=20 > Denis. Hi and thanks for you feedback. Not every service I saw allows such overrid= e, but it seems indeed a good idea. However, it would complicate a bit this pa= tch as it would require to create a proper configuration type for the service a= nd I also did not dig into that (did not have much time). Someone else might be = able to do it. Happy hacking! --=20 Adrien Bourmault Maintainer, GNU Boot project Associate member, Free Software Foundation GPG : 393D4CC68136F39799DA75F295F65F55F682A17A --=-BOpegENNGiY7Hto99fsU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQ5PUzGgTbzl5nadfKV9l9V9oKhegUCZj0kQgAKCRCV9l9V9oKh ei1/AP9xElgZxK2ktrKwcNtCS8z6vMU5qbgzlgxkInkfgJYX5gD/Vn7Vq3dAtRgU 6DTfn76VNp0b6ozu+Bvr2Nd4yRtrjg8= =lBEY -----END PGP SIGNATURE----- --=-BOpegENNGiY7Hto99fsU--