From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2AYmN7omP2YykAAAe85BDQ:P1 (envelope-from ) for ; Sat, 11 May 2024 10:05:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2AYmN7omP2YykAAAe85BDQ (envelope-from ) for ; Sat, 11 May 2024 10:05:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ablptLXq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715414714; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bEhUls9KYN/kajS2I1BUKoGhr5imUw39mhqhhXXl0pc=; b=lIZDdqBee70JuyzlQxyNfINH6/qVF2sgVoboW4/b1h7Iv/ni2Q29lqgfeAUPb52rlaAoJa /+9OCjKY5OzEzUnX13huxygrBrqqpMhXUSalVcX5oPhQDw+aIvadteXePM+avJvRL44TQN bYL1sjSq/zaFP2DfQyAGy3kiH8bJck7arwD+fp/QYM+UHxfN0PuXcpbAj5D23HxY48YWrD vkzo2PHjmC9fjKQ9oaLhwpGLm/5D21Dsc9Rynf0CRwQOZpQEPWKCtkwUP9UKrnfGktARB0 bQ4DwLMVVIDFh4/OSOiCQo4vcjTpqRCHhKnDucToN0uztuMxpbfcTsVsxvgAJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ablptLXq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715414714; a=rsa-sha256; cv=none; b=tcfYXV6qKcDMya6/hD0ZM/faIhXMdBvvV5tt5/cJ2Gry0aPmLk3Fr9axVEc7ebId6jGGW4 YmVc4PNRuXANXIcCkjUFdnFZrHzKpqkmnJxNjQzUq/weO7Kbb4HbZUaNK1SKDO+Mc74C/H WqrQXHNbAXPEGyoV+Osr1MjVu3Q+ichXwI1cibQKrMCvWlVfS1Ur+9zGrwEZ/S5Y0r0xW5 TPgix3v0zSXlVOngvSBZ4nKP06ln4wA1ACBFuZYeQLUG3J0xg+yTVLclqyw6Rg1DfFpRst SuMVnmNF4z+4zqw5lUt9N4rnZX+Edd20p3SN9cg1CWwwJqguDumktZ0nmjFHvQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B3A1F63EB1 for ; Sat, 11 May 2024 10:05:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5hj8-00031H-6Y; Sat, 11 May 2024 04:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5hj5-00030p-Ba for guix-patches@gnu.org; Sat, 11 May 2024 04:05:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5hj5-0007fa-0s for guix-patches@gnu.org; Sat, 11 May 2024 04:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5hj3-0006TT-PL for guix-patches@gnu.org; Sat, 11 May 2024 04:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 May 2024 08:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Maxim Cournoyer Cc: 70282@debbugs.gnu.org, Vivien Kraus Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171541464724828 (code B ref 70282); Sat, 11 May 2024 08:05:01 +0000 Received: (at 70282) by debbugs.gnu.org; 11 May 2024 08:04:07 +0000 Received: from localhost ([127.0.0.1]:46910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5hiB-0006SO-3K for submit@debbugs.gnu.org; Sat, 11 May 2024 04:04:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5hi8-0006Ru-Sb for 70282@debbugs.gnu.org; Sat, 11 May 2024 04:04:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4FE5724002A for <70282@debbugs.gnu.org>; Sat, 11 May 2024 10:03:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715414639; bh=iIgkygLTr42WPySyUEkj8PgWJbg5wxgRGk3hgGlA5cw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=ablptLXqeIgMksAJttuZASaQQIPGvPiG536sPWoc98ckfaiPE5SIp/GozHVFxvxns COUoxeNY964aTGoxzENOw6G3Qfsc3WHR2LwOa9BIPBPKdDZUYPRQyw49qBu6IKJuY7 lFUMn97FgthROuwkyaecuzONFxXwMeR3sBjErmf0X6zI0niyUg3t4I3cG/PqNiVeOm Dz4yHdDC01Ev4X9YVwkVBflpvLfC+CVwCkurugL4110DHSzzjdSpB269cumAiYBjGS lSVnW8/2BQW9JzxVqOj/lZAyAENAQV9SxYV6Vrc89JxnHp4kV59BiVSTTDLSEB4gEr 8yLDtXpPUi6Tw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Vbyv21Kzjz6ty3; Sat, 11 May 2024 10:03:58 +0200 (CEST) Message-ID: <44b03f63-e82c-4f62-9d92-3d64007c3f10@posteo.net> Date: Sat, 11 May 2024 08:03:57 +0000 MIME-Version: 1.0 References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.92 X-Spam-Score: 3.92 X-Migadu-Queue-Id: B3A1F63EB1 X-Migadu-Scanner: mx13.migadu.com X-TUID: ez2woxkhz8is On 10.05.24 18:04, Liliana Marie Prikler wrote: > Am Freitag, dem 10.05.2024 um 14:59 +0000 schrieb Dariqq: >> Hi Liliana and Maxim, >> >> On 09.05.24 00:11, Liliana Marie Prikler wrote: >>> Hi Dariqq, >>> >>> Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >>>> [...] >>>> >>>> On 08.05.24 21:51, Maxim Cournoyer wrote: >>>> >>>>> [...] >>>>> Perhaps a simple patch would convey the change better and be >>>>> easier >>>>> to >>>>> maintain in the future / be readily available for other >>>>> distributions to >>>>> use. >>>> >>>> The simple patch that would do this is basically the patch from >>>> nixos >>>> in  v1 of this which adds a shebang line for gjs to the service >>>> invocation files (rather than the dbus service invoking $gjs >>>> $service). The problem then is that wrap-program changes the >>>> filename >>>> to * .real which makes gjs unhappy. >>>> >>>> [...] >>>> Maybe another comment, similiar to the one Liliana suggested >>>> earlier >>>> in this thread, could be added at the beginning to inform about >>>> changing to wrap script + patch instead once that is a viable >>>> option? >>> The pattern we typically use is to add an autotools-style >>> "variable", >>> e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use >>> substitute* to fill it in.  I don't think it's a requirement, but >>> since >>> Maxim suggested, it'd definitely be nice to have. >>> >> >> Tried this today and as the js service files are created from a >> common template using mesons 'configure_file' method this sets all >> autotools-style variables unknown to meson to the empty string. >> Afterwardes the susbtitute* at the wrapping phase is unable to >> replace anything ofc. >> >> So I think I would need to either change the naming-scheme of the >> placeholders or substitute them into the template file  before the >> files get configured by meson. > Or you add an option to meson_options.txt to fill it in, so that you > can provide the right value via #:configure-flags I'd want to avoid putting the environement variables together myself and rather use getenv to retrieve the value at build time though. Don't think that would work with #:configure-flags > > Cheers Have a nice day