From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 50273-done@debbugs.gnu.org
Subject: bug#50273: [PATCH v2] gnu: Add python-pyxel.
Date: Tue, 31 Aug 2021 23:27:02 +0200 [thread overview]
Message-ID: <44a347b0986ca73f95439d912bf8cb512316ee2a.camel@student.tugraz.at> (raw)
In-Reply-To: <87r1eak7a4.fsf@gmail.com>
Am Montag, den 30.08.2021, 16:27 -0400 schrieb Maxim Cournoyer:
> Hey Leo,
>
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > * gnu/packages/game-development.scm (python-pyxel): New variable.
> > ---
> > Am Montag, den 30.08.2021, 14:40 -0400 schrieb Maxim Cournoyer:
> > > > + (let* ((sdl2 (assoc-ref inputs "sdl2")))
> > > > + (substitute* "pyxel/core/Makefile"
> > > > + (("`sdl2-config --cflags`")
> > > > + (string-append "-I" sdl2 "/include/SDL2
> > > > -D_REENTRANT"))
> > > > + (("`sdl2-config --libs`")
> > > > + (string-append "-L" sdl2 "/lib "
> > > > + "-Wl,-rpath," sdl2 "/lib "
> > > > + "-Wl,--enable-new-dtags
> > > > -lSDL2"))))))
> > >
> > > The above could benefit from some extra commenting to explain the
> > > choice of linker options (--enable-new-dtags ?) or C preprocessor
> > > variables
> > > (-D_REENTRANT). I'd have to dig a bit deeper than I'd like to
> > > have an
> > > understanding of these.
> >
> > These were previously snarfed from a manual invocation of sdl2-
> > config, but
> > iskarian in IRC pointed out, that sdl2-config accepts --prefix, so
> > the patch
> > has been revised to use that.
>
> Great! I'm glad that I asked :-)
>
> > gnu/packages/game-development.scm | 51
> > +++++++++++++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> >
> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> > development.scm
> > index 2a58848dce..40807450ea 100644
> > --- a/gnu/packages/game-development.scm
> > +++ b/gnu/packages/game-development.scm
> > @@ -1484,6 +1484,57 @@ visual novels, while its Python scripting is
> > enough for complex simulation
> > games.")
> > (license license:expat)))
> >
> > +(define-public python-pyxel
> > + (package
> > + (name "python-pyxel")
> > + (version "1.4.3")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri
> > + (git-reference
> > + (url "https://github.com/kitao/pyxel")
> > + (commit (string-append "v" version))))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9"))
> > + (modules '((guix build utils)))
> > + (snippet
> > + '(begin
> > + (delete-file-recursively "pyxel/core/bin")))))
> > + (build-system python-build-system)
> > + (arguments
> > + `(#:tests? #f ; "Tests" are actually example programs that
> > never halt.
> > + #:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'patch-build-files
> > + (lambda* (#:key inputs #:allow-other-keys)
> > + (substitute* "setup.py"
> > + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch)
> > + (if (string=? arch "linux")
> > + all
> > + "")))
> > + (substitute* "pyxel/core/Makefile"
> > + (("`sdl2-config")
> > + (string-append "`sdl2-config --prefix="
> > + (assoc-ref inputs "sdl2"))))))
> > + (add-before 'build 'prebuild
> > + (lambda _
> > + (invoke "make" "-C" "pyxel/core"))))))
> > + (inputs
> > + `(("gifsicle" ,gifsicle)
> > + ("sdl2" ,(sdl-union (list sdl2 sdl2-image)))))
> > + (native-inputs
> > + `(("gcc" ,gcc-10))) ; for std::filesystem
> > + (home-page "https://github.com/kitao/pyxel")
> > + (synopsis "Retro game engine for Python")
> > + (description "Pyxel is a game engine inspired by retro gaming
> > consoles.
> > +It has a fixed 16-color palette, can hold up to 3 image banks and
> > 8 tilemaps
> > +(256x256 pixels each) and 4 sound channels with 64 definable
> > sounds. It
> > +also comes with a built-in image and sound editor.")
> > + (license license:expat)))
> > +
>
> LGTM. Feel free to push (and then close this tracker)!
>
> Maxim
Aaaaand done :)
prev parent reply other threads:[~2021-08-31 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 15:30 [bug#50273] [PATCH] gnu: Add python-pyxel Leo Prikler
2021-08-30 18:40 ` Maxim Cournoyer
2021-08-30 19:02 ` [bug#50273] [PATCH v2] " Leo Prikler
2021-08-30 20:27 ` Maxim Cournoyer
2021-08-31 21:27 ` Leo Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a347b0986ca73f95439d912bf8cb512316ee2a.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=50273-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).