From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qB+IAKuyQWE4IQAAgWs5BA (envelope-from ) for ; Wed, 15 Sep 2021 10:45:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KLbQN6qyQWE4EwAAbx9fmQ (envelope-from ) for ; Wed, 15 Sep 2021 08:45:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03A5D28C4A for ; Wed, 15 Sep 2021 10:45:30 +0200 (CEST) Received: from localhost ([::1]:47692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQXo-0002WZ-UR for larch@yhetil.org; Wed, 15 Sep 2021 04:45:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQXO-0002WK-Nz for guix-patches@gnu.org; Wed, 15 Sep 2021 04:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQQXO-00058r-7K for guix-patches@gnu.org; Wed, 15 Sep 2021 04:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQQXO-0000s0-3m for guix-patches@gnu.org; Wed, 15 Sep 2021 04:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50359] [PATCH 3/3] import: Add 'generic-git' updater. Resent-From: iskarian@mgsn.dev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Sep 2021 08:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50359 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Xinglu Chen" , 50359@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 50359-submit@debbugs.gnu.org id=B50359.16316954813295 (code B ref 50359); Wed, 15 Sep 2021 08:45:02 +0000 Received: (at 50359) by debbugs.gnu.org; 15 Sep 2021 08:44:41 +0000 Received: from localhost ([127.0.0.1]:50831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQQX3-0000r5-4S for submit@debbugs.gnu.org; Wed, 15 Sep 2021 04:44:41 -0400 Received: from out2.migadu.com ([188.165.223.204]:54869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQQX0-0000qv-SA for 50359@debbugs.gnu.org; Wed, 15 Sep 2021 04:44:40 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631695477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/560hck3gl4aDjQNlJGLO5RXT9aQriQgkBb0VWZc53k=; b=jfkmYfJ1AQBid/roEbS9JshRdMUEFvHjvLCgRARFtMi/kw+BRKy5cn3firqZgVzdUwpimg 5XbGgm/JDzgdRwSLpcHra562cqhHA0npRoJyFNSh6IDWSwmHHhoS6QGpLU/3QM/bs0NUvp QLEk/kuwseIn+BzK6ni78bmNSW6u3P4= Date: Wed, 15 Sep 2021 08:44:35 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: iskarian@mgsn.dev Message-ID: <44519ae5dfdf3702dc73903b80314a6a@mgsn.dev> In-Reply-To: <5d10dd1e65b0a65ada4a8102310c10de42f53e8d.1631290349.git.public@yoctocell.xyz> References: <5d10dd1e65b0a65ada4a8102310c10de42f53e8d.1631290349.git.public@yoctocell.xyz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631695530; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/560hck3gl4aDjQNlJGLO5RXT9aQriQgkBb0VWZc53k=; b=czAD8s4UDZ3ICPcXNao5iAw59Tftd56vhF582aMaoCVazFAGmhq3L71HajGmm8GfjatuJ+ URzGiVjIsCv2I6lHn8cRa4IZK442QyresYEo2rToJy8dkQC9pLwxZuUwZQMyYDDagskKYh opNdDcPqIGfnCt2CKiV23Jz6U4OZO5lOki5gWvDFbSPLjxZi4Uupx8ZcefUHgTMbW45iGF 8kGspaq34gAbVlK6SLbXpgQ5EUIWES41gwpNWh14D17TYvF9t4Pqx1aqrmBdAV4eYFJJCF tPewz/YKJoQvLBT9h51YM9jKv6wct1lbfOX15EjPfb+sdWxgP26LfPn+MNLBDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631695530; a=rsa-sha256; cv=none; b=JWrVIaNlwnvUi1ER8qRvDdyQoVWkToTha2vJRK5faNEJEsBfiaJxUEeJEvYJncIcFz0efq GKNH3new0PZOiaeUhS26YFo1e6/VhpE/qUDxPp16akq8Pi9ppTuDqWm2qFbabkZkgdbpNi ADWEfkJUVGL+OOw0grt3MQTRsW2mUSSaoYJ+ghX/1S127QyJLEmUgOxGngFFHmqXg+WZ+y nVAH1l1TOeBu4pGuvpfSx+1+IEURSdG4zfwId47wm9Y9ZIzSjZKre2Ys6AFlNtn6Ucecso RGHEbuejSdwU62qKwY8pt8vAp4RWQg9ozrULqvDbIhcOb9K2Q6XLYbnfDn1EYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=jfkmYfJ1; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=jfkmYfJ1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 03A5D28C4A X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: GMhXaOVf1UJN Hi,=0A=0ASeptember 10, 2021 9:21 AM, "Xinglu Chen" = wrote:=0A=0A> * guix/git.scm (ls-remote-refs): New procedure.=0A> * test= s/git.scm ("remote-refs" "remote-refs: only tags"): New tests.=0A> * guix= /import/git.scm: New file.=0A> * doc/guix.texi (Invoking guix refresh): D= ocument it.=0A> * tests/import-git.scm: New test file.=0A> * Makefile.am = (MODULES, SCM_TESTS): Register the new files.=0A> =0A> Co-authored-by: Sa= rah Morgensen =0A=0AOverall this is looking good. Tha= nk you for adding tests (for remote-refs as well!), much appreciated. It= looks like you've done some good polishing. I see a few nits, which I'l= l point out in a separate email when I'm not on mobile. I'll also give i= t a good test.=0A=0ABut... I've been thinking about the overall approach = for a couple days, because I'm not very happy with the complexity of my h= euristic.=0A=0AThere can be a lot of weird tags in a repository--look at = the one for xf86-video-intel for example. My heuristic attempts to captu= re the assumption that repostories tend to move from using "_" or "-" to = "." but it does fail to account for moving to or from dates (because date= s don't compare with normal versions).=0A=0AI also realized that we are n= ot using a very useful piece of information--the previous version/tag com= bo. I expect that in the vast majority of cases, the version delimiter f= or the newest version will be the same as the version delimiter for the l= ast known version. (Perhaps the prefix as well?) Can we use this inform= ation to make our guesses better? What do you think?=0A=0ADespite saying= all that, it's probably better to not try to get it perfect on the first= go--we can always adjust the internals later. We just want to avoid sho= wing bogus updates.=0A=0A(Later, I think I'll put together a dataset of t= ags and current versions to see if I can test how well a particular algor= ithm works.)=0A=0A--=0ASarah (mobile)