From: mirai@makinata.eu
To: 60014@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>
Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well.
Date: Mon, 12 Dec 2022 17:45:47 +0000 [thread overview]
Message-ID: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> (raw)
From: Bruno Victal <mirai@makinata.eu>
special-files is a list of 2-tuples (pairs) but matching against
a non-list pair would fail as match-lambda was only matching
against a list pattern.
---
gnu/build/activation.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/build/activation.scm b/gnu/build/activation.scm
index 10c9045740..d4a7559651 100644
--- a/gnu/build/activation.scm
+++ b/gnu/build/activation.scm
@@ -341,7 +341,7 @@ (define (activate-special-files special-files)
"
(define install-special-file
(match-lambda
- ((target file)
+ ((or (target file) (? pair? (= car target) (= cdr file)))
(let ((pivot (string-append target ".new")))
(mkdir-p (dirname target))
(symlink file pivot)
base-commit: 5fb5af5658b7575a945579a7cf51c193600b76bb
--
2.38.1
next reply other threads:[~2022-12-12 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:45 mirai [this message]
2022-12-12 20:34 ` [bug#60014] [PATCH] activation: make install-special-file match against pairs as well Josselin Poiret via Guix-patches via
2022-12-12 20:52 ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 22:25 ` mirai
2022-12-13 20:04 ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 22:09 ` mirai
2022-12-13 10:15 ` Josselin Poiret via Guix-patches via
2022-12-13 13:04 ` mirai
2022-12-13 19:56 ` Josselin Poiret via Guix-patches via
2022-12-20 14:47 ` Ludovic Courtès
2022-12-21 13:20 ` mirai
2022-12-21 13:31 ` [bug#60014] [PATCH v2] doc: Clarify special-files-service-type expected value mirai
2023-02-18 2:33 ` Bruno Victal
2023-03-21 14:15 ` bug#60014: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu \
--to=mirai@makinata.eu \
--cc=60014@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).